When NO_ZPIPE is defined, fcntl.h is not included in WrFFrI.c
although OpenWriteFile uses open, O_WRONLY, O_CREAT and O_TRUNC.
* src/WrFFrI.c: unconditionally include fcntl.h regardless
of NO_ZPIPE being defined or not.
---
Note, this fixes the build on MS Windows where FOR_MSW triggers
Hi,
I would like feedback about this patch (do not consider it ready to merge!)
The GetXIDRange function in dix/resource.c can show incredibly bad performance
in some cases; it can degenerate to O(N*2) behavior and make the system
completely unusable.
(see
Without this fix, the X server is unusable on platforms where char
defaults to unsigned.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
___
Hi Dave,
On Mon, May 27, 2013 at 08:56:34 +1000, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
If all of these limits are pushed to their mask, then / 4 won't stop
I assume s/mask/max/
the malloc from being overflowed.
Signed-off-by: Dave Airlie airl...@redhat.com
---
On Mon, May 27, 2013 at 09:45:06 +1000, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
Al Viro pointed this out on lwn, and I think this patch should fix it,
but making sure we don't do the addition as 32-bit on 64-bit machines.
How about this instead:
diff --git a/src/XvMC.c
On 05/26/13 04:54 PM, Dave Airlie wrote:
So reviewing the libXi security fix made me double take, there was a
few lines like
if (sizeof(xDeviceAbsCalibState) nbytes)
goto out;
size += sizeof(XDeviceAbsCalibState);
Now either size is always 0 going
I can't give this a full review, but off-hand it seems like a good idea
to me!
Changing the max hash size should probably be a separate commit with a
commit message justifying it.
There's some precedent for putting common data structures in shared code
in xserver, notably include/list.h.
First: check for allocation failure on the mask.
XI2 requires that the mask is zeroed, so we can't just Data() the mask
provided by the client (it will pad) - we need a tmp buffer. Make sure that
doesn't fail.
Second:
req-mask_len is a uint16_t, so check against malicious mask_lens that would
size += blah is technically correct but it implies that we're looping or
otherwise incrementing the size. Which we don't, it's only ever set once.
Change this to avoid reviewer confusion.
Reported-by: Dave color-me-confused Airlie airl...@redhat.com
Signed-off-by: Peter Hutterer
If we skip over the reply data, return 0 as number of event classes.
Follow-up to 6dd6dc51a2935c72774be81e5cc2ba2c30e9feff.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/XGetProp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/XGetProp.c
10 matches
Mail list logo
