Re: [PATCH libICE] Use arc4random when available to produce the auth cookie.

2013-09-06 Thread Alan Coopersmith
On 09/ 4/13 12:40 AM, Matthieu Herrb wrote: @@ -58,6 +62,9 @@ IceGenerateMagicCookie ( if ((auth = malloc (len + 1)) == NULL) return (NULL); +#ifdef HAVE_ARC4RANDOM_BUF +arc4random_buf(auth, len); +#else #ifdef ITIMER_REAL { struct timeval now; @@ -79,8 +86,8

[libICE patch v2] Use arc4random when available to produce the auth cookie.

2013-09-06 Thread Matthieu Herrb
arc4random() and associated functions can be found in libbsd on GNU/Linux systems. Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr --- configure.ac | 3 ++- src/iceauth.c | 11 ++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index

Re: [PATCH libICE] Use arc4random when available to produce the auth cookie.

2013-09-06 Thread Matthieu Herrb
On Thu, Sep 05, 2013 at 10:52:43PM -0700, Alan Coopersmith wrote: On 09/ 4/13 12:40 AM, Matthieu Herrb wrote: @@ -58,6 +62,9 @@ IceGenerateMagicCookie ( if ((auth = malloc (len + 1)) == NULL) return (NULL); +#ifdef HAVE_ARC4RANDOM_BUF +arc4random_buf(auth, len); +#else

Re: [PATCH] DMX glxproxy: Don't allocate copy data just to free it unused

2013-09-06 Thread Alex Deucher
On Thu, Sep 5, 2013 at 8:43 PM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Two functions in the DMX glxproxy code loop over all the backend screens, starting at the highest numbered and counting down to the lowest. Previously, for each screen, the code would allocate a buffer large

[PATCH] xfree86: go further with legacy PCI bus probe for non-seat0 seats (#66851)

2013-09-06 Thread Laércio de Sousa
This fixes a bug that prevents X.Org from starting properly on, e.g., NVIDIA cards with proprietary drivers, when -seat option is passed with an argument different from seat0. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=66851 Signed-off-by: Laércio de Sousa lbsous...@gmail.com ---

Re: [libICE patch v2] Use arc4random when available to produce the auth cookie.

2013-09-06 Thread Alan Coopersmith
On 09/ 5/13 11:43 PM, Matthieu Herrb wrote: arc4random() and associated functions can be found in libbsd on GNU/Linux systems. Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr Thanks for revising it, Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com -- -Alan Coopersmith-