Re: [PATCH:xf86-input-mouse] Use asprintf (or Xprintf on old servers) instead of strdup+sprintf

2013-10-23 Thread Alan Coopersmith
On 10/21/13 03:02 PM, Peter Hutterer wrote: On Sat, Oct 19, 2013 at 09:51:31PM -0700, Alan Coopersmith wrote: +/* Xorg >= 1.10 provides an asprintf() implementation even if libc doesn't */ +#include "xorgVersion.h" +#if defined(HAVE_ASPRINTF) || \ +(XORG_VERSION_CURRENT >= XORG_VERSION_NUME

Re: [PATCH:libX11] Xcms file parsing should not require the impossible to succeed

2013-10-23 Thread Alan Coopersmith
On 10/23/13 01:45 PM, Alan Coopersmith wrote: > This has gone unnoticed since 1991, until gcc -Wlogicalop came to our rescue, and https://bugs.freedesktop.org/show_bug.cgi?id=70803 was filed. And I probably should have mentioned it's gone unnoticed because the effect is truly minor - it's only

[PATCH:libX11] Xcms file parsing should not require the impossible to succeed

2013-10-23 Thread Alan Coopersmith
The field2 helper function, to split lines from Xcms.txt files into two tab delimited fields, contained a check: if ((*pBuf != '\n') || (*pBuf != '\0')) { return(XcmsFailure); which would cause it to return failure unless *pBuf had a value that was simultaneously equal to both \n & \0

Re: [PATCH] glx: Add support for the new DRI loader entrypoint.

2013-10-23 Thread Keith Packard
Eric Anholt writes: > This is going to be exposed (and not the old entrypoint) for some DRI > drivers once the megadrivers series lands, and the plan is to > eventually transition all drivers to that. Hopefully this is > unobtrusive enough to merge to stable X servers so that they can be > compa

Re: Updates to the Present and DRI3 extension specifications

2013-10-23 Thread Keith Packard
davya...@free.fr writes: > ("a client can send a new PresentPixmap request, even if > the last one hasn't completed yet. It won't cancel the last > request, but the PresentCompleteNotify for the older pixmap > may have the mode PresentCompleteModeSkip") Sounds like a reasonable clarification as t