Re: [PATCH 3/7] Add xcb_send_fd API

From: Keith Packard kei...@keithp.com Date: Tue, 5 Nov 2013 16:41:23 -0800 This uses sendmsg to transmit file descriptors from the application to the X server Same issue as with the libxtrans code; you're not using the CMSG_ API correctly. Also perhaps instead of checking HAVE_SENDMSG

Re: [PATCH 4/7] Add support for receiving fds in replies

From: Keith Packard kei...@keithp.com Date: Tue, 5 Nov 2013 16:41:24 -0800 Requests signal which replies will have fds, and the replies report how many fds they expect in byte 1. Same comment about not using the CMSG_ API properly. Error handling of the recvmsg(2) call isn't adequate

Re: [PATCH 3/7] Add xcb_send_fd API

Mark Kettenis mark.kette...@xs4all.nl writes: From: Keith Packard kei...@keithp.com Date: Tue, 5 Nov 2013 16:41:23 -0800 This uses sendmsg to transmit file descriptors from the application to the X server Same issue as with the libxtrans code; you're not using the CMSG_ API correctly.

Re: [PATCH 4/6] Add MIT-SHM AttachFd and CreateSegment requests

On Tue, 2013-11-05 at 16:39 -0800, Keith Packard wrote: Signed-off-by: Keith Packard kei...@keithp.com --- src/shm.xml | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/shm.xml b/src/shm.xml index adda509..0954d76 100644 --- a/src/shm.xml +++ b/src/shm.xml @@

Re: [PATCH 5/6] Add DRI3

On Tue, 2013-11-05 at 16:39 -0800, Keith Packard wrote: + request name=Open opcode=1 +field type=WINDOW name=window / +field type=CARD32 name=provider / +reply + field type=CARD8 name=nfd/ + fd name=device_fd / + pad bytes=24 / +/reply + /request There's

Re: [PATCH 6/6] Add Present protocol specification

On Tue, 2013-11-05 at 16:39 -0800, Keith Packard wrote: diff --git a/src/xproto.xml b/src/xproto.xml index c9f6979..8a2e276 100644 --- a/src/xproto.xml +++ b/src/xproto.xml @@ -1085,6 +1085,7 @@ The number of keycodes altered. field type=CARD32 name=length/ field type=CARD16

Re: [Patch 0/6] Add MIT-SHM FD passing, DRI3 and Present to xcb proto

On Tue, 2013-11-05 at 16:39 -0800, Keith Packard wrote: Add 64-bit native ints: [PATCH 1/6] Move the INT64 types in sync.xml to the sync: namespace [PATCH 2/6] Add CARD64/INT64 protocol types Add FD passing: [PATCH 3/6] Add support for file descriptor request fields Above:

Re: [PATCH 5/6] Add DRI3

On 2013-11-05 19:39, Keith Packard wrote: diff --git a/src/xproto.xml b/src/xproto.xml index bf4dcbf..c9f6979 100644 --- a/src/xproto.xml +++ b/src/xproto.xml @@ -1080,7 +1080,24 @@ The number of keycodes altered. /doc /event - + event name=ge number=35 +field type=CARD8

Re: [PATCH 4/7] Add support for receiving fds in replies

Same comment about not using the CMSG_ API properly. Same comment about it being a broken API; I would say it's broken enough that it's not possible to use it properly. But my real point here is not to broken-record that, but to add a remark which I neglected to mention when I wrote about

Re: [PATCH 1/6] Move the INT64 types in sync.xml to the sync: namespace

On 2013-11-05 19:39, Keith Packard wrote: This makes sure we use the crazy sync-specific 64-bit datatype instead of the global INT64 type Signed-off-by: Keith Packard kei...@keithp.com --- src/sync.xml | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-)

Re: [PATCH 6/6] Add Present protocol specification

On 2013-11-05 19:39, Keith Packard wrote: Signed-off-by: Keith Packard kei...@keithp.com diff --git a/src/xproto.xml b/src/xproto.xml index c9f6979..8a2e276 100644 --- a/src/xproto.xml +++ b/src/xproto.xml @@ -1085,6 +1085,7 @@ The number of keycodes altered. field type=CARD32

Re: [PATCH 4/7] Add support for receiving fds in replies

Mark Kettenis mark.kette...@xs4all.nl writes: Same comment about not using the CMSG_ API properly. Error handling of the recvmsg(2) call isn't adequate either. Probably should consider MSG_TRUNC and MSG_CTRUNC as fatal errors and clean up any file descriptors that you did receive like we

Re: Linear blending for glyphs

Markus Trippelsdorf mar...@trippelsdorf.de writes: There is an interesting discussion on the FreeType mailing-list about the necessity to use linear blending for glyphs: http://thread.gmane.org/gmane.comp.fonts.freetype.devel/9105 http://thread.gmane.org/gmane.comp.fonts.freetype.devel/9117

Re: [PATCH 1/6] Move the INT64 types in sync.xml to the sync: namespace

Peter Harris phar...@opentext.com writes: diff --git a/src/sync.xml b/src/sync.xml index 516d149..ae3bbbc 100644 --- a/src/sync.xml +++ b/src/sync.xml @@ -41,14 +41,14 @@ for licensing information. item name=Events bit5/bit/item /enum - struct name=INT64 + struct

Re: [PATCH 4/6] Add MIT-SHM AttachFd and CreateSegment requests

Adam Jackson a...@nwnk.net writes: This doesn't bump the extension minor number. Thanks. Also doesn't seem to have the QueryCaps thing, but I guess that doesn't exist at all yet. I know it's the 'safe' thing to do, but it places an additional burden on any application using the extension,

Re: [PATCH 1/6] Move the INT64 types in sync.xml to the sync: namespace

On 2013-11-06 13:11, Keith Packard wrote: Peter Harris phar...@opentext.com writes: diff --git a/src/sync.xml b/src/sync.xml index 516d149..ae3bbbc 100644 --- a/src/sync.xml +++ b/src/sync.xml @@ -41,14 +41,14 @@ for licensing information. item name=Events bit5/bit/item /enum - struct

Re: [PATCH 5/6] Add DRI3

Adam Jackson a...@nwnk.net writes: There's not much semantic difference, but the protocol text says Drawable not Window. Thanks, easily fixed. The protocol spec is ambiguous here? Section A.2 still seems to reference CARD32 driver_type and driver name and whatnot. Sorry, I didn't review

Re: [PATCH 5/6] Add DRI3

Peter Harris phar...@opentext.com writes: I'm curious about this hunk. It isn't hurting anything, but I don't see where it would be needed or used. xcb.h already has xcb_ge_event_t. Is this hunk solely for the doc section? Or for the #define XCB_GE 35 ? My libxcb commits remove the

Re: [PATCH 6/6] Add Present protocol specification

Adam Jackson a...@nwnk.net writes: This probably wants to be in the same separate commit as mentioned in 5/6? Fixed. Thanks. -- keith.pack...@intel.com pgp5gVnPeGtaG.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 6/6] Add Present protocol specification

Peter Harris phar...@opentext.com writes: NAK. This field is not on the wire, it is an implementation detail of libxcb. This appears to be a workaround from before http://cgit.freedesktop.org/xcb/libxcb/commit/?id=45619dc71e9411a526d7c69595cf615b1b1206cf , and should not be necessary with

Re: [Patch 0/6] Add MIT-SHM FD passing, DRI3 and Present to xcb proto

Adam Jackson a...@nwnk.net writes: On Tue, 2013-11-05 at 16:39 -0800, Keith Packard wrote: Add 64-bit native ints: [PATCH 1/6] Move the INT64 types in sync.xml to the sync: namespace [PATCH 2/6] Add CARD64/INT64 protocol types Add FD passing: [PATCH 3/6] Add support for file

Re: [PATCH 1/6] Move the INT64 types in sync.xml to the sync: namespace

Peter Harris phar...@opentext.com writes: This line declares a struct. All declarations are in the enclosing namespace by definition. Ok, fixed and pushed to my dri3 branch. -- keith.pack...@intel.com pgph2gdBhzRqY.pgp Description: PGP signature

Re: [PATCH 6/6] Add Present protocol specification

On 2013-11-06 13:54, Keith Packard wrote: Peter Harris phar...@opentext.com writes: NAK. This field is not on the wire, it is an implementation detail of libxcb. This appears to be a workaround from before

Re: [PATCH 5/7] Add event queue splitting

On 2013-11-05 19:41, Keith Packard wrote: This allows apps to peel off certain XGE events into separate queues for custom handling. Designed to support the Present extension Signed-off-by: Keith Packard kei...@keithp.com Re: xcb_register_for_special_event, xcb_unregister_for_special_event,

Re: [PATCH] ARM64: Add support for aarch64

On Thu, 2013-08-15 at 13:29 +0200, Mark Kettenis wrote: From: Egbert Eich e...@freedesktop.org Date: Thu, 15 Aug 2013 12:03:42 +0200 From: Andreas Schwab sch...@suse.de Signed-off-by: Andreas Schwab sch...@suse.de The non-Linux-specific bits look reasonable to me, so:

Re: [ANNOUNCE] libxshmfence 1.0

On 11/ 2/13 12:39 AM, Keith Packard wrote: Alan Coopersmith alan.coopersm...@oracle.com writes: What about platforms which don't have linux/futex.h ? I looked into alternate synchronization mechanisms; I couldn't figure out how to use standard pthread APIs to provide the desired semantics.

Re: [Xcb] [PATCH 5/7] Add event queue splitting

Hi, On 06.11.2013 20:34, Peter Harris wrote: On 2013-11-05 19:41, Keith Packard wrote: [...] diff --git a/src/xcb.h b/src/xcb.h index f7dc6af..f99e677 100644 --- a/src/xcb.h +++ b/src/xcb.h @@ -138,23 +138,6 @@ typedef struct { } xcb_generic_event_t; /** - * @brief GE event - * -

Re: [ANNOUNCE] libxshmfence 1.0

Date: Wed, 06 Nov 2013 13:09:26 -0800 From: Alan Coopersmith alan.coopersm...@oracle.com On 11/ 2/13 12:39 AM, Keith Packard wrote: Alan Coopersmith alan.coopersm...@oracle.com writes: What about platforms which don't have linux/futex.h ? I looked into alternate synchronization

Please pick fd1b24a93e to 1.14

Hi Matt, Please cherry-pick fd1b24a93e (glx: Add support for the new DRI loader entrypoint.) to the server-1.14-branch. It picks cleanly and is needed to load the classic DRI drivers in Mesa 10 which is going to be branched tomorrow and released at the end of November, a month before

Re: [ANNOUNCE] libxshmfence 1.0

Mark Kettenis mark.kette...@xs4all.nl writes: As I said, currently OpenBSD doesn't implement the process-shared stuff, but I'm already looking into implementing the necessary functionality. So I'd say that the POSIX API's are indeed the way to go. Sounds good. Who will get this working for

[PATCH] Add correct dependency on libxtrans.

The 1.3 release is when the new FD passing bits landed. Signed-off-by: Eric Anholt e...@anholt.net --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6925df8..32b7f64 100644 --- a/configure.ac +++ b/configure.ac @@ -806,7 +806,7

Re: [PATCH 5/7] Add event queue splitting

Peter Harris phar...@opentext.com writes: There was some push-back the last time something similar to this came up, on the theory that it should be in a separate library from xcb[1]. That said, we may have reached the point where it's just too useful to not have in libxcb. We cannot

Re: [Xcb] [PATCH 5/7] Add event queue splitting

Uli Schlachter psyc...@znc.in writes: With google I found the patches in question and looked at them quickly. My first impression is that the xcb_*_special_event() functions might need way better documentation. That's always true :-) Also, this adds public API that allows to hide XGE

Re: [PATCH] ARM64: Add support for aarch64

Egbert Eich e...@freedesktop.org writes: From: Andreas Schwab sch...@suse.de Signed-off-by: Andreas Schwab sch...@suse.de Merged. 8fcf82c..ab4b1fb master - master -- keith.pack...@intel.com pgp6eRh4ip1YW.pgp Description: PGP signature ___

Re: [Xcb] [PATCH 5/7] Add event queue splitting

Uli Schlachter psyc...@znc.in writes: Hi, On 06.11.2013 20:34, Peter Harris wrote: On 2013-11-05 19:41, Keith Packard wrote: [...] diff --git a/src/xcb.h b/src/xcb.h index f7dc6af..f99e677 100644 --- a/src/xcb.h +++ b/src/xcb.h @@ -138,23 +138,6 @@ typedef struct { }

Re: [Xcb] [PATCH 5/7] Add event queue splitting

On Wed, Nov 06, 2013 at 02:34:03PM -0500, Peter Harris wrote: On 2013-11-05 19:41, Keith Packard wrote: This allows apps to peel off certain XGE events into separate queues for custom handling. Designed to support the Present extension Signed-off-by: Keith Packard kei...@keithp.com

Re: [Xcb] [PATCH 5/7] Add event queue splitting

Peter Harris phar...@opentext.com writes: On 2013-11-05 19:41, Keith Packard wrote: This allows apps to peel off certain XGE events into separate queues for custom handling. Designed to support the Present extension Signed-off-by: Keith Packard kei...@keithp.com Re:

Re: [Xcb] [PATCH 5/7] Add event queue splitting

On 2013-11-06 19:55, Eric Anholt wrote: We tried to do this with event queue filtering the same way we do with xlib, and it got NAKed. Then we came up with new events and a new mechanism so that we could do this, and it's getting NAKed again. Dude. It's not getting NAKed, it's getting Woah,

Re: [Xcb] [PATCH 5/7] Add event queue splitting

On 2013-11-06 19:55, Josh Triplett wrote: On Wed, Nov 06, 2013 at 02:34:03PM -0500, Peter Harris wrote: On 2013-11-05 19:41, Keith Packard wrote: This allows apps to peel off certain XGE events into separate queues for custom handling. Designed to support the Present extension Signed-off-by:

Re: [Xcb] [PATCH 5/7] Add event queue splitting

Josh Triplett j...@joshtriplett.org writes: The last time that Jamey and I spoke about this, we agreed that this type of mechanism would be required to make GL work, and that there's really no other way to support it. However, I'd like to see it not XGE-specific, so that it could support the

Re: Please pick fd1b24a93e to 1.14

Hi Matt, picked. After the sha correction, it found it just fine. 833639d..339af2a server-1.14-branch - server-1.14-branch Matt On 11/06/2013 04:51 PM, Matt Turner wrote: Hi Matt, Please cherry-pick fd1b24a93e (glx: Add support for the new DRI loader entrypoint.) to the

Re: [Xcb] [PATCH 5/7] Add event queue splitting

Peter Harris phar...@opentext.com writes: Dude. It's not getting NAKed, it's getting Woah, this is out of left field, this is the first I've ever heard of it, can we please have a couple of days to think about it before we ACK it?ed. Yeah, I've been running this code for months now and have

[PATCH 2/8] -pendantic is too pendantic

Many system headers have warnings when compiled with this flag. Signed-off-by: Keith Packard kei...@keithp.com --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6c107bc..4a30584 100644 --- a/configure.ac +++ b/configure.ac @@

[PATCH 3/8] Remove xcb_ge_event_t from xcb.h

xcb proto now publishes this structure from an XML description Signed-off-by: Keith Packard kei...@keithp.com --- src/xcb.h | 17 - 1 file changed, 17 deletions(-) diff --git a/src/xcb.h b/src/xcb.h index 0714130..c251330 100644 --- a/src/xcb.h +++ b/src/xcb.h @@ -138,23 +138,6

[PATCH 1/8] Make protocol C files depend on protocol XML files

When new XML files get installed, make sure the C files are regenerated Signed-off-by: Keith Packard kei...@keithp.com --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 6b5a2c3..f48e14e 100644 --- a/src/Makefile.am +++

[PATCH 0/8] Updated version of DRI3/Present additions to libxcb

I've generated a new sequence of patches in response to the very helpful review comments received so far. Thanks to all involved! Some simple cleanups that I have found useful. Patch 3/8 has been split out from the event queue patch and matches a change made to the XCB proto that adds an XML

[PATCH 6/8] Add event queue splitting

This allows apps to peel off certain XGE events into separate queues for custom handling. Designed to support the Present extension Signed-off-by: Keith Packard kei...@keithp.com --- src/xcb.h| 28 ++ src/xcb_in.c | 167 +--

[PATCH 8/8] Add Present extension

Signed-off-by: Keith Packard kei...@keithp.com --- Makefile.am | 3 +++ configure.ac | 2 ++ src/.gitignore| 1 + src/Makefile.am | 8 xcb-present.pc.in | 11 +++ 5 files changed, 25 insertions(+) create mode 100644 xcb-present.pc.in diff --git

[PATCH 7/8] Add DRI3 library

Signed-off-by: Keith Packard kei...@keithp.com --- Makefile.am | 3 +++ configure.ac| 3 +++ src/.gitignore | 1 + src/Makefile.am | 8 xcb-dri3.pc.in | 11 +++ 5 files changed, 26 insertions(+) create mode 100644 xcb-dri3.pc.in diff --git a/Makefile.am

[PATCH 5/8] Add support for receiving fds in replies

Requests signal which replies will have fds, and the replies report how many fds they expect in byte 1. Signed-off-by: Keith Packard kei...@keithp.com --- src/c_client.py | 65 ++--- src/xcb_in.c| 99 +++--

[PATCH 4/8] Add xcb_send_fd API

This uses sendmsg to transmit file descriptors from the application to the X server Signed-off-by: Keith Packard kei...@keithp.com --- configure.ac| 14 ++ src/c_client.py | 4 src/xcb_auth.c | 11 ++- src/xcb_conn.c | 39 +--