Re: [PATCH:shmfd 2/2] Use /var/tmp instead of /run/shm on non-linux OS'es

2013-11-08 Thread Alan Coopersmith
On 11/ 7/13 11:53 PM, Mark Kettenis wrote: From: Alan Coopersmith Date: Thu, 7 Nov 2013 20:55:44 -0800 Signed-off-by: Alan Coopersmith --- Makefile |9 + shmfd.c |4 2 files changed, 9 insertions(+), 4 deletions(-) Ah, is this the example code I have been looking f

[PATCH:printproto] Move xau from Requires to Requires.private in printproto.pc

2013-11-08 Thread Alan Coopersmith
The xau headers are required because Print.h has #include for the definition of the Xauth typedef, but software including this header doesn't necessarily need to link with libXau. Signed-off-by: Alan Coopersmith --- printproto.pc.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 1/1] xfree86: Fix build without libpciaccess

2013-11-08 Thread Jeremy Huddleston Sequoia
On Nov 8, 2013, at 17:22, Connor Behan wrote: > On 08/11/13 02:55 PM, Jeremy Huddleston Sequoia wrote: >> Regression fix from commit 04ab07ca19236d6c9a947e065fb69b0dd0d16639 >> >> Signed-off-by: Jeremy Huddleston Sequoia >> CC: Connor Behan >> CC: Keith Packard >> CC: Matt Dew >> --- > Than

Re: [PATCH 1/1] xfree86: Fix build without libpciaccess

2013-11-08 Thread Connor Behan
On 08/11/13 02:55 PM, Jeremy Huddleston Sequoia wrote: > Regression fix from commit 04ab07ca19236d6c9a947e065fb69b0dd0d16639 > > Signed-off-by: Jeremy Huddleston Sequoia > CC: Connor Behan > CC: Keith Packard > CC: Matt Dew > --- Thanks for catching this. I think the other uses of MATCH_PCI_DEV

[PATCH:libxkbcommon] Make XkbFileCreate argument types match between header & implementation

2013-11-08 Thread Alan Coopersmith
Fixes build failure with Solaris Studio compilers: "src/xkbcomp/ast-build.c", line 492: identifier redeclared: XkbFileCreate current : function(..., enum xkb_map_flags) previous: function(..., unsigned int) : "src/xkbcomp/ast-build.h", line 98 Signed-off-by: Alan Coopersmith --- src/xkbcomp/

Re: [PULL] GLX rewrite

2013-11-08 Thread Jeremy Huddleston Sequoia
Sorry, I haven't been paying much attention to X11 for the past year or so, so I missed all of this work until it started failing on my build bot. glxstubs.c has conflicting availability attributes. How should we resolve this? If I was doing this for just OSX, I'd remove _X_HIDDEN and just tel

[PATCH 1/1] configure.ac: Bump xtrans requirement to 1.3.2 for TransRecvFd et al.

2013-11-08 Thread Jeremy Huddleston Sequoia
Signed-off-by: Jeremy Huddleston Sequoia --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 8a9832c..47df86b 100644 --- a/configure.ac +++ b/configure.ac @@ -806,7 +806,7 @@ FIXESPROTO="fixesproto >= 5.0" DAMAGEPROTO="damageprot

[PATCH 1/1] xfree86: Fix build without libpciaccess

2013-11-08 Thread Jeremy Huddleston Sequoia
Regression fix from commit 04ab07ca19236d6c9a947e065fb69b0dd0d16639 Signed-off-by: Jeremy Huddleston Sequoia CC: Connor Behan CC: Keith Packard CC: Matt Dew --- hw/xfree86/common/xf86Bus.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/common/xf86Bus.c b/hw

Re: [PATCH RESEND] xfree86: Find primary entity when bus types are nominally different

2013-11-08 Thread Jeremy Huddleston Sequoia
This breaks Xorg builds on systems without libpci. This is also on server-1.14-branch post 1.14.4, so we need to get this fixed up on the stable branch too. xf86Bus.c:270:9: error: incomplete definition of type 'struct pci_device' [Semantic Issue] return MATCH_PCI_DEVICES(pEnt->bus.id.p

Re: [PATCH 1/1] configure.ac: Move GLX section after DRI

2013-11-08 Thread Ian Romanick
On 11/08/2013 02:12 AM, Jeremy Huddleston Sequoia wrote: > The GLX section of configura.ac checks the state of DRI2, so it > needs to be after DRI2=auto is resolved. > > Also reset libgl requirement to 7.1.0 in non-dri2 case. Apologies if I'm being daft... Is this patch right? I don't see any ch

Re: [PATCH 5/7] Trap SIGBUS to handle truncated shared memory segments

2013-11-08 Thread Mark Kettenis
> From: Adam Jackson > Date: Fri, 08 Nov 2013 12:54:21 -0500 > > On Thu, 2013-11-07 at 12:15 -0800, Keith Packard wrote: > > If a client passes a section of memory via file descriptor and then > > subsequently truncates that file, the underlying pages will be freed > > and the addresses invalidat

Re: [PATCH:shmfd 2/2] Use /var/tmp instead of /run/shm on non-linux OS'es

2013-11-08 Thread Alan Coopersmith
On 11/ 8/13 06:42 AM, Jasper St. Pierre wrote: We want to make sure we don't write files to disk. /tmp on some systems is backed by a disk, not tmpfs. That was unclear from the sample code - all I saw was a directory that doesn't exist on my platform, with no hints how to pick the right one.

Re: [PATCH 1/1] configure.ac: Move GLX section after DRI

2013-11-08 Thread Jeremy Huddleston Sequoia
On Nov 8, 2013, at 9:58, Adam Jackson wrote: > On Fri, 2013-11-08 at 02:12 -0800, Jeremy Huddleston Sequoia wrote: >> The GLX section of configura.ac checks the state of DRI2, so it >> needs to be after DRI2=auto is resolved. >> >> Also reset libgl requirement to 7.1.0 in non-dri2 case. >> >>

[PULL] configure.ac fixes for no/auto-DRI2 GLX

2013-11-08 Thread Jeremy Huddleston Sequoia
The following changes since commit ab4b1fb38a61feb73d8336cc7a3399eb9d3d25be: ARM64: Add support for aarch64 (2013-11-06 16:41:49 -0800) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master for you to fetch changes up to 7cac488fc926068a53ff4673a6654f

[PATCH] configure: Move DRI2 value test after DRI2 auto resolves to yes/no

2013-11-08 Thread Adam Jackson
Otherwise you don't build the AIGLX loader, which breaks glamor drivers. Signed-off-by: Adam Jackson --- configure.ac | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 6925df8..3cd011f 100644 --- a/configure.ac +++ b/configure.ac @@

[PATCH 1/2] dri2: Disable when Xinerama is active

2013-11-08 Thread Adam Jackson
Would only work on ScreenRec 0, which means it's broken. Signed-off-by: Adam Jackson --- hw/xfree86/dri2/dri2ext.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/xfree86/dri2/dri2ext.c b/hw/xfree86/dri2/dri2ext.c index e1decec..ffd66fa 100644 --- a/hw/xfree86/dri2/dri2ext.c +++ b/hw

Re: [PATCH] present: Don't try to initialize when building without present support

2013-11-08 Thread Adam Jackson
On Thu, 2013-11-07 at 23:26 +0100, Mark Kettenis wrote: > > From: Adam Jackson > > Date: Thu, 7 Nov 2013 12:01:41 -0500 > > > > There's a --disable-present, so it'd be nice if it worked. > > > > Signed-off-by: Adam Jackson > > --- > > mi/miinitext.c | 2 ++ > > 1 file changed, 2 insertions(+)

[PATCH 2/2] dri3: Disable when Xinerama is active

2013-11-08 Thread Adam Jackson
Pretty sure this can't work. Signed-off-by: Adam Jackson --- dri3/dri3.c | 5 + 1 file changed, 5 insertions(+) diff --git a/dri3/dri3.c b/dri3/dri3.c index 2bca7ae..76e07b4 100644 --- a/dri3/dri3.c +++ b/dri3/dri3.c @@ -68,6 +68,11 @@ dri3_extension_init(void) ExtensionEntry *extensio

Re: [Xcb] [PATCH 2/8] -pendantic is too pendantic

2013-11-08 Thread Josh Triplett
On Wed, Nov 06, 2013 at 07:45:39PM -0800, Keith Packard wrote: > Many system headers have warnings when compiled with this flag. > > Signed-off-by: Keith Packard In theory, GCC should never be warning about things from system headers unless asked to... > configure.ac | 2 +- > 1 file changed,

Re: [PATCH 5/7] Trap SIGBUS to handle truncated shared memory segments

2013-11-08 Thread Mark Kettenis
> From: Keith Packard > Date: Thu, 7 Nov 2013 12:15:58 -0800 > > If a client passes a section of memory via file descriptor and then > subsequently truncates that file, the underlying pages will be freed > and the addresses invalidated. Subsequent accesses to the page will > fail with a SIGBUS e

Re: [PATCH 5/7] Trap SIGBUS to handle truncated shared memory segments

2013-11-08 Thread Adam Jackson
On Thu, 2013-11-07 at 12:15 -0800, Keith Packard wrote: > If a client passes a section of memory via file descriptor and then > subsequently truncates that file, the underlying pages will be freed > and the addresses invalidated. Subsequent accesses to the page will > fail with a SIGBUS error. > >

Re: [PATCH 0/2] Solaris support for XTRANS_SEND_FDS

2013-11-08 Thread Adam Jackson
On Thu, 2013-11-07 at 21:13 -0800, Alan Coopersmith wrote: > After applying these two patches on top of Keith's current tree, plus the > changes just pushed to libxtrans & libxcb, I was able to get the expected > colorful squares display on Solaris using the shmfd test program from > ssh://people.f

Re: [PATCH 1/1] configure.ac: Move GLX section after DRI

2013-11-08 Thread Adam Jackson
On Fri, 2013-11-08 at 02:12 -0800, Jeremy Huddleston Sequoia wrote: > The GLX section of configura.ac checks the state of DRI2, so it > needs to be after DRI2=auto is resolved. > > Also reset libgl requirement to 7.1.0 in non-dri2 case. > > Signed-off-by: Jeremy Huddleston Sequoia > CC: Ian Roma

Re: [PATCH:shmfd 2/2] Use /var/tmp instead of /run/shm on non-linux OS'es

2013-11-08 Thread Mark Kettenis
> Date: Fri, 8 Nov 2013 09:42:57 -0500 > From: "Jasper St. Pierre" > > We want to make sure we don't write files to disk. /tmp on some systems is > backed by a disk, not tmpfs. And /run doesn't exist on many Linux systems. In the end this is just some test code, so I guess it doesn't matter all

Re: [PATCH 1/1] configure.ac: Move GLX section after DRI

2013-11-08 Thread Adam Jackson
On Fri, 2013-11-08 at 10:24 -0800, Jeremy Huddleston Sequoia wrote: > On Nov 8, 2013, at 9:58, Adam Jackson wrote: > > > On Fri, 2013-11-08 at 02:12 -0800, Jeremy Huddleston Sequoia wrote: > >> The GLX section of configura.ac checks the state of DRI2, so it > >> needs to be after DRI2=auto is res

Re: [PATCH 4/7] Require libXtrans version 1.3.1

2013-11-08 Thread Adam Jackson
On Thu, 2013-11-07 at 12:15 -0800, Keith Packard wrote: > This has the FD passing support included Reviewed-by: Adam Jackson - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCH 7/7] present: Change debug output a bit to help diagnose missing vblank signals

2013-11-08 Thread Adam Jackson
On Thu, 2013-11-07 at 12:16 -0800, Keith Packard wrote: > Signed-off-by: Keith Packard Not really a build fix like 0/7 says, but reasonable. Reviewed-by: Adam Jackson - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/

Re: [PATCH 6/7] Present: Check for window/fence destroyed when idling pixmaps

2013-11-08 Thread Adam Jackson
On Thu, 2013-11-07 at 12:15 -0800, Keith Packard wrote: > A client destroying objects in the middle of an unflip can end up > having the screen flip window or fence set to NULL in the unflip > notify path. Check for these and don't try to use those objects. > > Signed-off-by: Keith Packard Revie

Re: [Xcb] [PATCH 5/7] Add event queue splitting

2013-11-08 Thread Josh Triplett
On Wed, Nov 06, 2013 at 06:39:19PM -0800, Keith Packard wrote: > Josh Triplett writes: > > > The last time that Jamey and I spoke about this, we agreed that this > > type of mechanism would be required to make GL work, and that there's > > really no other way to support it. However, I'd like to

Re: [Xcb] [PATCH 5/7] Add event queue splitting

2013-11-08 Thread Josh Triplett
On Wed, Nov 06, 2013 at 09:25:40PM -0500, Peter Harris wrote: > On 2013-11-06 19:55, Josh Triplett wrote: > > On Wed, Nov 06, 2013 at 02:34:03PM -0500, Peter Harris wrote: > >> On 2013-11-05 19:41, Keith Packard wrote: > >>> This allows apps to peel off certain XGE events into separate queues > >>>

Re: [Xcb] [PATCH 5/7] Add event queue splitting

2013-11-08 Thread Josh Triplett
On Wed, Nov 06, 2013 at 07:09:01PM -0800, Keith Packard wrote: > Peter Harris writes: > > > Dude. It's not getting NAKed, it's getting "Woah, this is out of left > > field, this is the first I've ever heard of it, can we please have a > > couple of days to think about it before we ACK it?"ed. >

[PATCH] present: Disable when Xinerama is active

2013-11-08 Thread Adam Jackson
Among much else Present depends on RANDR types, and RANDR isn't properly Xinerama-aware yet anyway. Signed-off-by: Adam Jackson --- present/present_screen.c | 5 + 1 file changed, 5 insertions(+) diff --git a/present/present_screen.c b/present/present_screen.c index 50b2b2d..b5fbccb 100644

Re: [PATCH 2/7] Require xextproto version 7.2.99.901

2013-11-08 Thread Alan Coopersmith
On 11/ 7/13 12:15 PM, Keith Packard wrote: This includes the MIT-SHM FD passing requests Signed-off-by: Keith Packard --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 12610e4..fb95663 100644 --- a/configure.ac +++ b/config

Re: [PATCH:shmfd 2/2] Use /var/tmp instead of /run/shm on non-linux OS'es

2013-11-08 Thread Jasper St. Pierre
We want to make sure we don't write files to disk. /tmp on some systems is backed by a disk, not tmpfs. On Fri, Nov 8, 2013 at 2:53 AM, Mark Kettenis wrote: > > From: Alan Coopersmith > > Date: Thu, 7 Nov 2013 20:55:44 -0800 > > > > Signed-off-by: Alan Coopersmith > > --- > > Makefile |9

[PATCH 2/2] Enable XTRANS_SEND_FDS on Solaris too.

2013-11-08 Thread Alan Coopersmith
Requires passing through the __EXTENSIONS__ and _XOPEN_SOURCE defines in order to expose the msg_control members in struct msghdr. Signed-off-by: Alan Coopersmith --- configure.ac|3 ++- include/dix-config.h.in |8 2 files changed, 10 insertions(+), 1 deletion(-) di

[PATCH 1/1] configure.ac: Move GLX section after DRI

2013-11-08 Thread Jeremy Huddleston Sequoia
The GLX section of configura.ac checks the state of DRI2, so it needs to be after DRI2=auto is resolved. Also reset libgl requirement to 7.1.0 in non-dri2 case. Signed-off-by: Jeremy Huddleston Sequoia CC: Ian Romanick --- configure.ac | 57 +

Re: [PATCH:shmfd 2/2] Use /var/tmp instead of /run/shm on non-linux OS'es

2013-11-08 Thread Thomas Klausner
On Fri, Nov 08, 2013 at 09:42:57AM -0500, Jasper St. Pierre wrote: > We want to make sure we don't write files to disk. /tmp on some systems is > backed by a disk, not tmpfs. If you want real temporary files that don't survive a reboot, /tmp is a better bet than /var/tmp. See e.g. http://refspecs

Re: [PATCH:shmfd 2/2] Use /var/tmp instead of /run/shm on non-linux OS'es

2013-11-08 Thread Mark Kettenis
> From: Alan Coopersmith > Date: Thu, 7 Nov 2013 20:55:44 -0800 > > Signed-off-by: Alan Coopersmith > --- > Makefile |9 + > shmfd.c |4 > 2 files changed, 9 insertions(+), 4 deletions(-) Ah, is this the example code I have been looking for the last couple of days? Anyw

[PATCH 0/2] Solaris support for XTRANS_SEND_FDS

2013-11-08 Thread Alan Coopersmith
After applying these two patches on top of Keith's current tree, plus the changes just pushed to libxtrans & libxcb, I was able to get the expected colorful squares display on Solaris using the shmfd test program from ssh://people.freedesktop.org/~keithp/shmfd . Alan Coopersmith (2): Avoid confl

Re: [PATCH 3/7] Xext: Enable MIT-SHM FD-passing request definitions only when possible

2013-11-08 Thread Alan Coopersmith
On 11/ 7/13 12:15 PM, Keith Packard wrote: Check to see if xtrans FD passing is available and use that to advertise the appropriate version of the SHM extension Signed-off-by: Keith Packard --- Xext/shm.c | 14 +- Xext/shmint.h | 17

[PATCH 1/2] Avoid conflicts with Solaris defines that clash with our names

2013-11-08 Thread Alan Coopersmith
When building on Solaris with _XOPEN_SOURCE set to a recent XPG release, and other core headers start including , which has a bunch of unfortunately named macros such as "CS", "ES", etc. for x86 & x64 registers which clash with existing variable & struct member names in Xorg - so #undef these so t