Hi,
On 02/04/2014 02:34 AM, Peter Hutterer wrote:
Introduced in fecc7eb1cf66db64728ee2d68cd9443df7e70879 and reverts most of
that but it's helpfully mixed with other stuff.
InputAttributes are not const, they're strdup'd everywhere but the test code
and freed properly. Revert the const char
There is no reason why keeptty cannot be used without root-rights.
Signed-off-by: Hans de Goede hdego...@redhat.com
Reviewed-by: Peter Hutterer peter.hutte...@who-t.net
---
hw/xfree86/os-support/linux/lnx_init.c | 6 --
1 file changed, 6 deletions(-)
diff --git
With systemd-logind support, the xserver, rather then the drivers will be
responsible for opening/closing the fd for input devices.
This commit adds a new capabilities field to the InputDriverRec and a
XI86_DRV_CAP_SERVER_FD flag for drivers to indicate that they support server
managed fds.
This
Add a config_odev_get_attribute helper, and replace the diy looing over all
the attributes done in various places with calls to this helper.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
config/config.c| 23 +++
Hi All,
Here is v2 of my systemd-logind / run the xserver without root rights series,
this version drops some already merged patches, and addresses all the review
comments on the first RFC posting of these series.
One open question is if we want to add a capabilities field to video
drivers like
The commit adding the systemd-daemon configure check has a small error in it
where one if statement is missing the test call, this fixes this.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac
If an attribute already exists replace its value rather then adding a
duplicate attribute with the new value to the list.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
config/config.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/config/config.c b/config/config.c
Add a couple of new functions for dealing with storing integer values into
OdevAttributes.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
config/config.c | 40 +
hw/xfree86/common/xf86platformBus.c | 18 +
Detaching from our controllling tty makes little sense when it is the same
as the vt we're asked to run on. So automatically assume -keeptty in this case.
This is useful to do because when not running as root the server can only make
various VT related ioctls when it does not detach from the tty.
This commits makes the changes necessary outside of the systemd-logind core
to make the server use systemd-logind managed fds for input devices and drm
nodes.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
config/config.c| 13 ++
config/udev.c
With systemd-logind we cannot probe input devices while switched away, so
if we're switched away, put the pInfo on a list, and probe everything on
that list on VT-Enter.
This is using an array grown by re-alloc, rather then an xorg_list since
creating a new data-type to store a pInfo + list-entry
Try to get a server managed fd from the Options before trying to open the
device node ourselves.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
hw/xfree86/os-support/shared/posix_tty.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
Before this commit we were trying to add most drm devices twice, once
from xf86platformProbe() and once from config_udev_init().
This results in somewhat confusing messages in Xorg.log, ie:
(II) xfree86: Adding drm device (/dev/dri/card0)
Later followed by:
(II) config/udev: Adding drm device
The OdevAttributes struct should just be a head of the attributes list, and
not contain various unrelated flags. Instead add a flags field to
struct xf86_platform_device and use that.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
hw/xfree86/common/xf86Module.h | 2 +-
From: Hans de Goede hdego...@redhat.com
Date: Tue, 4 Feb 2014 12:49:10 +0100
With systemd-logind support, the xserver, rather then the drivers will be
responsible for opening/closing the fd for input devices.
This commit adds a new capabilities field to the InputDriverRec and a
Hi,
On 02/04/2014 01:03 PM, Mark Kettenis wrote:
From: Hans de Goede hdego...@redhat.com
Date: Tue, 4 Feb 2014 12:49:10 +0100
With systemd-logind support, the xserver, rather then the drivers will be
responsible for opening/closing the fd for input devices.
This commit adds a new
Hi
On Tue, Feb 4, 2014 at 1:16 PM, Hans de Goede hdego...@redhat.com wrote:
Hi,
On 02/04/2014 01:03 PM, Mark Kettenis wrote:
From: Hans de Goede hdego...@redhat.com
Date: Tue, 4 Feb 2014 12:49:10 +0100
With systemd-logind support, the xserver, rather then the drivers will be
responsible
Date: Tue, 04 Feb 2014 13:16:21 +0100
From: Hans de Goede hdego...@redhat.com
The systemd-logind API uses separate major and minor numbers rather
then a dev_t.
I don't think the design of the Xorg driver API should be blindly
copied from Linux-specific APIs.
The integration of systemd
Hi,
On 02/04/2014 02:12 PM, Mark Kettenis wrote:
Date: Tue, 04 Feb 2014 13:16:21 +0100
From: Hans de Goede hdego...@redhat.com
The systemd-logind API uses separate major and minor numbers rather
then a dev_t.
I don't think the design of the Xorg driver API should be blindly
copied from
On 14-02-02 04:31 PM, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
man/Makefile.am | 2 ++
man/xkbcomp.man | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Gaetan Nadon mems...@videotron.ca
On Tue, Feb 04, 2014 at 11:43:09AM +0900, Michel Dänzer wrote:
Can this be limited to affected platforms?
Sure, but I don't know the proper #ifdefs.
Martin
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
From: Martin Husemann mar...@netbsd.org
Date: Mon, 3 Feb 2014 20:36:13 +0100
When using xvideo on alignement critical architectures (for example a sparc64
with the XVR100 graphics adapter) some screen positions (easily reproducable
with xfce and gmplayer by moving the video window partly
The following changes since commit 83e38eb73fd8c852513aac2da2975b4c01070ec2:
edid: Add quirk for Sony Vaio Pro 13 (2014-01-30 16:27:59 -0800)
are available in the git repository at:
git://people.freedesktop.org/~whot/xserver for-keith
for you to fetch changes up to
On 02/ 4/14 01:33 PM, Peter Hutterer wrote:
include: make the various button array lengths more obious
obvious?
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
On Tue, Feb 04, 2014 at 01:31:16PM -0800, Alan Coopersmith wrote:
On 02/ 4/14 01:33 PM, Peter Hutterer wrote:
include: make the various button array lengths more obious
obvious?
oops, thanks. amended. Keith, new top commit is
25d10464f440b8b34594b7c988a99a830ea39a29, no other changes
It looks like GL_GLEXT_PROTOTYPES is just a trap for the unwary,
causing glext.h to define a pile of functions which are also defined
in gl.h.
However, there is *one* function used in the server which is not
defined in gl.h and is only defined in glext.h when
GL_GLEXT_PROTOTYPES is defined,
dispatch.c: In function 'SetVendorString':
dispatch.c:481:29: warning: declaration of 'string' shadows a global
declaration [-Wshadow]
SetVendorString(const char *string)
^
dispatch.c:135:21: warning: shadowed declaration is here [-Wshadow]
typedef const char
Allocated in one place, freed in another.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
hw/xfree86/common/xf86Xinput.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/xfree86/common/xf86Xinput.h b/hw/xfree86/common/xf86Xinput.h
index f94261a..b6d1251
No const value is ever assigned to it, let's not pretend it's const.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
hw/xfree86/parser/xf86Parser.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xfree86/parser/xf86Parser.h b/hw/xfree86/parser/xf86Parser.h
index
mieq.c:290:26: warning: format '%u' expects argument of type 'unsigned int',
but argument 2 has type 'size_t' [-Wformat=]
pnprintf supports size_t since 5ea21560dd071ea4ab8743d087fd5fe1f092
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
mi/mieq.c | 2 +-
1 file changed, 1
The only place this isn't allocated is during Xorg -configure where we just
statically assing mouse/kbd and the identifiers for it. Everywhere else
it's strdup'd and then free'd already.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
hw/xfree86/common/xf86Configure.c | 8
Only Xorg -configure uses a hardcoded value here, so let's not change the rest
of the server for that.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
hw/xfree86/common/xf86Configure.c | 4 ++--
hw/xfree86/parser/xf86Parser.h| 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
Keith Packard kei...@keithp.com writes:
It looks like GL_GLEXT_PROTOTYPES is just a trap for the unwary,
causing glext.h to define a pile of functions which are also defined
in gl.h.
However, there is *one* function used in the server which is not
defined in gl.h and is only defined in
Hi,
On 02/05/2014 06:18 AM, Peter Hutterer wrote:
Allocated in one place, freed in another.
You use unchecked strdup in patch 2 and 3, please use XNFstrdup.
Other then that the series looks good, so with the above amended this is:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
Eric Anholt e...@anholt.net writes:
You can't actually use the prototype in indirect_texture_compression.c.
See my patch series I sent earlier. And this would conflict with my
glamor series I'd already sent out for review, too. So I don't want
this patch to go in as is.
No problem -- I'll
35 matches
Mail list logo
