Re: [PULL] button mapping fix and unconstify patches

2014-02-10 Thread Gaetan Nadon
On 14-02-09 07:03 PM, Keith Packard wrote: Gaetan Nadon mems...@videotron.ca writes: I have a total of 242 warnings. 202-Wshadow 35 -Wunused-result 2 -Wpointer-arith 2 -Wformat 1 -Wunused-function Are you running the latest headers, libraries, mesa and X server bits? Yes, just

Re: [PATCH v2 10/14] systemd-logind: Add systemd-logind core

2014-02-10 Thread David Herrmann
Hi On Mon, Feb 10, 2014 at 10:48 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 02/10/2014 09:58 PM, Jasper St. Pierre wrote: Something I noticed here is that you use GetSessionByPID(). This works right now, but with systemd user sessions, the display server will run outside of a

Re: [PATCH v2 10/14] systemd-logind: Add systemd-logind core

2014-02-10 Thread Hans de Goede
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 02/10/2014 10:49 PM, David Herrmann wrote: Hi On Mon, Feb 10, 2014 at 10:48 PM, Hans de Goede hdego...@redhat.com wrote: Hi, On 02/10/2014 09:58 PM, Jasper St. Pierre wrote: Something I noticed here is that you use GetSessionByPID().

Re: [PULL] button mapping fix and unconstify patches

2014-02-10 Thread Alan Coopersmith
On 02/10/14 01:45 PM, Gaetan Nadon wrote: On 14-02-09 07:03 PM, Keith Packard wrote: Gaetan Nadonmems...@videotron.ca writes: I have a total of 242 warnings. 202-Wshadow 35 -Wunused-result 2 -Wpointer-arith 2 -Wformat 1 -Wunused-function Are you running the latest headers,

Re: [PULL] button mapping fix and unconstify patches

2014-02-10 Thread Keith Packard
Gaetan Nadon mems...@videotron.ca writes: Ok, except for -Wshadow, these are all legitimate warnings (and a few actual bugs!) that we should fix. I would love for someone to explain why my build doesn't generate the useful warnings and why Gaedon's compiler is generating the -Wshadow ones...

Re: [PULL] button mapping fix and unconstify patches

2014-02-10 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: I believe the ones about shadowing system functions like index are silenced in newer gcc versions - for instance I see them with gcc 4.5 but not 4.7. Which gcc did you use in this build? Thanks for testing, Alan! That was my hope; but given

Re: [PULL] button mapping fix and unconstify patches

2014-02-10 Thread Gaetan Nadon
On 14-02-10 06:36 PM, Alan Coopersmith wrote: I believe the ones about shadowing system functions like index are silenced in newer gcc versions - for instance I see them with gcc 4.5 but not 4.7. Which gcc did you use in this build? gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3. From Ubuntu 12.04

Re: [PULL] button mapping fix and unconstify patches

2014-02-10 Thread Gaetan Nadon
On 14-02-10 06:57 PM, Keith Packard wrote: Gaetan Nadon mems...@videotron.ca writes: Ok, except for -Wshadow, these are all legitimate warnings (and a few actual bugs!) that we should fix. I would love for someone to explain why my build doesn't generate the useful warnings and why Gaedon's

Re: [PATCH v2 00/14] Use systemd-logind to manage /dev/... nodes for us

2014-02-10 Thread Dave Airlie
On Tue, Feb 4, 2014 at 9:49 PM, Hans de Goede hdego...@redhat.com wrote: Hi All, Here is v2 of my systemd-logind / run the xserver without root rights series, this version drops some already merged patches, and addresses all the review comments on the first RFC posting of these series. One

Re: [PATCH v2 10/14] systemd-logind: Add systemd-logind core

2014-02-10 Thread Jasper St. Pierre
As said before, with systemd user sessions, this will not happen. Unless I'm misremembering, Lennart has said that the only thing that should be inside the PAM session environment proper should be the session leader like gnome-session. (Disregarding the session worker process like

Re: [PULL] button mapping fix and unconstify patches

2014-02-10 Thread Keith Packard
Gaetan Nadon mems...@videotron.ca writes: On 14-02-10 06:36 PM, Alan Coopersmith wrote: I believe the ones about shadowing system functions like index are silenced in newer gcc versions - for instance I see them with gcc 4.5 but not 4.7. Which gcc did you use in this build? gcc

Re: [PULL] button mapping fix and unconstify patches

2014-02-10 Thread Keith Packard
Gaetan Nadon mems...@videotron.ca writes: On 14-02-10 06:57 PM, Keith Packard wrote: Hopefully people will report what they have on their platforms. Meanwhile, I'll see if I can setup vmware images and find which versions of gcc finds what. A short test case for each missing warning would be

Re: [PATCH v2 10/14] systemd-logind: Add systemd-logind core

2014-02-10 Thread Peter Hutterer
On Tue, Feb 04, 2014 at 12:49:16PM +0100, Hans de Goede wrote: This commits add the bulk of the systemd-logind integration code, but does not hook it up yet other then calling its init and fini functions, which don't do that much. Note the configure bits check for udev since systemd-logind

Re: [PATCH v2 03/14] linux: xf86OpenConsole: Don't detach from controlling tty when it is our vt

2014-02-10 Thread Peter Hutterer
On Tue, Feb 04, 2014 at 12:49:09PM +0100, Hans de Goede wrote: Detaching from our controllling tty makes little sense when it is the same typo: controlling. otherwise, Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter as the vt we're asked to run on. So automatically

Re: [PATCH v2 04/14] xf86Xinput: Modify API for server-managed fd support

2014-02-10 Thread Peter Hutterer
On Tue, Feb 04, 2014 at 12:49:10PM +0100, Hans de Goede wrote: With systemd-logind support, the xserver, rather then the drivers will be typo: than responsible for opening/closing the fd for input devices. This commit adds a new capabilities field to the InputDriverRec and a

Re: [PATCH v2 14/14] xf86OpenSerial: Add support server managed fds

2014-02-10 Thread Peter Hutterer
On Tue, Feb 04, 2014 at 12:49:20PM +0100, Hans de Goede wrote: Try to get a server managed fd from the Options before trying to open the device node ourselves. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Cheers, Peter ---

Re: [PATCH v2 06/14] OdevAttribute: config_odev_add_attribute: replace existing values

2014-02-10 Thread Peter Hutterer
On Tue, Feb 04, 2014 at 12:49:12PM +0100, Hans de Goede wrote: If an attribute already exists replace its value rather then adding a typo: than :) duplicate attribute with the new value to the list. Signed-off-by: Hans de Goede hdego...@redhat.com --- config/config.c | 5 - 1 file

Re: [PATCH v2 05/14] OdevAttribute: Add config_odev_get_attribute helper

2014-02-10 Thread Peter Hutterer
On Tue, Feb 04, 2014 at 12:49:11PM +0100, Hans de Goede wrote: Add a config_odev_get_attribute helper, and replace the diy looing over all hehe. another typo: looping. the attributes done in various places with calls to this helper. Signed-off-by: Hans de Goede hdego...@redhat.com ---

Re: [PATCH v2 08/14] OdevAttribute: Remove unowned flag from OdevAttributes head

2014-02-10 Thread Peter Hutterer
On Tue, Feb 04, 2014 at 12:49:14PM +0100, Hans de Goede wrote: The OdevAttributes struct should just be a head of the attributes list, and not contain various unrelated flags. Instead add a flags field to struct xf86_platform_device and use that. You just introduced int-type attributes, any

Re: [PATCH v2 07/14] OdevAttribute: Add support for integer attributes

2014-02-10 Thread Peter Hutterer
On Tue, Feb 04, 2014 at 12:49:13PM +0100, Hans de Goede wrote: Add a couple of new functions for dealing with storing integer values into OdevAttributes. Signed-off-by: Hans de Goede hdego...@redhat.com --- config/config.c | 40 +

Re: [PATCH v2 09/14] hotplug: Extend OdevAttributes for server-managed fd support

2014-02-10 Thread Peter Hutterer
On Tue, Feb 04, 2014 at 12:49:15PM +0100, Hans de Goede wrote: With systemd-logind support, the xserver, rather than the drivers will be responsible for opening/closing the fd for drm nodes. This commit adds a fd member to OdevAttributes to store the fd to pass it along to the driver.

Re: [PATCH v2 12/14] systemd-logind: Add delayed input device probing

2014-02-10 Thread Peter Hutterer
On Tue, Feb 04, 2014 at 12:49:18PM +0100, Hans de Goede wrote: With systemd-logind we cannot probe input devices while switched away, so if we're switched away, put the pInfo on a list, and probe everything on that list on VT-Enter. This is using an array grown by re-alloc, rather then an

Re: [PATCH v2 11/14] systemd-logind: Hookup systemd-logind integration

2014-02-10 Thread Peter Hutterer
On Tue, Feb 04, 2014 at 12:49:17PM +0100, Hans de Goede wrote: This commits makes the changes necessary outside of the systemd-logind core to make the server use systemd-logind managed fds for input devices and drm nodes. Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-by: Peter

Re: [PATCH 1/2] Fix test/signal-logging to work on Solaris

2014-02-10 Thread Peter Hutterer
On Sun, Feb 09, 2014 at 11:13:50PM -0800, Alan Coopersmith wrote: For some reason, Solaris libc sprintf() doesn't add 0x to the %p output as glibc does, causing the test to fail for not matching the exact output. Since the 0x is desirable, we add it ourselves to the test string.

[PATCH] V2: Add check for link from output to crtc before optimizing out a CrtcSet call

2014-02-10 Thread David Sodman
The function RRCrtcSet call checks to see if the config being set is already configured, but, doesn't check that the selected outputs are connected to the crtc before skipping. This means that the following sequence will omit the final CrtcSet call to the driver: CRTC c1 connect to output o

Would anybody mind the Drop circular pad support patch being reverted?

2014-02-10 Thread Sam Hughes
Specifically, this patch: http://lists.x.org/archives/xorg-devel/2012-May/030892.html Such laptops still exist -- for now, some business rugged Toughbooks, also sold under the Let's Note name in Japan, still sport circular track pads. The CF-SX3 is the latest model with a circular track pad,