Fixing the kernels backlight API

2014-02-12 Thread Hans de Goede
Hi All, Quick self intro: I've been a FOSS developer for 15+ years now and I've been working for Red Hat for 5 years. Recently I've moved to the graphics team. One of my first tasks in the graphics team is to make the xserver run without root rights. I'm making good progress with this, having

[PATCH] xfree86: int10: Fix build on ARM

2014-02-12 Thread Thierry Reding
Commit 7353ec7cb6fc235b03e59e35425201429c83ee72 xfree86: Switch int10 code to stdint types uses designated initializers to setup the fields of the X86EMU_pioFuncs. This breaks compilation on ARM, since out{b,w,l}() are redefined using the preprocessor and therefore cause the compiler to complain

[PATCH 2/2] xfree86: Support autoloading of non-PCI drivers

2014-02-12 Thread Thierry Reding
Drivers for non-PCI devices cannot be autoloaded because there is no mechanism in place to correlate the device to the driver name. This patch adds a simple table that maps the name of the Linux kernel driver name to a list of DDX module names. Matching modules will be added to the list of

[PATCH] Enable subdir-objects

2014-02-12 Thread Thierry Reding
automake complains about the subdir-objects being missing. Enabling it, however, causes various build issues to pop up because $(srcdir), $(top_srcdir), $(builddir) and $(top_builddir) aren't handled properly. It's simple to work around it by substituting them for their actual values, though.

Re: Would anybody mind the Drop circular pad support patch being reverted?

2014-02-12 Thread Bart Massey
Please revert. Keithp has a laptop like this that I've used for a while: works great. I don't understand why this patch was committed? --Bart On Mon, Feb 10, 2014 at 11:11 PM, Sam Hughes sam.reid.hug...@gmail.com wrote: Specifically, this patch:

Re: [PATCH 2/2] xfree86: Support autoloading of non-PCI drivers

2014-02-12 Thread Hans de Goede
Hi, On 02/12/2014 05:11 PM, Thierry Reding wrote: Drivers for non-PCI devices cannot be autoloaded because there is no mechanism in place to correlate the device to the driver name. This patch adds a simple table that maps the name of the Linux kernel driver name to a list of DDX module

Re: [PULL] button mapping fix and unconstify patches

2014-02-12 Thread Gaetan Nadon
On 14-02-11 10:47 PM, Keith Packard wrote: Oh, right, I remember this from fontconfig -- ubuntu sets _FORTIFY_SOURCE by default. I'd love to use this in the X server by default, but I'm concerned that we'll end up breaking builds on ubuntu if we unilaterally define it. Can you see what your

Re: [PULL] button mapping fix and unconstify patches

2014-02-12 Thread Keith Packard
Gaetan Nadon mems...@videotron.ca writes: On gcc 4.6.3 (Ubuntu 12-04), I get the following error in hw/vfb when linking ../../Xext/.libs/libXext.a(xvmc.o): In function `xf86XvMCRegisterDRInfo': /home/nadon/xorg/src/xserver/Xext/xvmc.c:808: undefined reference to `strlcpy'

Re: [PATCH] Enable subdir-objects

2014-02-12 Thread Julien Cristau
On Wed, Feb 12, 2014 at 17:15:26 +0100, Thierry Reding wrote: automake complains about the subdir-objects being missing. Enabling it, however, causes various build issues to pop up because $(srcdir), $(top_srcdir), $(builddir) and $(top_builddir) aren't handled properly. It's simple to work

[PATCH app/xev v2] Add event filter for button events

2014-02-12 Thread Egbert Eich
Signed-off-by: Egbert Eich e...@freedesktop.org --- man/xev.man | 2 +- xev.c | 5 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/man/xev.man b/man/xev.man index 4edec10..ba70463 100644 --- a/man/xev.man +++ b/man/xev.man @@ -62,7 +62,7 @@ The option can be specified

Re: [PATCH 2/2] xfree86: Support autoloading of non-PCI drivers

2014-02-12 Thread Thierry Reding
On Wed, Feb 12, 2014 at 05:28:56PM +0100, Hans de Goede wrote: Hi, On 02/12/2014 05:11 PM, Thierry Reding wrote: Drivers for non-PCI devices cannot be autoloaded because there is no mechanism in place to correlate the device to the driver name. This patch adds a simple table that maps

Re: [PATCH] Enable subdir-objects

2014-02-12 Thread Thierry Reding
On Wed, Feb 12, 2014 at 07:34:37PM +0100, Julien Cristau wrote: On Wed, Feb 12, 2014 at 17:15:26 +0100, Thierry Reding wrote: automake complains about the subdir-objects being missing. Enabling it, however, causes various build issues to pop up because $(srcdir), $(top_srcdir),

Re: Fixing the kernels backlight API

2014-02-12 Thread Dave Airlie
The biggest remaining stumbling block is the backlight API, because opening the sysfs files requires root rights. I'll very likely write a little helper for this for now, but in the long run it would be good to have a better solution. While discussion this in the graphics devroom at

[PATCH 1/2] Validate .pc file Requires lines

2014-02-12 Thread Keith Packard
This walks through the .pc.in files and makes sure all of the Requires lines express sufficient dependency information. Signed-off-by: Keith Packard kei...@keithp.com --- Makefile.am | 5 - check-pc-requires | 60 +++ 2 files

[PATCH 2/2] Update .pc file Requires lines to express full dependencies

2014-02-12 Thread Keith Packard
Some xcb libraries depend on others; make these dependencies explicit in the .pc files that are installed. This change was generated automatically by running 'check-pc-requires -fix' Signed-off-by: Keith Packard kei...@keithp.com --- xcb-composite.pc.in | 2 +- xcb-damage.pc.in| 2 +-

[PATCH 0/2] Fix intra-xcb .pc file dependencies automatically

2014-02-12 Thread Keith Packard
The first patch introduces a tool to check (and automatically fix) Requires lines in the installed .pc files. When run with 'make check', this shows that there are missing dependencies. The second patch applies the automatic fixes generated by the new tool.

Re: [Xcb] [PATCH 2/2] Update .pc file Requires lines to express full dependencies

2014-02-12 Thread Uli Schlachter
On 12.02.2014 21:14, Keith Packard wrote: Some xcb libraries depend on others; make these dependencies explicit in the .pc files that are installed. This change was generated automatically by running 'check-pc-requires -fix' Signed-off-by: Keith Packard kei...@keithp.com ---

Re: Fixing the kernels backlight API

2014-02-12 Thread Ville Syrjälä
On Thu, Feb 13, 2014 at 06:14:04AM +1000, Dave Airlie wrote: The biggest remaining stumbling block is the backlight API, because opening the sysfs files requires root rights. I'll very likely write a little helper for this for now, but in the long run it would be good to have a

[PATCH] Also track directly imported modules in a separate list

2014-02-12 Thread Keith Packard
This allows the generated header files to only include the directly referenced header files, with the indirectly referenced header files included by the directly referenced ones. Signed-off-by: Keith Packard kei...@keithp.com --- xcbgen/matcher.py | 2 ++ xcbgen/state.py | 4 2 files

Re: [PATCH app/xev v2] Add event filter for button events

2014-02-12 Thread Peter Hutterer
On Wed, Feb 12, 2014 at 07:27:26PM +0100, Egbert Eich wrote: Signed-off-by: Egbert Eich e...@freedesktop.org b2cde17..3083d6f master - master Cheers, Peter --- man/xev.man | 2 +- xev.c | 5 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/man/xev.man

[PATCH 1/3] Only #include directly referenced module header files

2014-02-12 Thread Keith Packard
This avoids having the nested header files also included at the top level, which is more efficient. Signed-off-by: Keith Packard kei...@keithp.com --- src/c_client.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/c_client.py b/src/c_client.py index b2e..c94a9e6

[PATCH 2/3] Validate .pc file Requires lines

2014-02-12 Thread Keith Packard
This walks through the .pc.in files and makes sure all of the Requires lines express sufficient dependency information. Signed-off-by: Keith Packard kei...@keithp.com --- Makefile.am | 8 ++- check-pc-requires | 70 +++ 2 files

[PATCH 0/3] Fix intra-xcb .pc file dependencies automatically

2014-02-12 Thread Keith Packard
However, I don't like the result. composite.xml imports only xproto and xfixes. The dependency on render and shape occur because xfixes depends on these. In other words, your tool is including transitive dependencies. I've patched that by fixing xcb to only #include files for direct

[PATCH 3/3] Update .pc file Requires lines to express full dependencies

2014-02-12 Thread Keith Packard
Some xcb libraries depend on others; make these dependencies explicit in the .pc files that are installed. This change was generated automatically by running 'check-pc-requires -fix' Signed-off-by: Keith Packard kei...@keithp.com --- xcb-present.pc.in | 2 +- xcb-randr.pc.in | 2 +-

Re: Fixing the kernels backlight API

2014-02-12 Thread David Herrmann
Hi On Wed, Feb 12, 2014 at 9:43 PM, Ville Syrjälä ville.syrj...@linux.intel.com wrote: On Thu, Feb 13, 2014 at 06:14:04AM +1000, Dave Airlie wrote: The biggest remaining stumbling block is the backlight API, because opening the sysfs files requires root rights. I'll very likely write a

Re: [PULL] button mapping fix and unconstify patches

2014-02-12 Thread Gaetan Nadon
On 14-02-12 12:57 PM, Keith Packard wrote: This function is supposed to be automatically replaced with os/strlcpy.c when not present in your C library. Something appears to be amiss here; I don't have strlcpy *or* strlcat in my glibc, and so configure correctly adds os/strlcpy.c and

Re: [PATCH] Enable subdir-objects

2014-02-12 Thread Gaetan Nadon
On 14-02-12 11:15 AM, Thierry Reding wrote: automake complains about the subdir-objects being missing. Enabling it, Is automake issuing a real warning or just making a suggestion? however, causes various build issues to pop up because $(srcdir), $(top_srcdir), $(builddir) and $(top_builddir)

Re: [PATCH] Enable subdir-objects

2014-02-12 Thread Gaetan Nadon
On 14-02-12 05:50 PM, Gaetan Nadon wrote: +AM_INIT_AUTOMAKE([foreign dist-bzip2 subdir-objects]) This is not a new feature in 1.14, but it has never been used so far. All 250 X modules have the same line. If you want to propose this, as it changes all of xserver, you would have to test all 98

Re: [PULL] button mapping fix and unconstify patches

2014-02-12 Thread Keith Packard
Gaetan Nadon mems...@videotron.ca writes: On 14-02-12 12:57 PM, Keith Packard wrote: This function is supposed to be automatically replaced with os/strlcpy.c when not present in your C library. Something appears to be amiss here; I don't have strlcpy *or* strlcat in my glibc, and so

Re: [PATCH 2/2] xfree86: Support autoloading of non-PCI drivers

2014-02-12 Thread Aaron Plattner
On 02/12/2014 11:09 AM, Thierry Reding wrote: * PGP Signed by an unknown key On Wed, Feb 12, 2014 at 05:28:56PM +0100, Hans de Goede wrote: Hi, On 02/12/2014 05:11 PM, Thierry Reding wrote: Drivers for non-PCI devices cannot be autoloaded because there is no mechanism in place to correlate

Re: [PULL] button mapping fix and unconstify patches

2014-02-12 Thread Peter Hutterer
On Wed, Feb 12, 2014 at 05:43:04PM -0500, Gaetan Nadon wrote: On 14-02-12 12:57 PM, Keith Packard wrote: This function is supposed to be automatically replaced with os/strlcpy.c when not present in your C library. Something appears to be amiss here; I don't have strlcpy *or* strlcat in

Re: [PULL] button mapping fix and unconstify patches

2014-02-12 Thread Gaetan Nadon
On 14-02-12 06:24 PM, Keith Packard wrote: So, we could simply add #ifndef _FORTIFY_SOURCE #define _FORTIFY_SOURCE 2 #endif to some X server header file, or you could do something fancier with the configure macros. I'm easy, but I definitely want it somehow :-)

Re: [PULL] button mapping fix and unconstify patches

2014-02-12 Thread Gaetan Nadon
On 14-02-12 07:37 PM, Peter Hutterer wrote: just an issue with incomplete builds, happens to me when I rebase or switch branches. make clean in os/ usually does the job, otherwise autoreconf/configure definitely does. yep, I rebased, applied a patch, ran ./configure (but not autogen) Thanks

Re: [PATCH] Enable subdir-objects

2014-02-12 Thread Gaetan Nadon
On 14-02-12 05:50 PM, Gaetan Nadon wrote: If the automake defined variables $(top_srcdir) does not work, then something is seriously broken and the root cause should be found, not worked around :-) A lot has been written about this already. I was able to reproduce the problem with 1.11. Various

Re: [PATCH 2/2] Update .pc file Requires lines to express full dependencies

2014-02-12 Thread Alan Coopersmith
On 02/12/14 12:14 PM, Keith Packard wrote: Some xcb libraries depend on others; make these dependencies explicit in the .pc files that are installed. Dependencies via libraries should be tracked via linking the libraries so the ELF data records them correctly. If the headers are required, the

Re: [PATCH 2/2] Update .pc file Requires lines to express full dependencies

2014-02-12 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: Dependencies via libraries should be tracked via linking the libraries so the ELF data records them correctly. Yeah, that's not the problem these changes are trying to solve. If the headers are required, the dependencies should appear on

[PATCH synaptics] Revert Drop circular pad support

2014-02-12 Thread Peter Hutterer
This reverts commit 3b02e7fd81da4b100fb9ac32378f6d50f54cf0e2. Apparently these devices still exist after all. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Conflicts: man/synaptics.man src/synaptics.c --- Untested, this is just a straight revert with the conflicts fixed

Re: Fixing the kernels backlight API

2014-02-12 Thread Alexander E. Patrakov
13.02.2014 04:26, David Herrmann wrote: The attach stuff actually sounds doable, but who decides which one to attach? You still need some user-space script during device-plug for that. But to be honest, the simplest way would be a backlightd bus-activatable daemon. SetBacklight() then takes a