Adding a return value to set_cursor_position() to allow it to report failure

2014-04-10 Thread Michael Thayer
Since I did not get feedback about whether or not this patch would be of interest I just went ahead and wrote it. Sadly I have missed the merge window for 1.16 (so I had to bump the ABI version again in the patch). I am also thinking that my previous patch to add a return value to

[PATCH] Add a return value to set_cursor_position() to allow it to report failure

2014-04-10 Thread Michael Thayer
set_cursor_position() may need to be able to fail and have the server fall back to a software cursor in at least the situation in which we are running on virtual hardware and using the host cursor as a hardware cursor for the guest but cannot change its position. Signed-off-by: Michael Thayer

Re: [PATCH xf86-input-mouse] Do not drop the result of protocol detection

2014-04-10 Thread Michael Thayer
No response on this yet. Who would be the right person for looking at patches to xf86-input-mouse? I do realise that it is no longer as widely used as it once was... Regards, Michael On 31/03/14 11:21, Michael Thayer wrote: In MousePickProtocol() with protocol PROT_AUTO we probe for the

[PATCH] linux: Propagate failure up to xf86MapVidMem (#18304)

2014-04-10 Thread Adam Jackson
As opposed to calling FatalError. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/os-support/linux/lnx_video.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/os-support/linux/lnx_video.c b/hw/xfree86/os-support/linux/lnx_video.c index

Re: [PATCH] linux: Propagate failure up to xf86MapVidMem (#18304)

2014-04-10 Thread walter harms
why is it bad to exit here ? can the caller fix that issue ? Am 10.04.2014 16:52, schrieb Adam Jackson: As opposed to calling FatalError. Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/os-support/linux/lnx_video.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

ETEST, EINTR, and interrupted read() system call

2014-04-10 Thread Jason Craig
Hi, I posted this on one of the other mailing lists but haven't seen any response so maybe this is a better list for it. I am troubleshooting a problem with a Java X client getting disconnected from the X-server (explicit kill or server shutdown message). I've tracked it down in the

[PATCH] xfixes: Forbid manipulating clip for source-only pictures (#28968)

2014-04-10 Thread Adam Jackson
Just throw BadPicture instead of crashing. It's not currently a meaningful thing to do anyway, RenderSetPictureRectangles would error if you tried (which this patch changes to BadPicture as well for consistency). The problem with trying to do it is if the clip is specified as a pixmap then we

[PATCH] xres: Fix size estimation for 8bpp pixmaps (#69057)

2014-04-10 Thread Adam Jackson
Just use floats, it's not like this is a performance path. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/xres.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Xext/xres.c b/Xext/xres.c index b26cbb5..546b942 100644 --- a/Xext/xres.c +++ b/Xext/xres.c @@ -353,9

[PATCH] shadowfb: Port to miext/damage (#31303, #65547)

2014-04-10 Thread Adam Jackson
Somewhat shocking how much simpler this is, isn't it? We no longer need to wrap the screen or GC or Picture, because damage does it for us, which is doubly great since the old shadowfb code didn't wrap _enough_ things (border updates and Render glyphs, at least). The only real difference now

Re: [PATCH] xres: Fix size estimation for 8bpp pixmaps (#69057)

2014-04-10 Thread Julien Cristau
On Thu, Apr 10, 2014 at 11:45:37 -0400, Adam Jackson wrote: Just use floats, it's not like this is a performance path. Signed-off-by: Adam Jackson a...@redhat.com --- Xext/xres.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Julien Cristau jcris...@debian.org

[PATCH xf86-input-mouse] Make absolute input reporting in Solaris aware of resolution changes

2014-04-10 Thread Michael Thayer
Currently on Solaris absolute input reporting only takes resolution changes into account when the video driver is using the pre-RandR 1.2 APIs, and there it uses the physical resolution, not the virtual. This patch fixes those two things. Signed-off-by: Michael Thayer michael.tha...@oracle.com

Re: [PATCH xf86-input-mouse] Do not drop the result of protocol detection

2014-04-10 Thread Alan Coopersmith
On 04/10/14 07:20 AM, Michael Thayer wrote: No response on this yet. Who would be the right person for looking at patches to xf86-input-mouse? I do realise that it is no longer as widely used as it once was... Occasionally the BSD folks will pipe in, but mostly it's been Peter Hutterer and