Re: [PULL] screensaver/dpms fix, sysconfigdir, pointer accel revert

Peter Hutterer peter.hutte...@who-t.net writes: Keith, Please pull the changes below. The revert explains itself in the commit message but the long story short here is that it doesn't work for all devices and fixing it in a sane manner requires lockstep between the server and synaptics.

[PATCH v2 0/2] Fix ODEV_ATTRIB_DRIVER overlapping with ODEV_ATTRIB_FD

Hi Keith, Here is a v2 of my odev-attrribute fix patch. The actual patch itself is unchanged. New is the second patch which makes the api robust against storing an int in a string attribute or vice versa. Note the robustness patch needs to be applied after the fix, otherwise the switch-case in

[PATCH v2 2/2] config_odev_add_attribute*: Check for right attribute type

Don't allow setting string attributes to integers and vice versa. Signed-off-by: Hans de Goede hdego...@redhat.com --- config/config.c | 32 include/hotplug.h | 2 +- 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/config/config.c

[PATCH v2 1/2] Fix ODEV_ATTRIB_DRIVER overlapping with ODEV_ATTRIB_FD

Looks like the value of ODEV_ATTRIB_DRIVER was not updated when the patch adding it got rebased on top of a newer server version. This fixes the xserver crashing when systemd-logind integration is used. https://bugzilla.redhat.com/show_bug.cgi?id=1118540 Signed-off-by: Hans de Goede

Re: [PATCH] headers: Fix build errors with latest glibc

Hi Daniel, Can I / we please get a reply from you on this ? As explained below this is not about glamor.h, but about making os.h safe to include which really is an orthogonal problem, The glamor.h usage of os.h was just a (bad) example. Regards, Hans On 07/03/2014 10:50 PM, Hans de Goede

Re: [PATCH] headers: Fix build errors with latest glibc

On Mon, Jul 14, 2014 at 14:33:00 +0200, Hans de Goede wrote: Hi Daniel, Can I / we please get a reply from you on this ? As explained below this is not about glamor.h, but about making os.h safe to include which really is an orthogonal problem, The glamor.h usage of os.h was just a (bad)

Re: [PATCH] headers: Fix build errors with latest glibc

Hi, On 07/14/2014 02:43 PM, Julien Cristau wrote: On Mon, Jul 14, 2014 at 14:33:00 +0200, Hans de Goede wrote: Hi Daniel, Can I / we please get a reply from you on this ? As explained below this is not about glamor.h, but about making os.h safe to include which really is an orthogonal

Re: [PATCH] headers: Fix build errors with latest glibc

Hi, On 14 July 2014 13:51, Hans de Goede hdego...@redhat.com wrote: On 07/14/2014 02:43 PM, Julien Cristau wrote: On Mon, Jul 14, 2014 at 14:33:00 +0200, Hans de Goede wrote: Can I / we please get a reply from you on this ? As explained below this is not about glamor.h, but about making

Issues with Modes implementation of Screen Rotation on USB-Connected SMSC UFX6000 video

I currently maintain the commercial version of the Xorg display driver for usb-connected SMSC UFX6000 and UFX7000 chipsets. Recently we've been looking into implementing standard screen rotation. Since there is no hardware support for it in the chipsets, we would prefer to simply set the

Re: [PATCH v2 0/2] Fix ODEV_ATTRIB_DRIVER overlapping with ODEV_ATTRIB_FD

Hans de Goede hdego...@redhat.com writes: Note the robustness patch needs to be applied after the fix, otherwise the switch-case in the fix will fail to compile due to a duplicate label. This is better than my version as it effectively types the values explicitly. Thanks! Reviewed-by: Keith