Re: [PATCH] xwayland-input: Always set the xkb group index on modifiers events

Hi, On 15 July 2014 14:57, Rui Matos tiagoma...@gmail.com wrote: While we have keyboard focus, the server's xkb code is already locking and latching modifiers appropriately while processing keyboard events. Since there is no guaranteed order between wl_keyboard key and modifiers events, if

[PATCH] randr: Fix logic in RRPointerToNearestCrtc

RRPointerToNearestCrtc is suppose to snap to the nearest Crtc, but the code is buggy. Correct the calculation of delta x/y values and choose the closest Crtc. Signed-off-by: David Ung dav...@nvidia.com --- randr/rrpointer.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-)

Re: [PATCH 0/2] Replace OdevAttributes API

Hi Keith, This regressed compilation of the Intel driver in gnome Continuous. I've attached a patch which fixes it here. From 3bfd4178341f8eb2c22ff3287478ce3c8a542028 Mon Sep 17 00:00:00 2001 From: Colin Walters walt...@verbum.org Date: Fri, 18 Jul 2014 08:11:14 -0400 Subject: [PATCH]

Re: [PATCH 0/2] Replace OdevAttributes API

Colin Walters walt...@verbum.org writes: Hi Keith, This regressed compilation of the Intel driver in gnome Continuous. Thanks. I noticed the same problem last night. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpK3v9UHqGdb.pgp Description: PGP signature

Re: [PATCH 0/2] Replace OdevAttributes API

Colin Walters walt...@verbum.org writes: Subject: [PATCH] xf86platformBus: Add assertion to avoid (fatal) compiler warning Merged. 5c2e9fa..ac3acab master - master -- keith.pack...@intel.com pgpcabd21bteJ.pgp Description: PGP signature ___

[PATCH 09/16] xv: Move xf86 XV color key helper to core.

Color key overlay implementations want to reuse this code, and XF86's had bugs. Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdix.h | 2 ++ Xext/xvmain.c | 31 +++ hw/xfree86/common/xf86xv.c | 25 + 3 files

[PATCH 12/16] kdrive: Don't bother explicitly clearing new window privates to NULL.

Privates are initially cleared to zero by dixInitPrivates(). Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/src/kxv.c | 21 - hw/kdrive/src/kxv.h | 1 - 2 files changed, 22 deletions(-) diff --git a/hw/kdrive/src/kxv.c b/hw/kdrive/src/kxv.c index c916af4..0b4335a

[PATCH 16/16] xv: Remove the pScreen from the XV encodings.

It was never used, and it meant a bunch of pointless frobbing of structure members between the DDX and DIX. Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdix.h | 1 - hw/kdrive/ephyr/ephyr_glamor_xv.c | 2 +- hw/kdrive/ephyr/ephyrvideo.c | 2 +-

[PATCH 04/16] xv: Drop the ddQueryAdaptors() interface.

The core was passing pointers to pxvs's nAdaptors and pAdaptors, and the two hardware implementations were copying pxvs's nAdaptors and pAdaptors into those pointers. Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdisp.c | 2 -- Xext/xvdix.h | 1 -

[PATCH 15/16] kdrive: Remove a dead struct.

It's never been used in the history of the tree. Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/src/kxv.h | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/kdrive/src/kxv.h b/hw/kdrive/src/kxv.h index 4eb4054..b997299 100644 --- a/hw/kdrive/src/kxv.h +++

XV cleanup series

Here's a pile of stuff I wrote when I was working on Xephyr XV with glamor. I wanted glamor to be able to create adaptors on its own without needing cooperation from the DDX, and I didn't want to build a third copy of DDX XV, so I was trying to clean up and share common code. I eventually backed

[PATCH 02/16] xv: Remove dead VIDEO_NO_CLIPPING from the xorg and kdrive DDXes.

As far as I can see, nothing has ever used this flag except possibly the i.mx6 xorg ddx debug during bringup. Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/src/kxv.c | 46 hw/kdrive/src/kxv.h | 1 -

[PATCH 07/16] xv: Drop unused XvdiVideoStopped().

Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdix.h | 1 - Xext/xvmain.c | 24 2 files changed, 25 deletions(-) diff --git a/Xext/xvdix.h b/Xext/xvdix.h index ddd8abb..b61659c 100644 --- a/Xext/xvdix.h +++ b/Xext/xvdix.h @@ -235,7 +235,6 @@ extern _X_EXPORT

[PATCH 14/16] xv: Drop the ClientPtr from the interface to the DDX.

Nobody was using it. Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdisp.c | 8 +++- Xext/xvdix.h | 20 +-- Xext/xvmain.c | 20 +-- hw/kdrive/src/kxv.c| 49 +++---

[PATCH 03/16] xv: Move common code for adaptor cleanup to xvmain.c

Since any DDX XV screen cleanup would need this same code for freeing the tree of pointers for xv adaptors, move it to the dix. Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdix.h | 1 + Xext/xvmain.c | 41 +

[PATCH 11/16] kdrive: Remove dead KXVPaintRegion().

It's been unused since mach64 was deleted, and now there's a helper in core XV. Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/src/kxv.c | 41 - hw/kdrive/src/kxv.h | 3 --- 2 files changed, 44 deletions(-) diff --git a/hw/kdrive/src/kxv.c

[PATCH 01/16] xv: Remove dead VIDEO_INVERT_CLIPLIST from the xorg and kdrive DDXes.

As far as I can see (looking at trees on my disk, plus googling for the term), nothing has ever used this flag Signed-off-by: Eric Anholt e...@anholt.net --- hw/kdrive/src/kxv.c | 24 hw/kdrive/src/kxv.h | 1 - hw/xfree86/common/xf86xv.c | 24

[PATCH 13/16] xv: Remove the no-op AllocatePort/FreePort interfaces.

Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdisp.c | 88 ++ Xext/xvdix.h | 3 -- Xext/xvmain.c | 2 +- hw/kdrive/src/kxv.c| 17 - hw/xfree86/common/xf86xv.c | 17 - 5 files

[PATCH 10/16] xv: Fix malloc-failure cases in the fill color key helper.

Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvmain.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/Xext/xvmain.c b/Xext/xvmain.c index a3fb711..d84708b 100644 --- a/Xext/xvmain.c +++ b/Xext/xvmain.c @@ -1096,22 +1096,26 @@

[PATCH 05/16] xv: Move the DDX XV screen private allocation into the DDXes.

XV was going against convention by having the core infrastructure allocate the private on behalf of the DDX. I was interested in this because I was trying to make multiple pieces of DDX be able to allocate adaptors, and that wasn't going to work if DDX-specific code was hung off of a single

[PATCH 08/16] xv: Move CloseScreen setup from a DIX hook to normal wrapping.

Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdix.h | 1 - Xext/xvmain.c | 2 -- hw/kdrive/src/kxv.c| 18 +- hw/kdrive/src/kxv.h| 1 + hw/xfree86/common/xf86xv.c | 19 ++-

[PATCH 06/16] xv: Drop unused XvdiPreemptVideo().

Signed-off-by: Eric Anholt e...@anholt.net --- Xext/xvdix.h | 1 - Xext/xvmain.c | 22 -- 2 files changed, 23 deletions(-) diff --git a/Xext/xvdix.h b/Xext/xvdix.h index 2437eb4..ddd8abb 100644 --- a/Xext/xvdix.h +++ b/Xext/xvdix.h @@ -259,7 +259,6 @@ extern _X_EXPORT int

[PATCH] glamor: Add support for SHM sync fences

This hooks up SHM sync fences to complete the requirements for DRI3 running on Glamor. Signed-off-by: Keith Packard kei...@keithp.com --- glamor/Makefile.am | 1 + glamor/glamor.c | 2 + glamor/glamor_priv.h | 15 +++ glamor/glamor_sync.c | 117

[PATCH] xfree86: Avoid compiler warning for unused vars without systemd

When systemd isn't being used, systemd_logind_release_fd is defined as an empty macro, leaving the arguments unused. Fix the compiler warnings by simply removing the local variables and referencing the structure within the macro call. Signed-off-by: Keith Packard kei...@keithp.com ---

Re: [PATCH 01/16] xv: Remove dead VIDEO_INVERT_CLIPLIST from the xorg and kdrive DDXes.

Eric Anholt e...@anholt.net writes: As far as I can see (looking at trees on my disk, plus googling for the term), nothing has ever used this flag Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpgG8YNQoFsC.pgp Description: PGP signature

Re: [PATCH 02/16] xv: Remove dead VIDEO_NO_CLIPPING from the xorg and kdrive DDXes.

Eric Anholt e...@anholt.net writes: As far as I can see, nothing has ever used this flag except possibly the i.mx6 xorg ddx debug during bringup. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpX4p2_W_UFs.pgp Description: PGP signature

Re: [PATCH 03/16] xv: Move common code for adaptor cleanup to xvmain.c

Eric Anholt e...@anholt.net writes: Since any DDX XV screen cleanup would need this same code for freeing the tree of pointers for xv adaptors, move it to the dix. I believe the original assumption was that this whole thing was statically initialized and hence didn't need any cleanup. If

Re: [PATCH 04/16] xv: Drop the ddQueryAdaptors() interface.

Eric Anholt e...@anholt.net writes: The core was passing pointers to pxvs's nAdaptors and pAdaptors, and the two hardware implementations were copying pxvs's nAdaptors and pAdaptors into those pointers. I have no idea why this might have been done this way... Reviewed-by: Keith Packard

Re: [PATCH 05/16] xv: Move the DDX XV screen private allocation into the DDXes.

Eric Anholt e...@anholt.net writes: -/* The Xv di layer provides us with a private hook so that we don't - have to allocate our own screen private. They also provide - a CloseScreen hook so that we don't have to wrap it. I'm not - sure that I appreciate that. */ -

Re: [PATCH 07/16] xv: Drop unused XvdiVideoStopped().

Eric Anholt e...@anholt.net writes: Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpx4rJQpsAUN.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 06/16] xv: Drop unused XvdiPreemptVideo().

Eric Anholt e...@anholt.net writes: Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpFolDZSTKxL.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 05/16] xv: Move the DDX XV screen private allocation into the DDXes.

Eric Anholt e...@anholt.net writes: XV was going against convention by having the core infrastructure allocate the private on behalf of the DDX. I was interested in this because I was trying to make multiple pieces of DDX be able to allocate adaptors, and that wasn't going to work if

Re: [PATCH 08/16] xv: Move CloseScreen setup from a DIX hook to normal wrapping.

Eric Anholt e...@anholt.net writes: Signed-off-by: Eric Anholt e...@anholt.net Now you can get rid of the close screen comment :-) Reviewed-by: Keith Packard kei...@keithp.com --- Xext/xvdix.h | 1 - Xext/xvmain.c | 2 -- hw/kdrive/src/kxv.c

Re: [PATCH 09/16] xv: Move xf86 XV color key helper to core.

Eric Anholt e...@anholt.net writes: Color key overlay implementations want to reuse this code, and XF86's had bugs. +gc = GetScratchGC(pDraw-depth, pScreen); +pval[0].val = key; +pval[1].val = IncludeInferiors; Why is this set? I hope this isn't being drawn to the root window.

Re: [PATCH 12/16] kdrive: Don't bother explicitly clearing new window privates to NULL.

Eric Anholt e...@anholt.net writes: Privates are initially cleared to zero by dixInitPrivates(). Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpt8r8Dv6_2T.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 11/16] kdrive: Remove dead KXVPaintRegion().

Eric Anholt e...@anholt.net writes: It's been unused since mach64 was deleted, and now there's a helper in core XV. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgp9vqtew7YHx.pgp Description: PGP signature ___

Re: [PATCH 13/16] xv: Remove the no-op AllocatePort/FreePort interfaces.

Eric Anholt e...@anholt.net writes: Signed-off-by: Eric Anholt e...@anholt.net This also changes the ddQueryBestSize API. Which is fine and all, but should be in a separate patch. -- keith.pack...@intel.com pgpAYG7mnJKGQ.pgp Description: PGP signature

Re: [PATCH 14/16] xv: Drop the ClientPtr from the interface to the DDX.

Eric Anholt e...@anholt.net writes: Nobody was using it. About the only thing it could be used for was the value in BadValue returns... Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpjKMIVCjvue.pgp Description: PGP signature

Re: [PATCH 15/16] kdrive: Remove a dead struct.

Eric Anholt e...@anholt.net writes: It's never been used in the history of the tree. I think it was for displays with multiple frame buffers of different depths. It's been a very long time... Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpHP6IfSHLAt.pgp

Re: [PATCH] glamor: Add support for SHM sync fences

Keith Packard kei...@keithp.com writes: This hooks up SHM sync fences to complete the requirements for DRI3 running on Glamor. Signed-off-by: Keith Packard kei...@keithp.com This looks equivalent to what I had in my Xephyr DRI3 branch. Reviewed-by: Eric Anholt e...@anholt.net

Re: [PATCH 16/16] xv: Remove the pScreen from the XV encodings.

Eric Anholt e...@anholt.net writes: It was never used, and it meant a bunch of pointless frobbing of structure members between the DDX and DIX. This will generate warnings when initializing the (char *) name field From a constant string. One option would be to just make that 'const' and then

Re: [PATCH 14/16] xv: Drop the ClientPtr from the interface to the DDX.

On Fri, Jul 18, 2014 at 10:32:31AM -0700, Eric Anholt wrote: Nobody was using it. The ClientPtr gets used to send events back to the Client from various implementations of Xv. -Chris -- Chris Wilson, Intel Open Source Technology Centre ___

Re: [PATCH] glamor: Add support for SHM sync fences

Eric Anholt e...@anholt.net writes: Reviewed-by: Eric Anholt e...@anholt.net Merged. ac3acab..cfa302d master - master -- keith.pack...@intel.com pgpx2sMobSRB8.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 10/16] xv: Fix malloc-failure cases in the fill color key helper.

On Fri, Jul 18, 2014 at 1:32 PM, Eric Anholt e...@anholt.net wrote: Signed-off-by: Eric Anholt e...@anholt.net Does what it says on the box. Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- Xext/xvmain.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-)

Re: [PATCH] Revert glamor: Fix coordinates handling for composite source/mask pictures

On Thu, Jul 17, 2014 at 20:08:43 -0700, Keith Packard wrote: Alex Deucher alexdeuc...@gmail.com writes: Merged (with ErrorF lines removed): 16fbad3..55f5bfb master - master Probably worth pulling into the 1.16 stable branch too. Yes, definitely desired. To

[PATCH] glamor: sync_fence_set_triggered should use glFlush, not glFinish

I intended to use glFlush all along, but somehow managed to type glFinish instead. glFlush is sufficient (for a single-queue GPU) to ensure serialization between queued rendering in the X server and future rendering from the client. Signed-off-by: Keith Packard kei...@keithp.com ---