Re: [PATCH] dri2: Only invalidate our tree upon Pixmap changes

2014-10-27 Thread Chris Wilson
On Sun, Oct 26, 2014 at 05:23:42PM -0700, Keith Packard wrote: Chris Wilson ch...@chris-wilson.co.uk writes: x11perf -ucreate highlights an instance where compCreateWindow reassigns the same Pixmap to the Window. Currently this triggers an expensive invalidation of the entire window

Re: [PATCH inputproto] specs: rename EVENTMASK to EVTYPEMASK

2014-10-27 Thread Hans de Goede
Hi, On 10/27/2014 05:37 AM, Peter Hutterer wrote: EVENTMASK was used twice in the spec, once as the actual bitmask for events, once as the set of deviceid, mask length and mask. The libXi public API uses XIEventMask for the latter data triplet, so leave EVENTMASK, and rename the pure

[PATCH] xkbcomp: Improved -w option parsing

2014-10-27 Thread Vincent Lefevre
This patch improves -w option parsing even further, for cases like xkbcomp -w6 4.xkb out.xkb (which were not handled by the fix of #66344). Moreover, though this form can be regarded as ambiguous, the warning level is still optional (set to 0 if not present), and errors like xkbcomp -wfoo in out

xf86-input-evdev not working with touch device with MT only axes

2014-10-27 Thread Pasrshuram Thombare
Hi, I am using xf86-input-evdev(2.8.1) for touch device with MT only axes, but I am getting following error. evdev: found only multitouch-axes. That shouldn't happen. evdev: failed to initialize for absolute axes. I am aware of Bug#64029. But solution seems just a way to avoid crash. Is

Re: [PATCH xfree86] Skip SetCursor when vtSema is FALSE.

2014-10-27 Thread Adam Jackson
On Wed, 2014-10-22 at 12:55 +0530, Yogish Kulkarni wrote: Consider below sequence - 1) Cursor is removed : isUp will be FALSE if HW cursor is set. 2) VT switched away from X : vtSema becomes FALSE. 3) xf86CursorSetCursor is called with non-null CursorPtr : Saves the passed in CursorPtr,

[PATCH 07/23] mi: Fold mifpolycon.c into miarc.c

2014-10-27 Thread Adam Jackson
Also put mifpoly.h on a diet, and stop including it from places that don't need it. Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/sdksyms.sh | 1 - mi/Makefile.am| 1 - mi/miarc.c| 205

[PATCH 02/23] mi: Unexport polygon edge table implementation details

2014-10-27 Thread Adam Jackson
Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- mi/mipoly.h | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/mi/mipoly.h b/mi/mipoly.h index e37fb48..02fcfc8 100644 --- a/mi/mipoly.h +++ b/mi/mipoly.h @@

[PATCH 01/23] mi: Unexport wide line details

2014-10-27 Thread Adam Jackson
XAA wanted these, once upon a time, but that's gone now. Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/sdksyms.sh | 1 - mi/Makefile.am| 2 +- mi/miwideline.c | 8 mi/miwideline.h | 25

[PATCH 06/23] mi: Fold mispans.c into miwideline.c

2014-10-27 Thread Adam Jackson
Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- hw/xfree86/sdksyms.sh | 1 - mi/Makefile.am| 2 - mi/mispans.c | 526 -- mi/mispans.h | 83 mi/miwideline.c |

[PATCH 00/23] mi/fb diet, GC client clip, and GC type fixes

2014-10-27 Thread Adam Jackson
Mostly a resend of previous efforts. 23 changes the unsigned longs in the GC to be unsigned int, since that's all the bigger pixels are anyway, and the serial number needn't be 64 bits. This series is also available in my for-keithp branch on people.fd.o. - ajax

[PATCH 05/23] mi: Unexport arc fill implementation details

2014-10-27 Thread Adam Jackson
Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- mi/Makefile.am | 2 +- mi/mifillarc.c | 4 ++-- mi/mifillarc.h | 9 - 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/mi/Makefile.am b/mi/Makefile.am index b243029..4466f69 100644

[PATCH 04/23] mi: Unexport subpixel polygon implementation details

2014-10-27 Thread Adam Jackson
Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- mi/Makefile.am | 2 +- mi/mifpoly.h | 17 - 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/mi/Makefile.am b/mi/Makefile.am index b93a8f9..b243029 100644 ---

[PATCH 08/23] mi: Fold mipoly{con,gen}.c into mipoly.c

2014-10-27 Thread Adam Jackson
Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- mi/Makefile.am | 2 - mi/mi.h| 16 --- mi/mipoly.c| 334 - mi/mipolycon.c | 235

[PATCH 03/23] mi: Unexport span group implementation details

2014-10-27 Thread Adam Jackson
Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- mi/Makefile.am | 2 +- mi/mispans.h | 20 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/mi/Makefile.am b/mi/Makefile.am index 526f4bb..b93a8f9 100644 ---

[PATCH 13/23] fb: Remove even/odd stipple slow-pathing

2014-10-27 Thread Adam Jackson
This is clearly meant to be a fast path, but it appears to be a net loss at this point. If you really wanted to ricer-tune here, note that the inner loop of fbBltOne is a bit too complicated for gcc (at least 4.8.2), it doesn't specialize the loop for the handful of legal values of bitsPerDst,

[PATCH 12/23] fb: FB_SHIFT is 5 (and FB_UNIT is 32)

2014-10-27 Thread Adam Jackson
The other paths don't build or work, PCI and other buses are almost always 32 bit data paths, and X doesn't really support pixels bigger than that anyway. Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- fb/fb.h| 173

[PATCH 14/23] fb: Move fbStipple*Bits near their only consumer

2014-10-27 Thread Adam Jackson
And remove fbStippleTable since gcc can't figure that out itself. Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- fb/fbbltone.c | 113 - fb/fbrop.h | 6 --- fb/fbutil.c| 107

[PATCH 16/23] fb: Remove even/odd tile slow-pathing

2014-10-27 Thread Adam Jackson
Again, clearly meant to be a fast path, but this turns out not to be the case. Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- fb/Makefile.am | 1 - fb/fb.h| 39 -- fb/fbfill.c| 38 ++ fb/fbtile.c| 163

[PATCH 10/23] mi: Fold micursor.c into mipointer.c

2014-10-27 Thread Adam Jackson
Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- mi/Makefile.am | 1 - mi/micursor.c | 68 -- mi/mipointer.c | 14 3 files changed, 14 insertions(+), 69 deletions(-) delete mode

[PATCH 09/23] mi: Fold mipolyutil.c into mipoly.c

2014-10-27 Thread Adam Jackson
Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- mi/Makefile.am | 1 - mi/mipoly.c | 285 +++ mi/mipoly.h | 17 --- mi/mipolyutil.c | 369 4

[PATCH 17/23] fb: Hide glyph implementation details

2014-10-27 Thread Adam Jackson
Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- fb/fb.h| 10 -- fb/fbglyph.c | 4 ++-- fb/fbpict.c| 2 +- fb/fbpict.h| 4 fb/wfbrename.h | 1 - 5 files changed, 3 insertions(+), 18 deletions(-) diff --git a/fb/fb.h

[PATCH 21/23] fb: Hide fbPush{Pattern,Fill}

2014-10-27 Thread Adam Jackson
Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- fb/fb.h | 14 -- fb/fbpush.c | 4 ++-- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/fb/fb.h b/fb/fb.h index f6bceea..ab110f3 100644 --- a/fb/fb.h +++ b/fb/fb.h @@

[PATCH 20/23] fb: Hide fbDots

2014-10-27 Thread Adam Jackson
Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- fb/fb.h | 10 -- fb/fbpoint.c | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/fb/fb.h b/fb/fb.h index a3d5185..f6bceea 100644 --- a/fb/fb.h +++ b/fb/fb.h @@ -1145,16

[PATCH 18/23] fb: Hide some zero-width line details

2014-10-27 Thread Adam Jackson
Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- fb/fb.h| 9 - fb/fbline.c| 4 ++-- fb/wfbrename.h | 2 -- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/fb/fb.h b/fb/fb.h index e567332..23e4c8d 100644 --- a/fb/fb.h

[PATCH 15/23] fb: Remove unused fbReduceRasterOp

2014-10-27 Thread Adam Jackson
Appears to have been cargo-culted in from cfb and then never used. Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- fb/fb.h| 3 --- fb/fbutil.c| 78 -- fb/wfbrename.h | 2 -- 3 files

[PATCH 11/23] fb: Eliminate fbLaneTable, staticize fb{8,16,32}Lane

2014-10-27 Thread Adam Jackson
gcc doesn't appear to be smart enough to fold away the indirection here, even if you make fbLaneTable const. Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- fb/fbbltone.c | 32 +++- fb/wfbrename.h | 5 - 2 files

[PATCH 19/23] fb: Hide Bresenham line details

2014-10-27 Thread Adam Jackson
Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- fb/fb.h| 22 -- fb/fbseg.c | 22 +- 2 files changed, 9 insertions(+), 35 deletions(-) diff --git a/fb/fb.h b/fb/fb.h index 23e4c8d..a3d5185 100644 ---

[PATCH 22/23] dix: Always store GC client clip as a region (v2)

2014-10-27 Thread Adam Jackson
Again, this changes FixesCreateRegionFromGC to throw BadMatch when fed a GC with no client clip. v2: Fix Xnest and some variable names (Keith) Reviewed-by: Keith Packard kei...@keithp.com Signed-off-by: Adam Jackson a...@redhat.com --- dix/gc.c | 3 +-- exa/exa_accel.c

[PATCH 23/23] dix: Retype and repack GC

2014-10-27 Thread Adam Jackson
LP64: 160 bytes before, 128 after. Signed-off-by: Adam Jackson a...@redhat.com --- include/gcstruct.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/gcstruct.h b/include/gcstruct.h index 32e89a1..aa2064c 100644 --- a/include/gcstruct.h +++

Re: [PATCH 2/2] dix: Always store GC client clip as a region

2014-10-27 Thread Keith Packard
Keith Packard kei...@keithp.com writes: The updated version of this patch was part of Adam's 'for-keithp' branch which has just been merged. d181e52..839f053 master - master -- keith.pack...@intel.com pgp7ol7Gobn0c.pgp Description: PGP signature

Re: [PATCH 00/23] mi/fb diet, GC client clip, and GC type fixes

2014-10-27 Thread Keith Packard
Adam Jackson a...@redhat.com writes: Mostly a resend of previous efforts. 23 changes the unsigned longs in the GC to be unsigned int, since that's all the bigger pixels are anyway, and the serial number needn't be 64 bits. This series is also available in my for-keithp branch on

[PULL] modesetting DRI2 support

2014-10-27 Thread Eric Anholt
The following changes since commit 61a292adf45405641de1c522a04c148e0a152acd: glx: check return from __glXGetAnswerBuffer (2014-10-09 15:30:52 +0200) are available in the git repository at: people.freedesktop.org:~anholt/xserver modesetting-dri2-no-pageflip for you to fetch changes up to

Re: [PATCH xfree86] Skip SetCursor when vtSema is FALSE.

2014-10-27 Thread Keith Packard
Adam Jackson a...@nwnk.net writes: On Wed, 2014-10-22 at 12:55 +0530, Yogish Kulkarni wrote: Consider below sequence - 1) Cursor is removed : isUp will be FALSE if HW cursor is set. 2) VT switched away from X : vtSema becomes FALSE. 3) xf86CursorSetCursor is called with non-null CursorPtr :

Re: [PATCH] dri2: Only invalidate our tree upon Pixmap changes

2014-10-27 Thread Keith Packard
Chris Wilson ch...@chris-wilson.co.uk writes: This patch also fixes the regression, so if you are happier with applying the fix here, Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk Tested-by: Chris Wilson ch...@chris-wilson.co.uk -Chris Less work seems like a feature, so I've merged

Re: [PULL] modesetting DRI2 support

2014-10-27 Thread Keith Packard
Eric Anholt e...@anholt.net writes: Eric Anholt ( dri2: Import a copy of Mesa's PCI ID - driver name mappings. dri2: Automatically fill in the driver name if the DDX doesn't provide it. modesetting: Export two functions I want to reuse from DRI2/Present.

Re: [PATCH] Xext/shm: Detach SHM segment after Pixmap is released

2014-10-27 Thread Keith Packard
Adam Jackson a...@nwnk.net writes: On Thu, 2014-10-16 at 16:22 +0100, Chris Wilson wrote: On Thu, Oct 16, 2014 at 02:09:08PM +0100, Chris Wilson wrote: The GPU may still have a reference to the SHM segment which would only be finally released when the Pixmap is destroy. So we can only

Re: [PULL] hw/xwin configure, build and warning fixes

2014-10-27 Thread Keith Packard
Jon TURNEY jon.tur...@dronecode.org.uk writes: Jon TURNEY (13): hw/xwin: Fix compilation with -Werror=return-type hw/xwin: Fix compilation with -Werror=declaration-after-statement hw/xwin: Fix warnings in glx/glshim.c hw/xwin: Fix format warnings with debug printing

Re: [PATCH] os: -displayfd should check ports up to 65535

2014-10-27 Thread Keith Packard
Adam Jackson a...@nwnk.net writes: On Tue, 2014-10-21 at 15:03 +0100, Jon TURNEY wrote: -displayfd should check ports up to 65535 Noticed during https://cygwin.com/ml/cygwin-xfree/2014-07/msg00024.html Signed-off-by: Jon TURNEY jon.tur...@dronecode.org.uk Reviewed-by: Adam Jackson

Re: xf86-input-evdev not working with touch device with MT only axes

2014-10-27 Thread Peter Hutterer
On Mon, Oct 27, 2014 at 11:15:10AM +, Pasrshuram Thombare wrote: I am using xf86-input-evdev(2.8.1) for touch device with MT only axes, but I am getting following error. evdev: found only multitouch-axes. That shouldn't happen. evdev: failed to initialize for absolute axes. I am

Re: [PATCH 33/37] composite: Factor out backing store transition

2014-10-27 Thread Keith Packard
Adam Jackson a...@redhat.com writes: No functional change. Signed-off-by: Adam Jackson a...@redhat.com --- composite/compinit.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/composite/compinit.c b/composite/compinit.c index

Re: [PATCH] fb: Fix Bresenham algorithms for commonly used small segments.

2014-10-27 Thread Keith Packard
Peter Harris phar...@opentext.com writes: On 2014-10-03 17:41, Alex Orange wrote: Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=54168 Fix errors introducted in 863d528a9f76d0e8f122aebf19f8564a4c67a938. Said patch does indeed remove the problematic writes to bad memory, however it

Re: [PATCH 33/37] composite: Factor out backing store transition

2014-10-27 Thread Jasper St. Pierre
No? He removed the brace so it's a one-line if body. On Mon, Oct 27, 2014 at 4:34 PM, Keith Packard kei...@keithp.com wrote: Adam Jackson a...@redhat.com writes: No functional change. Signed-off-by: Adam Jackson a...@redhat.com --- composite/compinit.c | 27

Re: xf86-input-evdev not working with touch device with MT only axes

2014-10-27 Thread Colin Macdonald
On 27/10/14 23:32, Peter Hutterer wrote: it means your kernel driver isn't adhering to the evdev protocol, so you're most likely on android, right? see https://bugs.freedesktop.org/show_bug.cgi?id=80470 I'm sorry Peter, I never improved my patch for this which you kindly review months ago.

Re: [PATCH 33/37] composite: Factor out backing store transition

2014-10-27 Thread Keith Packard
Jasper St. Pierre jstpie...@mecheye.net writes: No? He removed the brace so it's a one-line if body. Thanks, I misread the patch. -- keith.pack...@intel.com pgp9vCgg_psOt.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH 2/2] xkb: Initialize 'bad' Atom in _XkbSetNamesCheck

2014-10-27 Thread Peter Hutterer
On Wed, Oct 22, 2014 at 02:48:38PM -0700, Keith Packard wrote: When _XkbCheckAtoms returns NULL for an error, it always sets the error return code, but GCC can't figure that out, so just initialize the local variable, 'bad', in _XkbSetNamesCheck to eliminate the warning. Signed-off-by: Keith