Re: [PATCH] xfree86: Bump ABI versions (video: 19, extension: 9)

Aaron Plattner aplatt...@nvidia.com writes: Among other things, commit b851ca968b7cce6d1a6438c05d3d5c8832249704 added a NameWindowPixmap function pointer to ScreenRec, shifting some of the fields around. Signed-off-by: Aaron Plattner aplatt...@nvidia.com Reviewed and merged.

Re: [PATCH] xfree86: Bump ABI versions (video: 19, extension: 9)

On 10/30/2014 01:58 PM, Keith Packard wrote: Aaron Plattner aplatt...@nvidia.com writes: Among other things, commit b851ca968b7cce6d1a6438c05d3d5c8832249704 added a NameWindowPixmap function pointer to ScreenRec, shifting some of the fields around. Signed-off-by: Aaron Plattner

Re: [PATCH] xfree86: Bump ABI versions (video: 19, extension: 9)

Aaron Plattner aplatt...@nvidia.com writes: Too bad I only noticed that *after* you merged it... oh well. Not a big deal. There were plenty of ABI changes in this release; I wasn't too worried about making the notes about which changes you noticed correct. -- keith.pack...@intel.com

Re: [PATCH] Fix present_notify to return right away when querying current or past msc.

Keith Packard kei...@keithp.com writes: Axel Davy axel.d...@ens.fr writes: When the target msc is past or is the current one, we want to get immediate feedback. This patch fixes this behaviour. Signed-off-by: Axel Davy axel.d...@ens.fr Reviewed-by: Keith Packard kei...@keithp.com Merged.

Re: [PATCH] xv: Add missing gcstruct.h include

Thierry Reding thierry.red...@gmail.com writes: From: Thierry Reding tred...@nvidia.com Commit ea3f3b0786d5 (xv: Move xf86 XV color key helper to core.) added code that uses internals of struct _GC. This structure is defined in the include/gcstruct.h header which wasn't included by the

[PATCH 1/9] include: fix compiler warning about casting int to uint16_t

/usr/include/xorg/misc.h:141:30: warning: implicit conversion loses integer precision: 'int' to 'uint16_t' (aka 'unsigned short') [-Wconversion] return ((x 0xff) 8) | ((x 8) 0xff); ~~ ~~^~~ Function sig is a uint16_t, so just force the cast.

[PATCH 3/9] include: change RegionSize() to take a size_t

/usr/include/xorg/regionstr.h:130:36: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion] return (sizeof(RegDataRec) + ((n) * sizeof(BoxRec))); ^ ~ Really only just pushes the problem to the caller, but maybe that

[PATCH 4/9] Xext: fix clang compiler warning

shm.c:1150:24: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((shmdesc-addr == ((char *) -1))) { Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Xext/shm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Xext/shm.c

[PATCH 7/9] dix: silence compiler warning

inpututils.c:243:26: warning: comparison of constant 256 with expression of type 'KeyCode' (aka 'unsigned char') is always false [-Wtautological-constant-out-of-range-compare] if (modkeymap[i] = MAP_LENGTH) ^ ~~ MAP_LENGTH depends on MAX_BUTTONS

[PATCH 2/9] include: fix documentation for list.h

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- include/list.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/list.h b/include/list.h index 455c670..9154e1c 100644 --- a/include/list.h +++ b/include/list.h @@ -117,7 +117,7 @@ struct xorg_list { * Example:

[PATCH 5/9] xfree86: drop double-typedef of DBusConnection

Just include dbus.h, it's been typedef'd there since 2003. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/common/Makefile.am | 4 include/dbus-core.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/common/Makefile.am

[PATCH 6/9] xwayland: declare fatal log handler as noreturn

xwayland.c:661:1: warning: function 'xwl_log_handler' could be declared with attribute 'noreturn' [-Wmissing-noreturn] Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xwayland/xwayland.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/xwayland/xwayland.c

[PATCH 0/9] Couple of compiler warning fixes

A couple of compiler warning fixes, like most warning fixes attempts I got demotivated quickly, so this is nowhere near the lot. Some of these affect the server build (with clang), others like the first 3 affect drivers simply because they headers are included through a couple of subheaders.

[PATCH 8/9] dix: silence compiler warning comparing CARD32 to -1

window.c:3246:36: warning: comparison of constant -1 with expression of type 'CARD32' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare] if (optional-backingBitPlanes != ~0L) ~~ ^ ~~~ Signed-off-by: Peter Hutterer

Re: [PATCH 8/9] dix: silence compiler warning comparing CARD32 to -1

On 31.10.2014 08:52, Peter Hutterer wrote: window.c:3246:36: warning: comparison of constant -1 with expression of type 'CARD32' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare] if (optional-backingBitPlanes != ~0L) ~~ ^

[PATCH v2] include: fix documentation for list.h

Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- include/list.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/list.h b/include/list.h index 455c670..39f1985 100644 --- a/include/list.h +++ b/include/list.h @@ -117,7 +117,7 @@ struct xorg_list { * Example:

[PATCH v2] dix: silence compiler warning comparing CARD32 to -1

window.c:3246:36: warning: comparison of constant -1 with expression of type 'CARD32' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare] if (optional-backingBitPlanes != ~0L) ~~ ^ ~~~ Signed-off-by: Peter Hutterer

Re: [PATCH v2] include: fix documentation for list.h

On 10/30/14 09:07 PM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- include/list.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/list.h b/include/list.h index 455c670..39f1985 100644 --- a/include/list.h +++ b/include/list.h @@