[PATCH] Fix overflow of ConnectionOutput-size and -count

When (long) is larger than (int), and when realloc succeeds with sizes larger than INT_MAX, ConnectionOutput-size and ConnectionOutput-count overflow and become negative. When ConnectionOutput-count is negative, InsertIOV does not actually insert an IOV, and FlushClient goes into an infinite loop

[PATCH] render: fix ChangePicture when Xinerama is active (#49170)

ChangePicture takes wire XIDs, but didn't do any Xinerama translation, which meant setting a clip pixmap or a separate alpha picture would result in those elements pointing at the instance of the pixmap on screen 0. Which is, you know, bad. Bugzilla:

[PATCH] render: fix ChangePicture when Xinerama is active (v2) (#49170)

ChangePicture takes wire XIDs, but didn't do any Xinerama translation, which meant setting a clip pixmap or a separate alpha picture would result in those elements pointing at the instance of the pixmap on screen 0. Which is, you know, bad. v2: This one actually builds. Bugzilla:

[PATCH 8/8] composite: Implement backing store's Always mode

Keep the pixmap at unmap, always try to realize backing store, always mark them when marking, and update paintable when backed. Signed-off-by: Adam Jackson a...@redhat.com --- composite/compalloc.c | 2 +- composite/compinit.c | 24 ++-- composite/compint.h| 8 +++

[PATCH 5/8] dix: Update window state based on paintable not viewable

Signed-off-by: Adam Jackson a...@redhat.com --- dix/window.c | 69 1 file changed, 32 insertions(+), 37 deletions(-) diff --git a/dix/window.c b/dix/window.c index 431566d..a82c294 100644 --- a/dix/window.c +++ b/dix/window.c @@

[PATCH 7/8] composite: Factor out backing store transition

No functional change. Signed-off-by: Adam Jackson a...@redhat.com --- composite/compinit.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/composite/compinit.c b/composite/compinit.c index 10433a1..09d58a0 100644 --- a/composite/compinit.c +++

[PATCH 3/8] mi: Mark/validate based on paintable not viewable

Signed-off-by: Adam Jackson a...@redhat.com --- mi/miwindow.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/mi/miwindow.c b/mi/miwindow.c index 0cf5046..0b4b055 100644 --- a/mi/miwindow.c +++ b/mi/miwindow.c @@ -151,7 +151,7 @@

[PATCH 2/8] mi: miValidateTree based on paintable not viewable

Signed-off-by: Adam Jackson a...@redhat.com --- mi/mivaltree.c | 110 +++-- 1 file changed, 59 insertions(+), 51 deletions(-) diff --git a/mi/mivaltree.c b/mi/mivaltree.c index 8e4e9a9..024af18 100644 --- a/mi/mivaltree.c +++ b/mi/mivaltree.c

[PATCH 1/8] dix: Add 'paintable' bit to the window state (v2)

A paintable window is a window whose pixels are (potentially) modifiable by rendering commands. Right now that just means the same thing as viewable; it will soon also include unmapped windows with backing store set to Always. v2: Set paintable in dix not ddx (Keith Packard) Signed-off-by: Adam

[PATCH 0/8] Implement backing store's Always mode (v2)

This is juggled around a bit from the previous series. I've not made any real attempt to annotate the patches for what changed, sorry. This is still unfinished, but it's closer than before. Composite now handles exposure suppression itself instead of hacking it into mi. I took Keith's advice

[PATCH 4/8] mi: Shortcut miDoCopy/miCopyArea based on paintable not realized

Signed-off-by: Adam Jackson a...@redhat.com --- mi/mibitblt.c | 4 ++-- mi/micopy.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mi/mibitblt.c b/mi/mibitblt.c index 114f72d..e2a5f3d 100644 --- a/mi/mibitblt.c +++ b/mi/mibitblt.c @@ -96,9 +96,9 @@ miCopyArea(DrawablePtr

[PATCH 6/8] dix: Switch window unmap to mark normally instead of UnmapValData

--- dix/window.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dix/window.c b/dix/window.c index a82c294..af63703 100644 --- a/dix/window.c +++ b/dix/window.c @@ -2748,7 +2748,7 @@ UnmapWindow(WindowPtr pWin, Bool fromConfigure) if (SubStrSend(pWin, pParent))

Re: [PATCH 4/4] modesetting: Add support for rendering using glamor.

Ping? If there's no intention to fix this before 1.17, this commit should probably be reverted. Thanks, Thomas On 11/12/2014 09:38 AM, Thomas Hellstrom wrote: Hi! On 10/08/2014 10:58 AM, Eric Anholt wrote: By default modesetting now tries to enable X acceleration using glamor, but falls

Re: [PATCH 6/8] dix: Switch window unmap to mark normally instead of UnmapValData

On 2014-11-17 15:41, Adam Jackson wrote: diff --git a/dix/window.c b/dix/window.c index a82c294..af63703 100644 --- a/dix/window.c +++ b/dix/window.c @@ -2748,7 +2748,7 @@ UnmapWindow(WindowPtr pWin, Bool fromConfigure) if (SubStrSend(pWin, pParent)) DeliverUnmapNotify(pWin,

Re: [PATCH 4/4] modesetting: Add support for rendering using glamor.

Thomas Hellstrom thellst...@vmware.com writes: Ping? If there's no intention to fix this before 1.17, this commit should probably be reverted. I'm hoping to see Eric (or someone else) get this fixed before the bug fix window closes at the end of this month. But, yes, it's not workable as it