Re: [PATCH xf86-input-libinput] Support server-side fds

2014-12-08 Thread Hans de Goede
Hi, On 07-12-14 23:42, Peter Hutterer wrote: On Fri, Dec 05, 2014 at 02:21:15PM +0100, Hans de Goede wrote: Hi Peter, Thanks for working on this! On 12/02/2014 06:01 AM, Peter Hutterer wrote: libinput's device handling and server-side fd handling are a bit of a mismatch, so this is hackier

Re: [PATCH xf86-input-libinput] Support server-side fds

2014-12-08 Thread Peter Hutterer
On Mon, Dec 08, 2014 at 09:32:00AM +0100, Hans de Goede wrote: Hi, On 07-12-14 23:42, Peter Hutterer wrote: On Fri, Dec 05, 2014 at 02:21:15PM +0100, Hans de Goede wrote: Hi Peter, Thanks for working on this! On 12/02/2014 06:01 AM, Peter Hutterer wrote: libinput's device handling and

Re: [PATCH 8/8] modesetting: Add output hotplug support

2014-12-08 Thread Daniel Martin
On 5 December 2014 at 17:45, Keith Packard kei...@keithp.com wrote: Daniel Martin daniel.mar...@secunet.com writes: From: Daniel Martin consume.no...@gmail.com When receiving a hotplug uevent, check if we have to add or remove outputs and act accordingly. Signed-off-by: Daniel Martin

[PATCH 2/9] modesetting: Move Bool glamor into drmmode struct

2014-12-08 Thread Daniel Martin
From: Daniel Martin consume.no...@gmail.com Move the boolean glamor from struct modesetting into struct drmmode for later re-use in drmmode_display. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed-by: Eric Anholt e...@anholt.net Reviewed-and-tested-by: Kenneth Graunke

[PATCH v2 8/9] modesetting: Add output hotplug support

2014-12-08 Thread Daniel Martin
From: Daniel Martin consume.no...@gmail.com When receiving a hotplug uevent, check if we have to add or remove outputs. v2: Move log message in drmmode_output_add() below 'if (!output)' to prevent possible NULL dereference. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed-by:

[PATCH v2 6/9] modesetting: Only handle hotplug uevent when vtSema

2014-12-08 Thread Daniel Martin
From: Daniel Martin consume.no...@gmail.com If the uevent isn't a hotplug event, ignore it, and if !vtSema postpone the reprobing until EnterVT(). v2: Replace 'flags' member and enum with Bool 'need_reprobe'. Signed-off-by: Daniel Martin consume.no...@gmail.com ---

[v2] Modesetting - crash, boom, bang

2014-12-08 Thread Daniel Martin
Hi, this is the second version of my patches to add hotplug output support into the modesetting driver. Few changes have been made: - added R-b tags (Eric Anholt and Kenneth Graunke) to patch 1-5 [PATCH 1/9] config/udev: Prefix and shift removing GPU message [PATCH 2/9] modesetting: Move

[PATCH 3/9] modesetting: Create new EGL screen in drmmode_xf86crtc_resize

2014-12-08 Thread Daniel Martin
From: Daniel Martin consume.no...@gmail.com If we don't glamor_egl_create_textured_screen_ext() in drmmode_xf86crtc_resize() we end up with a black screen and no client windows visible. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed-by: Eric Anholt e...@anholt.net

[PATCH 1/9] config/udev: Prefix and shift removing GPU message

2014-12-08 Thread Daniel Martin
From: Daniel Martin consume.no...@gmail.com The message removing GPU device ... appeared even if the removal was skipped (when path == NULL). Move it below the path check and make it a LogMessage with config/udev prefix. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed-by: Eric

[PATCH 4/9] modesetting: Fix ifdefs s/HAVE_UDEV/CONFIG_UDEV_KMS/

2014-12-08 Thread Daniel Martin
From: Daniel Martin consume.no...@gmail.com We don't define HAVE_UDEV, that's a remnant from xf86-video-modesetting. But, we have CONFIG_UDEV_KMS. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed-by: Eric Anholt e...@anholt.net Reviewed-and-tested-by: Kenneth Graunke

[PATCH 5/9] modesetting: Remove unused params from drmmode_output_init()

2014-12-08 Thread Daniel Martin
From: Daniel Martin consume.no...@gmail.com drmmode_output_init() doesn't touch (the int*) num_dvi and num_hdmi. Remove both parameters. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed-by: Eric Anholt e...@anholt.net Reviewed-and-tested-by: Kenneth Graunke kenn...@whitecape.org ---

[PATCH 9/9] modesetting: XXX - Only track connected outputs

2014-12-08 Thread Daniel Martin
This patch is not meant to be merged. Its purpose is to be able to test the output hotplug handling on maschines that don't hotplug outputs. With this patch an output will be added or removed depending on its connector state (connected? - add, otherwise - remove or ignore). ---

[PATCH 7/9] modesetting: Return the output created in drmmode_output_init()

2014-12-08 Thread Daniel Martin
From: Daniel Martin consume.no...@gmail.com So, we can re-use the function for output hotplugging later. Signed-off-by: Daniel Martin consume.no...@gmail.com Reviewed-by: Keith Packard kei...@keithp.com --- hw/xfree86/drivers/modesetting/drmmode_display.c | 9 + 1 file changed, 5

Weird glamor screen pixmap API

2014-12-08 Thread Keith Packard
Looking at Daniel's patches to fix screen resize in the modesetting driver, I've come across an oddity in the glamor API which deserves some exploration. glamor_egl_create_textured_screen_ext has this weird extra 'back_pixmap' argument. What the heck does it do? Let's see... In the glamor egl

[PATCH 1/3] glamor: Always destroy EGL image associated with destroyed pixmap

2014-12-08 Thread Keith Packard
There were three paths that called eglDestroyImageKHR: * The front buffer * The intel driver's flip buffer * pixmaps under DRI3 This patch unifies the second two by having glamor_destroy_pixmap always destroy any associaged EGL image. This allows us to stop storing the back_pixmap pointer in

[PATCH 0/3] Free EGL images in glamor as needed

2014-12-08 Thread Keith Packard
Here are the three patches I mentioned which take care of destroying the EGL image structure when freeing pixmaps and when assigning a new image to a pixmap which already has one. The second patch is a 'clean up' which removes a redundant reference to the screen EGL image -- it's already

[PATCH 3/3] glamor: Free existing EGL image when assigning new one

2014-12-08 Thread Keith Packard
When reallocating the framebuffer on screen resize, the old EGL image was getting leaked. Check for an existing EGL image and free it in this case. Signed-off-by: Keith Packard kei...@keithp.com --- glamor/glamor_egl.c | 28 +--- 1 file changed, 21 insertions(+), 7

[PATCH 2/3] glamor: Remove redundant reference to screen pixmap EGL image

2014-12-08 Thread Keith Packard
There's no reason to store this in the egl screen private as the screen pixmap will always hold a reference to it anyways. Signed-off-by: Keith Packard kei...@keithp.com --- glamor/glamor_egl.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/glamor/glamor_egl.c

Re: Modesetting - crash, boom, bang

2014-12-08 Thread Keith Packard
Eric Anholt e...@anholt.net writes: Patches 1-5 are: Reviewed-by: Eric Anholt e...@anholt.net Merged. 4b0d0df..32ca85c master - master I think the repeated create_textured_screen_ext()s are leaking an EGL image, but that's a fix in glamor_egl.c we should do independently. I've posted

Re: [PATCH 2/2] present: Fix use of vsynced pageflips and honor PresentOptionAsync. (v4)

2014-12-08 Thread Keith Packard
Mario Kleiner mario.kleiner...@gmail.com writes: Pageflips for Pixmap presents were not synchronized to vblank on drivers with support for PresentCapabilityAsync, due to some missing init for vblank-sync_flips. The PresentOptionAsync flag was completely ignored for pageflipped presents.

Re: [PULL] hw/xwin clipboard fixes

2014-12-08 Thread Keith Packard
Jon TURNEY jon.tur...@dronecode.org.uk writes: Colin Harrison (1): hw/xwin: Don't allocate one wchar_t too much for unicode text placed on the Windows clipboard Jon TURNEY (8): hw/xwin: Remove some redundant clipboard externs, now defined in winglobals.h hw/xwin: In

Re: [PULL] GLX fixes for indirect contexts

2014-12-08 Thread Keith Packard
Jon TURNEY jon.tur...@dronecode.org.uk writes: Jon TURNEY (3): Revert glx: Simplify glXDestroyContext glx: Flush context which is being made non-current due to drawable going away glx: Fix crash when a client exits without deleting GL contexts Merged.

Re: [PATCH 8/8] modesetting: Add output hotplug support

2014-12-08 Thread Aaron Plattner
On 12/08/2014 01:01 AM, Daniel Martin wrote: On 5 December 2014 at 17:45, Keith Packard kei...@keithp.com wrote: Daniel Martin daniel.mar...@secunet.com writes: From: Daniel Martin consume.no...@gmail.com When receiving a hotplug uevent, check if we have to add or remove outputs and act