Re: [PATCH] Synchronize capslock in Xnest and Xephyr

2015-01-05 Thread Peter Hutterer
On Mon, Jan 05, 2015 at 04:44:22PM +0100, Olivier Fourdan wrote: In Xnest or Xephyr, pressing CapsLock when focus is on another window does not update the state in the nested X server. This is because when synchronizing the lock modifier, sending a keypress or a key release only is not

Re: 1.17 status and schedule

2015-01-05 Thread Keith Packard
Aaron Plattner aplatt...@nvidia.com writes: I mentioned it on IRC but I should probably say it here too for the record: I don't think this should go into 1.17. It's a big enough change in behavior that some soak time on master is probably warranted. We can always backport it to

Re: [PATCH:libXxf86vm] Discard correct length for old-format replies in XF86VidModeGetGamma

2015-01-05 Thread Alan Coopersmith
Ignore this - this version isn't quite right either, since it doesn't switch between the two reply sizes. -alan- On 01/ 5/15 11:42 PM, Alan Coopersmith wrote: Regression introduced in libXxf86vm 1.1.3 / commit 284a88e21fc05a63466 Unlikely to be hit in practice since it requires

Re: 1.17 status and schedule

2015-01-05 Thread Aaron Plattner
On 01/04/2015 05:35 PM, Keith Packard wrote: Ok, it's (almost) the first working day of the year, and we're supposed to be shipping 1.17. I think we're quite close, but I want to make sure everyone is ready for the release before it happens. From my list of pending patches, we've got: glamor:

[PATCH:libXxf86vm] Discard correct length for old-format replies in XF86VidModeGetGamma

2015-01-05 Thread Alan Coopersmith
Regression introduced in libXxf86vm 1.1.3 / commit 284a88e21fc05a63466 Unlikely to be hit in practice since it requires out-of-range privsize or malloc failure while talking to a server using the XFree86 3.x version of the protocol. Found by Oracle Parfait 1.5.1: Error: Uninitialised memory (CWE

Re: [PATCH:transset] Only use property pointer if XGetWindowProperty returns success

2015-01-05 Thread Hans de Goede
Hi, On 03-01-15 23:29, Alan Coopersmith wrote: In Xlib versions prior to 1.6, if XGetWindowProperty returns a failure, it didn't always set the property pointer to NULL, and could leave it uninitialized. Reported by Oracle Parfait 1.5.1: Error: Uninitialised memory (CWE 456) Possible

Re: [PATCH:xcmsdb] Only use results from GetWindowProperty if it returned Success

2015-01-05 Thread Hans de Goede
Hi, On 04-01-15 00:00, Alan Coopersmith wrote: Since Xlib prior to 1.6 didn't always clear values on failure, don't assume they're safe to use unless we succeeded. Reported by Oracle Parfait 1.5.1: Error: Uninitialised memory Uninitialised memory variable (CWE 457): Possible access to

Re: [PATCH:xsetroot] Only use results from GetWindowProperty if it returned success

2015-01-05 Thread Hans de Goede
Hi, On 03-01-15 23:30, Alan Coopersmith wrote: Since Xlib prior to 1.6 didn't always clear values on failure, don't assume they're safe to use unless we succeeded. Reported by Oracle Parfait 1.5.1: Error: Uninitialised memory (CWE 456) Possible access to uninitialised memory 'after'

Re: [PATCH 0/2] Fix GPU screen handling for drivers with no normal screens

2015-01-05 Thread Alex Deucher
On Tue, Dec 30, 2014 at 12:13 PM, Aaron Plattner aplatt...@nvidia.com wrote: I noticed the problem fixed by the first patch while debugging a problem with the Intel driver in a system using Prime. See that patch for a description of what is going wrong there. Unfortunately, Prime

[PATCH] dix: make RegionInit legal C++

2015-01-05 Thread Adam Jackson
The CVE fix in: commit 97015a07b9e15d8ec5608b95d95ec0eb51202acb Author: Alan Coopersmith alan.coopersm...@oracle.com Date: Wed Jan 22 22:37:15 2014 -0800 dix: integer overflow in RegionSizeof() [CVE-2014-8092 3/4] offended the C++ demons: ../../include/regionstr.h:147:45:

Re: [PATCH] dix: make RegionInit legal C++

2015-01-05 Thread Alan Coopersmith
Same code as http://patchwork.freedesktop.org/patch/39718/ but different comments. My r-b from http://lists.x.org/archives/xorg-devel/2015-January/045096.html applies to either set of comments. -alan- On 01/ 5/15 01:48 PM, Adam Jackson wrote: The CVE fix in: commit

Re: [PATCH] doc: Create a script to filter xmlto output

2015-01-05 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: Signed-off-by: Keith Packard kei...@keithp.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Merged. 1c01633..23a11fd master - master -- -keith signature.asc Description: PGP signature

Re: [PATCH] mi: fix accidental x/y coordinate swap

2015-01-05 Thread Keith Packard
Peter Hutterer peter.hutte...@who-t.net writes: On Mon, Jan 05, 2015 at 12:54:28PM -0800, Eric Anholt wrote: Peter Hutterer peter.hutte...@who-t.net writes: Reported-by: Adam Greenblatt adam.greenbl...@gmail.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Seems pretty

Re: 1.17 status and schedule

2015-01-05 Thread Keith Packard
Alan Coopersmith alan.coopersm...@oracle.com writes: Is the change discussed on IRC to change the default from --disable-glamor to enabling if PKG_CHECK_MODULES(epoxy) slated for 1.18 as well, since it's a bit late to change for 1.17? Yes, I think changing the default build can wait; anyone

Re: [PATCH:intel-gpu-tools 1/7] Fix #ifdef check for _SC_AVPHYS_PAGES in intel_get_avail_ram_mb()

2015-01-05 Thread Alan Coopersmith
On 01/ 5/15 08:11 AM, Daniel Vetter wrote: On Tue, Dec 23, 2014 at 07:07:08PM -0800, Alan Coopersmith wrote: Check for the sysconf value used here, not the one used in the previous function. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Thanks for the patches, all merged.

Re: [PATCH] dix: make RegionInit legal C++

2015-01-05 Thread Adam Jackson
On Mon, 2015-01-05 at 13:54 -0800, Alan Coopersmith wrote: Same code as http://patchwork.freedesktop.org/patch/39718/ but different comments. My r-b from http://lists.x.org/archives/xorg-devel/2015-January/045096.html applies to either set of comments. Tsk, that's what I get for not catching

Re: 1.17 status and schedule

2015-01-05 Thread Peter Hutterer
On Sun, Jan 04, 2015 at 05:35:31PM -0800, Keith Packard wrote: Ok, it's (almost) the first working day of the year, and we're supposed to be shipping 1.17. I think we're quite close, but I want to make sure everyone is ready for the release before it happens. From my list of pending

Re: [PATCH] doc: Create a script to filter xmlto output

2015-01-05 Thread Peter Hutterer
On Sun, Jan 04, 2015 at 10:11:46PM -0800, Keith Packard wrote: Peter Hutterer peter.hutte...@who-t.net writes: not 100% sure but should this use $(SHELL)? Yes. also, you probably need to add this to EXTRA_DIST And, I should add a '.sh' extension, to be consistent. other than

[PATCH] modesetting: Copy over VRefresh to/from KMS modes

2015-01-05 Thread Jasper St. Pierre
The kernel might want this information during modesetting. --- hw/xfree86/drivers/modesetting/drmmode_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c b/hw/xfree86/drivers/modesetting/drmmode_display.c index 824500b..27b7fd8 100644

Re: [PATCH] glamor: Don't unbind the GL_ARRAY_BUFFER in glamor_put_vbo_space().

2015-01-05 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: Kenneth Graunke kenn...@whitecape.org writes: That's true. I should probably just resurrect your Xephyr VAO patch, and extend it for the rest of Glamor as well. Yeah, would be good as that's required for 3.0 core context support. Note that most of

Re: 1.17 status and schedule

2015-01-05 Thread Eric Anholt
Keith Packard kei...@keithp.com writes: Ok, it's (almost) the first working day of the year, and we're supposed to be shipping 1.17. I think we're quite close, but I want to make sure everyone is ready for the release before it happens. From my list of pending patches, we've got: glamor:

[PATCH] Synchronize capslock in Xnest and Xephyr

2015-01-05 Thread Olivier Fourdan
In Xnest or Xephyr, pressing CapsLock when focus is on another window does not update the state in the nested X server. This is because when synchronizing the lock modifier, sending a keypress or a key release only is not sufficient to toggle the state, unlike regular modifiers, one has to

Re: [PATCH] mi: fix accidental x/y coordinate swap

2015-01-05 Thread Eric Anholt
Peter Hutterer peter.hutte...@who-t.net writes: Reported-by: Adam Greenblatt adam.greenbl...@gmail.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Seems pretty obvious. Reviewed-by: Eric Anholt e...@anholt.net signature.asc Description: PGP signature

Re: 1.17 status and schedule

2015-01-05 Thread Alan Coopersmith
On 01/ 4/15 05:35 PM, Keith Packard wrote: Ok, it's (almost) the first working day of the year, and we're supposed to be shipping 1.17. I think we're quite close, but I want to make sure everyone is ready for the release before it happens. From my list of pending patches, we've got: glamor:

Re: [PATCH] mi: fix accidental x/y coordinate swap

2015-01-05 Thread Peter Hutterer
On Mon, Jan 05, 2015 at 12:54:28PM -0800, Eric Anholt wrote: Peter Hutterer peter.hutte...@who-t.net writes: Reported-by: Adam Greenblatt adam.greenbl...@gmail.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Seems pretty obvious. Reviewed-by: Eric Anholt e...@anholt.net