Re: glamor regression caused by 9c679d06 (Re: xserver: Branch 'master' - 5 commits)

2015-07-01 Thread Michel Dänzer
On 01.07.2015 07:09, Eric Anholt wrote: Michel Dänzer mic...@daenzer.net writes: On 30.06.2015 13:02, Keith Packard wrote: commit 9c679d06055cc62aa9209318705e87dc33fba4c8 Author: Eric Anholt e...@anholt.net Date: Sun May 31 16:07:01 2015 -0700 glamor: Skip actual FBO setup in our

[PATCH] xserver: fix build with glamor disabled.

2015-07-01 Thread Dave Airlie
This fixes modesetting when glamor is disabled. Signed-off-by: Dave Airlie airl...@redhat.com --- hw/xfree86/drivers/modesetting/driver.c | 4 hw/xfree86/drivers/modesetting/drmmode_display.c | 3 ++- hw/xfree86/drivers/modesetting/present.c | 2 +- 3 files changed, 7

Re: [PATCH 1/7] glamor: Drop a redundant check.

2015-07-01 Thread Alex Deucher
On Tue, Jun 30, 2015 at 6:58 PM, Eric Anholt e...@anholt.net wrote: Above, we've already checked for -fbo -fbo-fb and returned. Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- glamor/glamor_pixmap.c | 3 +-- 1 file changed, 1

Re: [PATCH 7/7] glamor: Use ARRAY_SIZE in a couple more places for consistency.

2015-07-01 Thread Alex Deucher
On Tue, Jun 30, 2015 at 6:58 PM, Eric Anholt e...@anholt.net wrote: Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- glamor/glamor_program.c | 6 ++ glamor/glamor_render.c | 5 + 2 files changed, 3 insertions(+), 8 deletions(-)

Re: [PATCH 5/7] glamor: Make a bunch of single-file glamor functions static.

2015-07-01 Thread Alex Deucher
On Tue, Jun 30, 2015 at 6:58 PM, Eric Anholt e...@anholt.net wrote: Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- glamor/glamor_largepixmap.c | 10 +++--- glamor/glamor_priv.h| 22 --

Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

2015-07-01 Thread Jon TURNEY
On 30/06/2015 15:12, Ray Strode wrote: This is a build fix for MinGW ... Move the check if NO_LOCAL_CLIENT_CRED should be defined to before it's first use. Well, Alan wondered if anyone is actually using NO_LOCAL_CLIENT_CRED, now we know! Patch doesn't look wrong to me, but I wonder if

Re: [PATCH 2/7] glamor: Fix up some weird formatting in _glamor_create_fbo_array().

2015-07-01 Thread Alex Deucher
On Tue, Jun 30, 2015 at 6:58 PM, Eric Anholt e...@anholt.net wrote: Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- glamor/glamor_fbo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/glamor/glamor_fbo.c

Re: [PATCH 4/7] glamor: Drop dead glamor_es2_pixmap_read_prepare().

2015-07-01 Thread Alex Deucher
On Tue, Jun 30, 2015 at 6:58 PM, Eric Anholt e...@anholt.net wrote: It's been unused since I killed glamor_download_pixmap_to_cpu(). Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Alex Deucher alexander.deuc...@amd.com --- glamor/glamor_pixmap.c | 70

Re: [PATCH 3/7] glamor: Restore the hook to glamor_composite_rectangles().

2015-07-01 Thread Alex Deucher
On Tue, Jun 30, 2015 at 6:58 PM, Eric Anholt e...@anholt.net wrote: It was apparently accidentally dropped in keithp's removal of _nf functions in 90d326fcc687e6d6d4b308f6272ededcf8145a17. Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Alex Deucher alexander.deuc...@amd.com ---

Re: [PATCH] prime: add rotation support for offloaded outputs (v2)

2015-07-01 Thread Alex Deucher
On Tue, Jun 30, 2015 at 12:54 AM, Dave Airlie airl...@gmail.com wrote: One of the lacking features with output offloading was that screen rotation didn't work at all. This patch makes 0/90/180/270 rotation work with USB output and GPU outputs. When it allocates the shared pixmap it

Re: [PATCH 6/7] glamor: Mark a bunch of single-file data static.

2015-07-01 Thread Alex Deucher
On Tue, Jun 30, 2015 at 6:58 PM, Eric Anholt e...@anholt.net wrote: This gives the compiler a chance to optimize when the data is never changed -- for example, with pict_format_combine_tab, the compiler ends up inlining the 24 bytes of data into just 10 more bytes of code. Signed-off-by: Eric

Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

2015-07-01 Thread Ray Strode
Hi, Yes, I think so. Revised patch attached. I've tested this a few ways and it seems to be working correctly, but it's hard for me to be sure that this is doing the correct thing on all targets. Thanks for working on this! Seems right to me. My only comment is I think have_so_peercred

[PATCH v5 04/10] kdrive: introduce input hot-plugging support for udev and hal backends (#33140)

2015-07-01 Thread Laércio de Sousa
This patch introduces input hot-plugging support for kdrive-based applications in multi-seat context. This feature is enabled by passing -seat option with desired seat name. All keyboard/mouse devices assigned to that seat will be automatically grabbed by kdrive. It supports udev and hal backends

Re: [PATCH Xproto] Increase the number of file descriptors

2015-07-01 Thread Adam Jackson
On Wed, 2015-06-03 at 22:34 -0700, Alan Coopersmith wrote: On 05/29/15 09:16 AM, Olivier Fourdan wrote: To allow up to 512 clients, the number of file descriptors being monitored need to be increased accordingly. Signed-off-by: Adam Jackson a...@redhat.com Signed-off-by: Olivier

Re: [PATCH] MGA DDX: default to use EXA if XAA is unavailable

2015-07-01 Thread Adam Jackson
On Sun, 2015-06-21 at 19:55 +0200, Matthew Rezny wrote: The MGA DDX still defaults to XAA because the EXA support is buggy on some hardware. Unfortunately, XAA support is gone from newer versions of the xserver. If only EXA is present, that is usually better than no accel, so use it by

Re: [PATCH] MGA DDX: make it possible to find EXA support

2015-07-01 Thread Adam Jackson
On Sun, 2015-06-21 at 19:50 +0200, Matthew Rezny wrote: Newer versions of the xserver stricter requirements on header order which caused the configure tests for EXA support to erroneously fail. Since XAA was already removed from an earlier version of xserver, the configure failure meant

Re: [PATCH v3] configurable maximum number of clients

2015-07-01 Thread Adam Jackson
On Wed, 2015-06-03 at 16:46 +0200, Olivier Fourdan wrote: Make the maximum number of clients user configurable, either from the command line or from xorg.conf Reviewed-by: Adam Jackson a...@redhat.com - ajax ___ xorg-devel@lists.x.org: X.Org

Re: [xrandr 2/2] Mark all CRTC as currently unused for second picking CRTC pass

2015-07-01 Thread Adam Jackson
On Thu, 2015-06-18 at 08:27 +0100, Chris Wilson wrote: We perform two passes over the CRTC in order to find the preferred CRTC for each enabled output. In the first pass, we try to preserve the existing output - CRTC relationships (to avoid unnecessary flicker). If that pass fails, we try

Re: RRModeCreate: also free mode in error case.

2015-07-01 Thread Adam Jackson
On Sun, 2015-06-14 at 23:20 +0200, Mihai Moldovan wrote: This is a follow-up to c7b7abfaa068042e396d19538215402cfbb4f1e4. The patch is wrong: diff --git a/randr/rrmode.c b/randr/rrmode.c index a7aa433..ef90a46 100644 --- a/randr/rrmode.c +++ b/randr/rrmode.c @@ -90,6 +90,7 @@

[PATCH 1/2] glamor: Fix bad rendering of glyphs after an a1 glyph upload.

2015-07-01 Thread Eric Anholt
Fixes regressions since my don't make an FBO for the glyph atlas change. The a1 upload was a fallback, as I expected. However, fallback reads use glReadPixels() because there's no glGetTexSubImage2D() to match glTexSubImage2D(). We were just binding the 0 FBO value, so the glReadPixels() would

[PATCH 2/2] glamor: Add an assert to catch the previous bug.

2015-07-01 Thread Eric Anholt
Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_transfer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/glamor/glamor_transfer.c b/glamor/glamor_transfer.c index aa5e861..155d7e0 100644 --- a/glamor/glamor_transfer.c +++ b/glamor/glamor_transfer.c @@ -186,6 +186,8 @@

[PATCH] glamor: Use GL_ARB_debug_output to log GL errors.

2015-07-01 Thread Eric Anholt
This should help people debugging when glamor does something stupid on their driver. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 41 + 1 file changed, 41 insertions(+) diff --git a/glamor/glamor.c b/glamor/glamor.c index

Re: [PATCH] xorg.modules: Drop external glamor.

2015-07-01 Thread Adam Jackson
On Wed, 2015-07-01 at 17:22 -0700, Eric Anholt wrote: It's been replaced by in-server glamor for a while. Signed-off-by: Eric Anholt e...@anholt.net Merged: 3239e1d..b8aac01 master - master - ajax ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH] glamor: Use GL_ARB_debug_output to log GL errors.

2015-07-01 Thread Michel Dänzer
On 02.07.2015 09:43, Eric Anholt wrote: This should help people debugging when glamor does something stupid on their driver. Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Michel Dänzer michel.daen...@amd.com -- Earthling Michel Dänzer |