Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

Jon TURNEY jon.tur...@dronecode.org.uk writes: Please consider picking a version you like and applying it, or let me know how I can make this patch acceptable. I'll just apply your original patch and mark it as reviewed-by me. -- -keith signature.asc Description: PGP signature

Re: [PATCH 4/4] glamor: Drop a bunch of glamor_priv == NULL checks.

Keith Packard kei...@keithp.com writes: Eric Anholt e...@anholt.net writes: Now that it's always non-null when the pixmap is non-null, we don't need so much of this. glamor_get_pixmap_private() itself still accepts a NULL pixmap and returns NULL, because of glamor_render.c Might want to

Re: [PATCH 2/4] glamor: Drop dead glamor_is_large_picture().

Eric Anholt e...@anholt.net writes: It died as of keithp's new glyphs code. Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org:

Re: [PATCH 1/4] glamor: Reuse the glamor_is_memory helper.

Eric Anholt e...@anholt.net writes: Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Keith Packard kei...@keithp.com -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH 3/4] glamor: Ask the server to always allocate our private.

Eric Anholt e...@anholt.net writes: This avoids a lot of screwing around to attach our privates later. It means that non-glamor pixmaps now gain 120 bytes of glamor privates on 64-bit (which has quite a bit of fixable bloat), and glamor pixmaps take one less pointer of storage (not counting

Re: [PATCH 4/4] glamor: Drop a bunch of glamor_priv == NULL checks.

Eric Anholt e...@anholt.net writes: Now that it's always non-null when the pixmap is non-null, we don't need so much of this. glamor_get_pixmap_private() itself still accepts a NULL pixmap and returns NULL, because of glamor_render.c Might want to change glamor_pixmap_type to explicitly make

Re: [git pull] Xwayland fix

Olivier Fourdan ofour...@redhat.com writes: Chris Wilson (1): xwayland: keep temp files out of the client mask Merged. 0cd2280..991712f master - master -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH 4/4] glamor: Drop a bunch of glamor_priv == NULL checks.

Michel Dänzer mic...@daenzer.net writes: On 08.07.2015 09:26, Eric Anholt wrote: diff --git a/glamor/glamor_utils.h b/glamor/glamor_utils.h index 0a7de82..a923b7a 100644 --- a/glamor/glamor_utils.h +++ b/glamor/glamor_utils.h @@ -756,8 +756,8 @@ glamor_translate_boxes(BoxPtr boxes, int

Re: [git pull] Xwayland fix

Olivier Fourdan ofour...@redhat.com writes: Hi Keith, Could you please pull from the following git tree the fix for Xwayland that Chris contributed for bug https://bugs.freedesktop.org/show_bug.cgi?id=91072? Your repository isn't accessible via git:// protocol, which means only people with

Re: [PATCH] glamor_egl: Properly free resources on init-error and exit

Hans de Goede hdego...@redhat.com writes: glamor_egl_init() was not undoing any of the init steps on init error, add an glamor_egl_cleanup() function and use this both on error and on exit to cleanup the various resources. Even on a clean exit eglTerminate() was not being called, causing the

Re: [PULL] xserver updates

Adam Jackson a...@redhat.com writes: Adam Jackson (22): present: static cleanup parser: static cleanup dri3: Remove unbuilt dri3_event.c dri3: static cleanup dix: Unexport various implementation details randr: Unexport some implementation details

Re: [PATCH] glamor_egl: Properly free resources on init-error and exit

Eric Anholt e...@anholt.net writes: Hans de Goede hdego...@redhat.com writes: glamor_egl_init() was not undoing any of the init steps on init error, add an glamor_egl_cleanup() function and use this both on error and on exit to cleanup the various resources. Even on a clean exit

Re: [PATCH] prime: add rotation support for offloaded outputs (v2)

Alex Deucher alexdeuc...@gmail.com writes: Signed-off-by: Dave Airlie airl...@redhat.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com Merged. 991712f..90db5ed master - master -- -keith signature.asc Description: PGP signature ___

[PATCH] dmx: Fix the build

Broken since: commit 4fd81823fafcd103e8d890f4c0f7c2f90e822336 Author: Dave Airlie airl...@gmail.com Date: Tue Jun 30 14:54:42 2015 +1000 prime: add rotation support for offloaded outputs (v2) Signed-off-by: Adam Jackson a...@redhat.com --- configure.ac | 2 +- 1 file

[PATCH 05/12] glamor: Move glamor_render.c pict handling to glamor_picture.c

These functions aren't used by anything else, and are specific to the temporary-upload-as-a-weird-format path of glamor_render.c, called through glamor_upload_picture_to_texture(). Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_picture.c | 870

[PATCH 08/12] glamor: Drop dead drm_stride field.

Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_priv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/glamor/glamor_priv.h b/glamor/glamor_priv.h index 5989dc4..f3950f1 100644 --- a/glamor/glamor_priv.h +++ b/glamor/glamor_priv.h @@ -350,7 +350,6 @@ typedef struct

[PATCH 07/12] glamor: Drop tracking of the last picture attached to pixmaps.

Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor.c | 11 --- glamor/glamor_picture.c | 48 glamor/glamor_priv.h| 15 --- glamor/glamor_render.c | 3 --- glamor/glamor_utils.h | 10 +-

[PATCH 09/12] glamor: Take transforms into account when preparing for a fallback.

This function takes the start x/y and the destination's width/height, so it only works if there's no transform. We could potentially transform this box and take its bounds with some rounding, but this at least gets us to read out enough data. Note that this does the same overshoot on destination

[PATCH 01/12] glamor: Don't try to do rendering with unsupported formats.

I'm amazed we've made it as far as we have without these checks: if you made an unusual format picture that wasn't the normal a8r8g8b8 or x8r8g8b8 or a8, we'd go ahead and try to render with it, ignoring that the sampler would fetch totally wrong bits. Fixes 260 tests in rendercheck -t blend -o

[PATCH 11/12] glamor: Move cache_format to glamor_fbo.c, where it's used.

Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_fbo.c | 15 +++ glamor/glamor_utils.h | 15 --- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/glamor/glamor_fbo.c b/glamor/glamor_fbo.c index 1eee304..262033f 100644 --- a/glamor/glamor_fbo.c

[PATCH 06/12] glamor: Use the actual picture's format when uploading memory pixmaps.

The pixmap-picture is just the *last* picture attached to the pixmap, so you'd potentially be looking at the wrong one when trying to temporarily upload to avoid a composite fallback. There's some trickiness in glamor_render.c when we're dealing with the upload of a GLAMOR_MEMORY pixmap as both

[PATCH 10/12] glamor: Drop another dead function.

This hasn't been used since the format swap/revert stuff for pictures was added back in 2012. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_utils.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/glamor/glamor_utils.h b/glamor/glamor_utils.h index 59e6b64..e22bbc1 100644

[PATCH 04/12] glamor: Drop dead glamor_upload_bits_to_pixmap_texture() proto.

Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_priv.h | 9 - 1 file changed, 9 deletions(-) diff --git a/glamor/glamor_priv.h b/glamor/glamor_priv.h index 1614b6f..508433a 100644 --- a/glamor/glamor_priv.h +++ b/glamor/glamor_priv.h @@ -741,15 +741,6 @@ Bool

[PATCH 03/12] glamor: Use the new upload/download interface for XV uploads.

We don't need any of its weird handling of picture formats, since our XV pixmaps don't have any pictures attached. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_pixmap.c | 2 +- glamor/glamor_priv.h | 4 glamor/glamor_xv.c | 38 --

glamor: rendercheck fixes and picture handling simplification

This series came out of the process of trying to figure out if I could safely store a8 pixmaps in an a8r8g8b8 FBO, to improve glamor performance on VC4 (which doesn't support 8-bit FBOs). It turns out the answer is not quite, but the Render code had a lot of bugs obscuring that fact.

[PATCH 02/12] glamor: Ignore picture formats when choosing color for core rendering.

Attaching a picture to a pixmap doesn't change its GL format, so it doesn't change how core rendering should be assigning colors to it. (Imagine XCreatePixmap(), optional XCreatePicture(pixmap) with various formats, XFillRectangle, XGetImage(). If the XGetImage results changed, this would be

[PATCH 12/12] glamor: Drop unused box translation/bounds code.

These are dead since the glamor_copy.c replacement. Signed-off-by: Eric Anholt e...@anholt.net --- glamor/glamor_utils.h | 39 --- 1 file changed, 39 deletions(-) diff --git a/glamor/glamor_utils.h b/glamor/glamor_utils.h index 8a96c61..e648af2 100644 ---

Re: [PATCH xf86-input-libinput] Add a property for tap drag lock

Hi, On 08-07-15 03:04, Peter Hutterer wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net LGTM: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- configure.ac | 2 +- include/libinput-properties.h | 6 +++ man/libinput.man |

Re: glamor: rendercheck fixes and picture handling simplification

On 9 July 2015 at 05:45, Eric Anholt e...@anholt.net wrote: This series came out of the process of trying to figure out if I could safely store a8 pixmaps in an a8r8g8b8 FBO, to improve glamor performance on VC4 (which doesn't support 8-bit FBOs). It turns out the answer is not quite, but the

Re: [PATCH 05/12] glamor: Move glamor_render.c pict handling to glamor_picture.c

On 9 July 2015 at 05:45, Eric Anholt e...@anholt.net wrote: These functions aren't used by anything else, and are specific to the temporary-upload-as-a-weird-format path of glamor_render.c, called through glamor_upload_picture_to_texture(). Signed-off-by: Eric Anholt e...@anholt.net

Re: [PATCH 03/12] glamor: Use the new upload/download interface for XV uploads.

On 9 July 2015 at 05:45, Eric Anholt e...@anholt.net wrote: We don't need any of its weird handling of picture formats, since our XV pixmaps don't have any pictures attached. Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Dave Airlie airl...@redhat.com --- glamor/glamor_pixmap.c |

Re: [PATCH 02/12] glamor: Ignore picture formats when choosing color for core rendering.

On 9 July 2015 at 05:45, Eric Anholt e...@anholt.net wrote: Attaching a picture to a pixmap doesn't change its GL format, so it doesn't change how core rendering should be assigning colors to it. (Imagine XCreatePixmap(), optional XCreatePicture(pixmap) with various formats, XFillRectangle,

Re: [PATCH 04/12] glamor: Drop dead glamor_upload_bits_to_pixmap_texture() proto.

On 9 July 2015 at 05:45, Eric Anholt e...@anholt.net wrote: Signed-off-by: Eric Anholt e...@anholt.net Reviewed-by: Dave Airlie airl...@redhat.com ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: [PATCH] dmx: Fix the build

On 9 July 2015 at 05:57, Adam Jackson a...@redhat.com wrote: Broken since: commit 4fd81823fafcd103e8d890f4c0f7c2f90e822336 Author: Dave Airlie airl...@gmail.com Date: Tue Jun 30 14:54:42 2015 +1000 prime: add rotation support for offloaded outputs (v2) Signed-off-by: