Re: [PATCH xserver 14/19] glamor: Drop extra conditionals for large pixmap handling.

2016-01-29 Thread Eric Anholt
Eric Anholt writes: > For a small pixmap, it's got a box from 0,0 to width/height, so we can > always use that. This seemed so sensible, but it turns out that for MEMORY pixmaps we'll attach an FBO to it in the glamor_picture.c code, without setting its box (which is still zeroed). This may be

Re: [PATCH xserver 1/2] xfree86/modes: Fix HW cursor clipping for crtc->driverIsPerformingTransform

2016-01-29 Thread Michel Dänzer
On 30.01.2016 02:56, Keith Packard wrote: > Aaron Plattner writes: >> On 01/29/2016 07:23 AM, Keith Packard wrote: >>> Michel Dänzer writes: >>> I'm not sure that makes sense; e.g. it seems inconsistent with leaving the cursor image untransformed in the driverIsPerformingTransform case.

Re: [PATCH xserver 00/19] glamor: Cleanups all over

2016-01-29 Thread Kenneth Graunke
On Wednesday, January 27, 2016 5:56:29 PM PST Eric Anholt wrote: > I've been working on vc4 X performance again, particularly looking at > dragging windows with xcompmgr -c running. I'll be sending a separate > patch to accelerate a8 rendering on GLES2-class renderers, but even > with that things

Re: [PATCH xserver 00/19] glamor: Cleanups all over

2016-01-29 Thread Eric Anholt
Dave Airlie writes: > On 28 January 2016 at 18:21, Dave Airlie wrote: >> On 28 January 2016 at 11:56, Eric Anholt wrote: >>> I've been working on vc4 X performance again, particularly looking at >>> dragging windows with xcompmgr -c running. I'll be sending a separate >>> patch to accelerate a

Re: [PATCH xserver 1/2] xfree86/modes: Fix HW cursor clipping for crtc->driverIsPerformingTransform

2016-01-29 Thread Keith Packard
Aaron Plattner writes: > On 01/29/2016 07:23 AM, Keith Packard wrote: >> Michel Dänzer writes: >> >>> I'm not sure that makes sense; e.g. it seems inconsistent with leaving >>> the cursor image untransformed in the driverIsPerformingTransform case. >>> It seems to me like the idea behind driver

Re: [PATCH xserver 1/2] xfree86/modes: Fix HW cursor clipping for crtc->driverIsPerformingTransform

2016-01-29 Thread Aaron Plattner
On 01/29/2016 07:23 AM, Keith Packard wrote: > Michel Dänzer writes: > >> I'm not sure that makes sense; e.g. it seems inconsistent with leaving >> the cursor image untransformed in the driverIsPerformingTransform case. >> It seems to me like the idea behind driverIsPerformingTransform was to >>

Re: [PATCH xserver 1/2] xfree86/modes: Fix HW cursor clipping for crtc->driverIsPerformingTransform

2016-01-29 Thread Keith Packard
Michel Dänzer writes: > I'm not sure that makes sense; e.g. it seems inconsistent with leaving > the cursor image untransformed in the driverIsPerformingTransform case. > It seems to me like the idea behind driverIsPerformingTransform was to > leave all transformations to the driver/hardware. I

Re: [PATCH xserver 1/2] xfree86/modes: Fix HW cursor clipping for crtc->driverIsPerformingTransform

2016-01-29 Thread Michel Dänzer
On 26.12.2015 12:20, Keith Packard wrote: > Michel Dänzer writes: >> On 26.12.2015 04:08, Keith Packard wrote: >>> Michel Dänzer writes: >>> From: Michel Dänzer Even if the driver is handling the transform, we still need to transform the cursor position for clipping, otherwis