Re: [PATCH xserver 5/8] xquartz/glx: Error out for MakeContextCurrent(draw != read)

On Mon, 2016-03-21 at 14:12 -0700, Matt Turner wrote: > I'm not sure how that parses. Should be != D'oh. Serves me right for trying to edit code I can't build. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xserver 5/8] xquartz/glx: Error out for MakeContextCurrent(draw != read)

On Mon, Mar 21, 2016 at 1:29 PM, Adam Jackson wrote: > CGL doesn't have a way to express this directly, unlike EGL WGL and GLX. > It might be implementable, but it's never actually worked, and it's a > fairly niche feature so we're better off throwing an error if someone >

[PATCH xserver 7/8] glx: Enable GLX_SGI_make_current_read in the core

Signed-off-by: Adam Jackson --- glx/extension_string.c | 2 +- glx/glxdri2.c | 7 --- glx/glxdriswrast.c | 1 - hw/xwin/glx/indirect.c | 1 - 4 files changed, 1 insertion(+), 10 deletions(-) diff --git a/glx/extension_string.c b/glx/extension_string.c index

[PATCH xserver 5/8] xquartz/glx: Error out for MakeContextCurrent(draw != read)

CGL doesn't have a way to express this directly, unlike EGL WGL and GLX. It might be implementable, but it's never actually worked, and it's a fairly niche feature so we're better off throwing an error if someone attempts it. Signed-off-by: Adam Jackson ---

[PATCH xserver 4/8] xwin/glx: Always enable GLX_SGIX_pbuffer

Again, this is enabled unconditionally by the GLX core. If the backend doesn't have WGL_EXT_pbuffer then we won't set the pbuffer bit on any fbconfigs. Note that the dri2/drisw backends back pbuffers with pixmaps, so the "clobber" semantics never come into play. Since pbuffer usage is pretty rare

[PATCH xserver 6/8] xwin/glx: Assume WGL_ARB_make_current_read exists

This seems to be fairly universal these days, and if it doesn't exist the only thing you break is separate drawable and readable, which is a fairly rare feature to use. So pretend it's always there and just throw an error on MakeCurrent if it doesn't. As a result we can enable GLX 1.4

[PATCH xserver 0/8] Advertise GLX 1.4 for all DDXes

This is _mostly_ cleanup, but it does have some semantic changes. It seems CGL does not actually have a MakeCurrent call that lets you specify separate read and draw surfaces, so that's never in fact worked, and as a result xquartz technically can't even implement GLX 1.3 (or EGL!). But I suspect

[PATCH xserver 3/8] {xwin, xquartz}/glx: Always enable GLX_{ARB, SGIS}_multisample

This is enabled unconditionally in the GLX core. For xwin, if the backend doesn't support WGL_ARB_multisample, there will simply be no fbconfigs that support it. Signed-off-by: Adam Jackson --- hw/xquartz/GL/indirect.c | 3 --- hw/xwin/glx/indirect.c | 24

[PATCH xserver 2/8] xwin/glx: Drop GLWIN_NO_WGL_EXTENSIONS hack

This doesn't seem very useful, and we're about to implement 1.4 across the board, so some WGL extensions will become required. Signed-off-by: Adam Jackson --- hw/xwin/glx/indirect.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/hw/xwin/glx/indirect.c

[PATCH xserver 1/8] glx: Remove default server glx extension string

This existed only to be strdup'd and then immediately freed. Signed-off-by: Adam Jackson --- glx/glxdri2.c| 2 -- glx/glxdriswrast.c | 2 -- glx/glxscreens.c | 20 +--- hw/xquartz/GL/indirect.c | 2 -- hw/xwin/glx/indirect.c | 2

[PATCH xserver 8/8] glx: Advertise GLX 1.4 unconditionally

Signed-off-by: Adam Jackson --- glx/glxcmds.c| 11 +++ glx/glxdri2.c| 12 glx/glxdriswrast.c | 3 --- glx/glxext.c | 2 -- glx/glxscreens.c | 12 glx/glxscreens.h | 11 ---

Re: [PATCH xserver v2] xwayland: Pretend we support viewport in vidmode

Hi, On 21-03-16 09:53, Olivier Fourdan wrote: Some games (namely openttd) will raise an XError and fail with a BadValue if their request to XF86VidModeSetViewPort fails. Support only the default zoom and viewport, fail for everything else. Signed-off-by: Olivier Fourdan

[PATCH xserver v2] xwayland: Pretend we support viewport in vidmode

Some games (namely openttd) will raise an XError and fail with a BadValue if their request to XF86VidModeSetViewPort fails. Support only the default zoom and viewport, fail for everything else. Signed-off-by: Olivier Fourdan --- v2: Support only the default zoom and