Re: [PATCH] Improved autoconfig drivers matching

2016-07-12 Thread Emil Velikov
On 23 July 2015 at 00:42, Karol Kosik wrote: > Implementation of new drivers matching algorithm. New approach > doesn't add duplicate drivers and ease drivers matching phase. > > Signed-off-by: Karol Kosik > --- > hw/xfree86/common/xf86AutoConfig.c | 124 > +++

Re: [PATCH xserver] xfree86: Fix fallback driver sort order for Xorg -configure (v2)

2016-07-12 Thread Keith Packard
Adam Jackson writes: > The original list is just whatever readdir() gave us, filtered to match > *_drv.so (although doing that bit with regex instead of glob because > why not). Which is how I found the bug in the first place: if you > reinstall vesa on a filesystem that gives you results in ctim

Re: [PATCH] Improved autoconfig drivers matching

2016-07-12 Thread Aaron Plattner
Nearly 1 year ping. On 07/28/2015 10:16 AM, Aaron Plattner wrote: > On 07/22/2015 04:42 PM, Karol Kosik wrote: >> Implementation of new drivers matching algorithm. New approach >> doesn't add duplicate drivers and ease drivers matching phase. >> >> Signed-off-by: Karol Kosik > > Reviewed-by: Aar

Re: [PATCH xserver] xfree86: Fix fallback driver sort order for Xorg -configure (v2)

2016-07-12 Thread Adam Jackson
On Tue, 2016-07-12 at 13:53 -0700, Keith Packard wrote: > Adam Jackson writes: > > > The intent here was that fallback drivers would be at the end of the > > list in order, but if a fallback driver happened to be at the end of the > > list already that's not what would happen. Rather than open-co

Re: [PATCH xserver] xfree86: Fix fallback driver sort order for Xorg -configure (v2)

2016-07-12 Thread Keith Packard
Adam Jackson writes: > The intent here was that fallback drivers would be at the end of the > list in order, but if a fallback driver happened to be at the end of the > list already that's not what would happen. Rather than open-code > something smarter, just use qsort. > > Note that qsort puts t

[PATCH xserver] xfree86: Fix fallback driver sort order for Xorg -configure (v2)

2016-07-12 Thread Adam Jackson
The intent here was that fallback drivers would be at the end of the list in order, but if a fallback driver happened to be at the end of the list already that's not what would happen. Rather than open-code something smarter, just use qsort. Note that qsort puts things in ascending order, so somew

Re: [PATCH xserver] xfree86: Fix fallback driver sort order for Xorg -configure

2016-07-12 Thread Keith Packard
Adam Jackson writes: > +static int > +driver_sort(void *_l, void *_r) > +{ > +const char *l = *(const char **)_l; > +const char *r = *(const char **)_r; > +int left = is_fallback(l); > +int right = is_fallback(r); > + > +/* neither is a fallback */ > +if (left == -1 && rig

[PATCH xserver] xfree86: Fix fallback driver sort order for Xorg -configure

2016-07-12 Thread Adam Jackson
The intent here was that fallback drivers would be at the end of the list in order, but if a fallback driver happened to be at the end of the list already that's not what would happen. Rather than open-code something smarter, just use qsort. Note that qsort puts things in ascending order, so somew

Re: [PATCH xserver] FlushAllOutput: Only call FlushCallbacks when actually flushing data

2016-07-12 Thread Keith Packard
Adam Jackson writes: > Here's an epoll branch rebased to master, with poll emulation for > Windows, and a pair of proof-of-concept patches at the end to allow > (force) testing on pollful systems: So you're just emulating poll with select, which should work on Windows. that seems like a good sta

Re: [PATCH xserver] FlushAllOutput: Only call FlushCallbacks when actually flushing data

2016-07-12 Thread Adam Jackson
On Mon, 2016-07-11 at 12:32 -0400, Peter Harris wrote: > On 2016-07-08 16:33, Keith Packard wrote: > > Adam Jackson writes: > > > > > Still not cool with committing code that we _know_ will break a > > > supported platform. > > > > Oh, right, windows. Hrm. Suggestions welcome, but I suspect the

Re: XDC 2016 : Call for paper

2016-07-12 Thread Martin Peres
On 13/05/16 01:56, Martin Peres wrote: Hello, I have the pleasure to announce that the X.org Developer Conference 2016 will be held in Helsinki from September 21 to September 23. The venue is located at Haaga-Helia university[0], next to the Pasila station. The official page for the event is ht

Re: [PATCH xserver] modesetting: do not disable dirty rectangles on EINVAL.

2016-07-12 Thread Michael Thayer
On 10.07.2016 12:23, Michael Thayer wrote: Hello Adam, On 05.07.2016 20:40, Adam Jackson wrote: On Mon, 2016-07-04 at 21:43 +0200, Michael Thayer wrote: When submitting dirty rectangles to the kernel driver, modesetting checks the return value, and if it gets ENOSYS (driver does not support re

[PATCH resend xf86-video-intel] Fix fd (and mem) leak when intel_scrn_create fails

2016-07-12 Thread Hans de Goede
The probe functions in intel_module.c call intel_open_device() before calling intel_scrn_create(), but if the later fails because of e.g. an unsupported (new) pci-id they were not cleaning up the resources claimed by intel_open_device(), esp. leaking the fd is a problem because this breaks the fall