Re: [PATCH xserver] xfree86/modes: Use xf86ScrnToScreen in xf86RandR12LoadPalette

2016-07-29 Thread Keith Packard
Michel Dänzer writes: > From: Michel Dänzer > > Fixes crash in ScreenInit -> xf86HandleColormaps -> > xf86RandR12LoadPalette with drivers which don't assign pScrn->pScreen > in ScreenInit. That's a terrible interface. This should be fixed by wrapping

Re: [PATCH xserver] present: Handle event mask updates as specified v2

2016-07-29 Thread Kenneth Graunke
On Friday, July 29, 2016 6:41:06 PM PDT Michel Dänzer wrote: > From: Michel Dänzer > > From the Present extension specification: > > An event context is associated with a specific window; using > an existing event context with a different window generates > a Match

Re: [PATCH] xdm: Add headers for implicitly declared function

2016-07-29 Thread Alan Coopersmith
On 07/29/16 02:40 AM, Alive 4ever wrote: On Mon, Jul 25, 2016 at 03:46:38PM -0700, Alan Coopersmith wrote: On 07/24/16 07:52 PM, Alive 4ever wrote: Added headers needed to suppress implicit function declaration error. This fixes build on gcc 6.1.1 and clang 3.8.0. Those headers are not the

Re: [PATCH xserver] present: Handle event mask updates as specified v2

2016-07-29 Thread Keith Packard
Michel Dänzer writes: > Signed-off-by: Michel Dänzer Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development

Re: [PATCH xserver] present: Handle event mask updates as specified

2016-07-29 Thread Keith Packard
Michel Dänzer writes: > Thanks, I incorporated almost all your changes in v2, with the exception > of not calling LEGAL_NEW_RESOURCE if mask == 0, due to this spec language: > > If eventContext is an unused XID, then if eventMask is empty > no operation is performed.

Re: [PATCH xserver] present: Handle event mask updates as specified

2016-07-29 Thread Michel Dänzer
On 29.07.2016 01:54, Keith Packard wrote: > Michel Dänzer writes: > >> Without this change, there's no way for a client to explicitly change >> or destroy an existing event mask entry. Trying to do so as specified >> above would actually result in a new entry being created

[PATCH xserver] present: Handle event mask updates as specified v2

2016-07-29 Thread Michel Dänzer
From: Michel Dänzer From the Present extension specification: An event context is associated with a specific window; using an existing event context with a different window generates a Match error. If eventContext specifies an existing event context, then if

Re: [PATCH] xdm: Add headers for implicitly declared function

2016-07-29 Thread Alive 4ever
On Mon, Jul 25, 2016 at 03:46:38PM -0700, Alan Coopersmith wrote: > On 07/24/16 07:52 PM, Alive 4ever wrote: > > Added headers needed to suppress implicit function declaration error. > > This fixes build on gcc 6.1.1 and clang 3.8.0. > > Those headers are not the same on all OS'es - you'd need to

[PATCH xserver] xfree86/modes: Handle no palette case better in xf86RandR12CrtcSetGamma

2016-07-29 Thread Michel Dänzer
From: Michel Dänzer Just use the RandR gamma ramp directly. Fixes random on-monitor colours with drivers which don't call xf86HandleColormaps, e.g. modesetting. Signed-off-by: Michel Dänzer --- hw/xfree86/modes/xf86RandR12.c | 10 +- 1

Re: [PATCH xserver 1/3] xfree86/modes: Move gamma initialization to xf86RandR12Init12 v2

2016-07-29 Thread walter harms
Am 28.07.2016 19:11, schrieb Keith Packard: > walter harms writes: > >> 1. I do not want to start an argument here. > > Your comments are welcome and helpful. > >> but i seems i need to explain what i wanted to say: >> "b and c do not change inside the loop" >> >> that does

[PATCH xserver] xfree86/modes: Use xf86ScrnToScreen in xf86RandR12LoadPalette

2016-07-29 Thread Michel Dänzer
From: Michel Dänzer Fixes crash in ScreenInit -> xf86HandleColormaps -> xf86RandR12LoadPalette with drivers which don't assign pScrn->pScreen in ScreenInit. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97124 Signed-off-by: Michel Dänzer