Re: [PATCH xserver v3] glamor: Handle bitplane in glamor_copy_fbo_cpu

Michel Dänzer writes: > On 18/08/16 11:09 PM, Alex Deucher wrote: >> On Thu, Aug 18, 2016 at 5:42 AM, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> This can significantly speed up at least some CopyPlane cases, e.g. >>>

Re: XDC 2016 : Call for paper

On Thu, May 12, 2016 at 6:56 PM, Martin Peres wrote: > Hello, > > I have the pleasure to announce that the X.org Developer Conference 2016 > will be held in Helsinki from September 21 to September 23. The venue is > located at Haaga-Helia university[0], next to the Pasila

Re: XDC 2016 : Call for paper

On Thu, May 12, 2016 at 6:56 PM, Martin Peres wrote: > Hello, > > I have the pleasure to announce that the X.org Developer Conference 2016 > will be held in Helsinki from September 21 to September 23. The venue is > located at Haaga-Helia university[0], next to the Pasila

Re: [PATCH v2 xserver 3/5] modesetting: move common page flip handle to pageflip.c

Sorry, disregard. The pointer doesn't point inside the struct. That part of the patch is fine. Tom From: amd-gfx on behalf of StDenis, Tom Sent: Friday, August 19, 2016 07:30 To: Yu, Qiang;

Re: [PATCH v2 xserver 3/5] modesetting: move common page flip handle to pageflip.c

In ms_pageflip_free() you cannot free the parent structure before freeing things it points to. That's undefined behaviour. Tom From: amd-gfx on behalf of Qiang Yu Sent: Friday, August 19, 2016 08:50

[PATCH v2 xserver 5/5] modesetting: exclude DRI2 and prensent page flip

Signed-off-by: Qiang Yu Reviewed-by: Michel Dänzer --- hw/xfree86/drivers/modesetting/dri2.c| 11 +-- hw/xfree86/drivers/modesetting/driver.h | 5 +++-- hw/xfree86/drivers/modesetting/drmmode_display.h | 3 +++

[PATCH v2 xserver 2/5] modesetting: move ms_do_pageflip to pageflip.c

Signed-off-by: Qiang Yu Reviewed-by: Michel Dänzer --- hw/xfree86/drivers/modesetting/Makefile.am | 1 + hw/xfree86/drivers/modesetting/driver.h| 48 ++ hw/xfree86/drivers/modesetting/pageflip.c | 251

[PATCH v2 xserver 0/5] modesetting: add DRI2 page flip support

Hi guys, This patch set is for adding DRI2 page flip support to modesetting driver. I mainly take reference of amdgpu DDX and reuse present page flip code in the modesetting driver. V2: 1. fix DRI2 page flip success handler event memory leak 2. adjust patch sequence to make DRI2 use the common

[PATCH v2 xserver 4/5] modesetting: add DRI2 page flip support

Signed-off-by: Qiang Yu --- hw/xfree86/drivers/modesetting/dri2.c | 230 -- 1 file changed, 221 insertions(+), 9 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/dri2.c b/hw/xfree86/drivers/modesetting/dri2.c index 83cb3e0..acbb980

[PATCH v2 xserver 1/5] modesetting: make ms_do_pageflip generic for share with DRI2

Signed-off-by: Qiang Yu Reviewed-by: Michel Dänzer --- hw/xfree86/drivers/modesetting/present.c | 38 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/present.c

[PATCH v2 xserver 3/5] modesetting: move common page flip handle to pageflip.c

The common page flip handle framework can be shared with DRI2 page flip. Signed-off-by: Qiang Yu --- hw/xfree86/drivers/modesetting/driver.h | 28 hw/xfree86/drivers/modesetting/pageflip.c | 102 --

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

On 19/08/16 04:57 PM, Emil Velikov wrote: > On 19 August 2016 at 03:09, Michel Dänzer wrote: >> On 19/08/16 11:02 AM, Yu, Qiang wrote: >>> >>> Each point of the patch set is not broken. Patches are arranged like >>> this to show how I do it: >>> 1. create a pageflip.c to host

Re: [PATCH xserver 3/6] modesetting: add DRI2 page flip support

On 19/08/16 04:48 PM, Yu, Qiang wrote: > > +/* Post damage on the front buffer so that listeners, such > + * as DisplayLink know take a copy and shove it over the USB. > + * also for sw cursors. > + */ SW cursors cannot work correctly with page flipping.

Re: [PATCH xserver 0/6] modesetting: add DRI2 page flip support

On 19 August 2016 at 03:09, Michel Dänzer wrote: > On 19/08/16 11:02 AM, Yu, Qiang wrote: >> >> Each point of the patch set is not broken. Patches are arranged like >> this to show how I do it: >> 1. create a pageflip.c to host common page flip code >> 2. copy amdgpu DDX DRI2

Re: [PATCH xserver 3/6] modesetting: add DRI2 page flip support

>>> +/* Post damage on the front buffer so that listeners, such >>> + * as DisplayLink know take a copy and shove it over the USB. >>> + * also for sw cursors. >>> + */ >> >> SW cursors cannot work correctly with page flipping. For that reason, >> xf86-video-ati/amdgpu disable

Re: [PATCH xserver v3] glamor: Handle bitplane in glamor_copy_fbo_cpu

On 18/08/16 11:09 PM, Alex Deucher wrote: > On Thu, Aug 18, 2016 at 5:42 AM, Michel Dänzer wrote: >> From: Michel Dänzer >> >> This can significantly speed up at least some CopyPlane cases, e.g. >> indirectly for stippled fills. >> >> v2: >> * Make

Re: [PATCH xserver 3/6] modesetting: add DRI2 page flip support

On 19/08/16 04:06 PM, Yu, Qiang wrote: > >>> +static Bool >>> +can_exchange(ScrnInfoPtr scrn, DrawablePtr draw, >>> + DRI2BufferPtr front, DRI2BufferPtr back) >>> +{ >> >> [...] >> >>> +if (!update_front(draw, front)) >>> +return FALSE; >> >> I know you just copied this

Re: [PATCH xserver 3/6] modesetting: add DRI2 page flip support

> +static Bool > +can_exchange(ScrnInfoPtr scrn, DrawablePtr draw, > + DRI2BufferPtr front, DRI2BufferPtr back) > +{ [...] > +if (!update_front(draw, front)) > +return FALSE; I know you just copied this from -ati/amdgpu, but: I don't think can_exchange should call