Re: [PATCH v2 xserver 1/2] glamor: Add glamor_shareable_fd_from_pixmap()

2016-08-24 Thread Keith Packard
Hans de Goede writes: > Add glamor_shareable_fd_from_pixmap function to get dma-buf fds suitable > for sharing across GPUs (not using GPU specific tiling). > > This is necessary for the modesetting driver to correctly implement > the DRI2 SharePixmapBacking callback. > >

Re: [PATCH 1/2] glamor: Add GLAMOR_ACCESS_WO

2016-08-24 Thread Marek Olšák
On Wed, Aug 24, 2016 at 5:27 AM, Michel Dänzer wrote: > > Adding Marek and Nicolai, maybe they have some feedback from a GL > (driver) perspective. > > > On 23/08/16 10:41 AM, Dave Airlie wrote: >> From: Michel Dänzer >> >> [airlied: rebased onto

Re: [PATCH 1/2] glamor: Add GLAMOR_ACCESS_WO

2016-08-24 Thread Adam Jackson
On Wed, 2016-08-24 at 12:27 +0900, Michel Dänzer wrote: > This change results in write-combining for the PBO CPU mapping. > Apparently, fbPutXYImage ends up either reading from the PBO, or at > least writing to it in a WC-unfriendly manner, causing a big slowdown. It does read from the

[PATCH xserver 3/3] modesetting: Fall back to primary crtc for vblank for drawables on slave outputs

2016-08-24 Thread Hans de Goede
This fixes glxgears running at 1 fps when fully covering a slave-output and the modesetting driver is used for the master gpu. Reported-by: Peter Wu Signed-off-by: Hans de Goede --- hw/xfree86/drivers/modesetting/vblank.c | 22 ++ 1

[PATCH xserver 1/3] modesetting: ms_covering_crtc: Remove unused arguments, make static

2016-08-24 Thread Hans de Goede
Remove unused arguments from ms_covering_crtc, make it static as it is only used in vblank.c. While at it also change its first argument from a ScrnInfoPtr to a ScreenPtr, this makes the next patch in this patch-set cleaner. Signed-off-by: Hans de Goede ---

[PATCH xserver 2/3] modesetting: ms_covering_crtc: Allow calling on non modesetting Screens

2016-08-24 Thread Hans de Goede
99% of the code in ms_covering_crtc is video-driver agnostic. Add a screen_is_ms parameter when when FALSE skips the one ms specific check, this will allow calling ms_covering_crtc on slave GPUs. Signed-off-by: Hans de Goede --- hw/xfree86/drivers/modesetting/vblank.c | 12

Re: modesetting: prefer primary crtc when picking over nothing

2016-08-24 Thread Hans de Goede
Hi, On 03-08-16 02:24, Dave Airlie wrote: So we had a bug report that epiphany was rendering slow on modesetting + DRI3, that I tracked down to the fact it was rendering offscreen to a single buffer. However due to this rendering being offscreen we were getting the fake crtc chosen by the X