Re: [PATCH RFC xserver] glamor: Fix pixmap offset for bitplane in glamor_copy_fbo_cpu

2016-10-04 Thread Michel Dänzer
On 04/10/16 08:28 PM, Olivier Fourdan wrote: > Commit cba28d5 - glamor: Handle bitplane in glamor_copy_fbo_cpu > instroduced a regression as the computed pixmap offset would not match > the qactual coordinates and write data elsewhere in memory causing a > segfault in fbBltOne(). > > Translate

Re: [Spice-devel] [PATCH xf86-video-qxl] Fix crash caused by attempting to access the screen pixmap before it is created

2016-10-04 Thread Christophe Fergeau
Hey Hans, On Tue, Oct 04, 2016 at 02:08:13PM +0200, Hans de Goede wrote: > qxl_resize_primary_to_virtual() was using pScrn->pScreen != NULL to check > if createScreenResources has been called. But starting with xserver 1.19 > pScrn->pScreen is non NULL even before createScreenResources is

[PATCH xserver] glamor: Use eglGetPlatformDisplayEXT not eglGetDisplay

2016-10-04 Thread Adam Jackson
eglGetDisplay forces the implementation to guess which kind of display it's been handed. glvnd does something different from Mesa, and in general it's impossible for the library to get this right. Instead use the API where you specify what kind of display it is. The explicit call to

Re: [PATCH xserver] fb: XYPixmap format PutImage includes all planes in depth

2016-10-04 Thread Adam Jackson
On Mon, 2016-10-03 at 15:37 -0700, Keith Packard wrote: > Unlike GetImage, for which the provided planemask restricts the data > delivered, for PutImage in XYPixmap format, all of the planes in the > drawable depth are sent and those outside the plane mask are simply > ignored. > > Signed-off-by:

Re: [PATCH xserver 2/3] glamor: Accelerate up XY pixmap putimage a little

2016-10-04 Thread Adam Jackson
On Mon, 2016-10-03 at 15:34 -0700, Keith Packard wrote: > That's true for GetImage, but the protocol doc is rather unclear about > PutImage. The only mention of 'plane-mask' in the PutImage spec is as a > relevant component in the GC. Xlib doesn't look at the plane mask; the > request length is

PATCH v2: Add xorg-xserver 1.19 support to tigervnc

2016-10-04 Thread Hans de Goede
Hi, Here is the promised v2 of my patch to add 1.19 support to tigervnc, this time with code to properly request write-ready notification when necessary. As mentioned in the original thread, I believe that there is a bug in tigervnc-1.7.0/common/rdr/FdOutStream.cxx: FdOutStream::flush(). When

Re: [tigervnc-devel] PATCH: Add xorg-xserver 1.19 support to tigervnc

2016-10-04 Thread Hans de Goede
Hi, On 10/04/2016 04:45 PM, Pierre Ossman wrote: On 03/10/16 17:59, Hans de Goede wrote: Hello tigervnc devs, As part of updating Fedora to xserver 1.19 I've written a tiger vnc patch to make tigervnc work with xserver 1.19. Nice, Thanks. :) Since xserver 1.19 switches from select to

Re: [tigervnc-devel] PATCH: Add xorg-xserver 1.19 support to tigervnc

2016-10-04 Thread Pierre Ossman
On 03/10/16 17:59, Hans de Goede wrote: Hello tigervnc devs, As part of updating Fedora to xserver 1.19 I've written a tiger vnc patch to make tigervnc work with xserver 1.19. Nice, Thanks. :) Since xserver 1.19 switches from select to poll the changes are non trivial and require some

Request changes in Compose.pre

2016-10-04 Thread Victor V. Kustov
Good day! Please approve following patch for type russian rouble symbol. --- Compose.pre.orig2016-10-03 17:07:00.778676663 +0300 +++ Compose.pre 2016-10-03 17:09:13.570672739 +0300 @@ -190,6 +190,10 @@ : "€" EuroSign # EURO SIGN : "€" EuroSign # EURO SIGN : "€"

[PATCH xf86-video-qxl] Fix crash caused by attempting to access the screen pixmap before it is created

2016-10-04 Thread Hans de Goede
qxl_resize_primary_to_virtual() was using pScrn->pScreen != NULL to check if createScreenResources has been called. But starting with xserver 1.19 pScrn->pScreen is non NULL even before createScreenResources is called, causing an invalid access to the screenPixmap in

Re: [Spice-devel] [PATCH xf86-video-qxl] Adjust xspice_wakeup_handler() prototype for building xspice with server 1.19

2016-10-04 Thread Hans de Goede
Hi, On 03-10-16 12:04, Christophe Fergeau wrote: On Thu, Sep 29, 2016 at 01:03:01PM +0200, Hans de Goede wrote: Signed-off-by: Hans de Goede --- src/spiceqxl_main_loop.c | 4 1 file changed, 4 insertions(+) diff --git a/src/spiceqxl_main_loop.c

[PATCH RFC xserver] glamor: Fix pixmap offset for bitplane in glamor_copy_fbo_cpu

2016-10-04 Thread Olivier Fourdan
Commit cba28d5 - glamor: Handle bitplane in glamor_copy_fbo_cpu instroduced a regression as the computed pixmap offset would not match the qactual coordinates and write data elsewhere in memory causing a segfault in fbBltOne(). Translate the pixmap coordinates so that the data is read and written

Re: PATCH: Add xorg-xserver 1.19 support to tigervnc

2016-10-04 Thread Hans de Goede
Hi, On 03-10-16 18:57, Eric Engestrom wrote: On Mon, Oct 03, 2016 at 05:59:33PM +0200, Hans de Goede wrote: Hello tigervnc devs, As part of updating Fedora to xserver 1.19 I've written a tiger vnc patch to make tigervnc work with xserver 1.19. Since xserver 1.19 switches from select to poll