Re: [PATCH xserver] modesetting: add missing ifdef GLAMOR

2016-10-10 Thread Mihail Konev
This seems to have been merged shortly after 1.19 RC1, i.e. non-critical bugs deadline. So it is a post-deadline fix for critical regression which occured in a non-critical fix (which happened to be merged too-close to crit line). ___

Re: [PATCH libX11] Don't rebuild ks_tables.h if nothing changed.

2016-10-10 Thread Martin Natano
On Sat, Oct 08, 2016 at 09:45:09PM +0200, Matthieu Herrb wrote: > > It looks good to me. 2 little things though: > > - you should use 'git commit -s' to generate a Signed-off-by: field in > the commit message See the updated diff below. > > - the reason why this patch is needed is a

[PATCH libX11] Don't rebuild ks_tables.h if nothing changed.

2016-10-10 Thread Martin Natano
This is my first patch to X.Org, so please tell me if there's something wrong with the submission or the patch itself. natano From e3601d791790ee0f1d0979e4d2a3852c390cd758 Mon Sep 17 00:00:00 2001 From: Martin Natano Date: Sat, 8 Oct 2016 19:57:50 +0200 Subject: [PATCH]

[PATCH xserver] modesetting: add missing ifdef GLAMOR

2016-10-10 Thread Mihail Konev
This fixes --disable-glamor failing to build. Regressed-in: e8695100b17b758359fc4897dbe995231ed224fc Signed-off-by: Mihail Konev --- hw/xfree86/drivers/modesetting/driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/xfree86/drivers/modesetting/driver.c

[PATCH] Add git format.subjectPrefix to modules

2016-10-10 Thread Mihail Konev
Hello. Xserver's autogen.sh checks for format.subjectPrefix git preference to be defined, and sets a default in case there is none. Other modules are missing this feature. To generate the patches, In xorg/util/modular directory, cloned all the modules (thanks to build.sh -L). Ran the attached

Re: [PATCH] inputthread: Fix inputthread not listening if a fd gets re-added immediately after removal

2016-10-10 Thread Mihail Konev
Hello. On Wed, 5 Oct 2016 14:45:20 +0200, Hans de Goede wrote: > When a fd is removed dev->state gets set to device_state_removed, > if the fd then gets re-added before InputThreadDoWork() deals with > the removal, the InputThreadDevice struct gets reused, but its > state would stay

Re: Request changes in Compose.pre

2016-10-10 Thread Mihail Konev
On Wed Oct 5 09:40:28 UTC 2016, Victor V. Kustov wrote: > Sorry for noise, but I'm discouraged by silence. Maybe I need send > patch by another address or maybe I doing wrong something... Please > give me a tips how I may do it correctly. There are the steps supposed to be performed.

Re: [PATCH 3/3] glx: Initialize glx even if there are currently no screens attached

2016-10-10 Thread Jeremy Huddleston Sequoia
> On Oct 10, 2016, at 10:16, Adam Jackson wrote: > > On Sun, 2016-10-09 at 12:51 -0700, Jeremy Huddleston Sequoia wrote: >> Failure to do so causes an overvlow in glxClientCallback > > This patch makes no sense at all. glxClientCallback is only added to > the call chain _after_

Re: [PATCH 3/3] glx: Initialize glx even if there are currently no screens attached

2016-10-10 Thread Adam Jackson
On Sun, 2016-10-09 at 12:51 -0700, Jeremy Huddleston Sequoia wrote: > Failure to do so causes an overvlow in glxClientCallback This patch makes no sense at all. glxClientCallback is only added to the call chain _after_ we check for a GL-capable visual. If that check is preventing GLX from

Re: [PATCH 2/3] randr: Initialize RandR even if there are currently no screens attached

2016-10-10 Thread Jeremy Huddleston Sequoia
> On Oct 10, 2016, at 03:33, Emil Velikov wrote: > > Hi Jeremy, > > On 9 October 2016 at 20:51, Jeremy Huddleston Sequoia > wrote: >> Failure to do so causes an overvlow in RRClientCallback(). >> > s/overvlow/overflow/ Doh, corrected the typo,

Re: [PATCH 3/3] configure.ac: remove --enable-aiglx option

2016-10-10 Thread Jon Turney
On 09/10/2016 15:42, Emil Velikov wrote: On Friday, 7 October 2016, Jon Turney wrote: That's not quite enough, as building glxdri2.c also requires dri2proto headers. At the moment, configure.ac only requires dri2proto when --enable-dri2 turns on. So either that needs to be made

[xserver PULL for 1.19] Various fixes

2016-10-10 Thread Hans de Goede
Hi Adam, Keith, Here is a pull-req with 2 prime hw cursor fixes from Michel Dänzer, reviewed by me and 1 fix from me reviewed by Keith. The following changes since commit 97a8353ec1192d8d3bd2ebb99e5687cb91427e09: Fix id in error when resource does not exist (2016-10-06 14:50:42 -0400) are

Re: [PATCH xf86-input-libinput] Fix crash when using threaded input and the first device goes away

2016-10-10 Thread Hans de Goede
Hi, On 10/10/2016 11:10 AM, Emil Velikov wrote: Hi Hans, On Wednesday, 5 October 2016, Hans de Goede > wrote: When the xserver uses threaded input, it keeps a pointer to the InputInfo passed into xf86AddEnabledDevice and calls

Re: [PATCH xserver] os/xdmcp: Honour -once when session is dead

2016-10-10 Thread walter harms
looks good to me (and hope that helps) reviewed-by: wharms re, wh Am 30.09.2016 14:05, schrieb Daniel Martin: > Terminate a dead session when -once was passed. Don't restart it. > > Signed-off-by: Daniel Martin > --- > os/xdmcp.c | 2 +- > 1 file

Re: [PATCH libXi] SizeClassInfo can return 0 even without an error

2016-10-10 Thread walter harms
Am 10.10.2016 12:24, schrieb Emil Velikov: > On 9 October 2016 at 21:31, Niels Ole Salscheider > wrote: >> Hi Emil, >> >> On Sunday, 9 October 2016, 15:34:28 CEST, Emil Velikov wrote: >>> Hi Niels, >>> >>> On Friday, 7 October 2016, Niels Ole Salscheider < >>>

Re: [PATCH xserver] os/xdmcp: Honour -once when session is dead

2016-10-10 Thread Daniel Martin
Imho this could be picked for 1.19. Anyone willing to give his Rb? On 30 September 2016 at 14:05, Daniel Martin wrote: > Terminate a dead session when -once was passed. Don't restart it. > > Signed-off-by: Daniel Martin > --- > os/xdmcp.c | 2

Re: [PATCH 2/3] randr: Initialize RandR even if there are currently no screens attached

2016-10-10 Thread Emil Velikov
Hi Jeremy, On 9 October 2016 at 20:51, Jeremy Huddleston Sequoia wrote: > Failure to do so causes an overvlow in RRClientCallback(). > s/overvlow/overflow/ Perhaps a slightly silly question: How can one end up in the callback if we haven't executed AddCallback(,

Re: [PATCH libXi] SizeClassInfo can return 0 even without an error

2016-10-10 Thread Emil Velikov
On 9 October 2016 at 21:31, Niels Ole Salscheider wrote: > Hi Emil, > > On Sunday, 9 October 2016, 15:34:28 CEST, Emil Velikov wrote: >> Hi Niels, >> >> On Friday, 7 October 2016, Niels Ole Salscheider < >> >> niels_...@salscheider-online.de> wrote: >> > Catch the

Re: [PATCH 1/3] os/connection: Improve abstraction for launchd secure sockets

2016-10-10 Thread Emil Velikov
On 9 October 2016 at 20:51, Jeremy Huddleston Sequoia wrote: > This changes away from hard-coding the /tmp/launch-* path to now > supporting a generic [.] > format for $DISPLAY. > > cf-libxcb: d978a4f69b30b630f28d07f1003cf290284d24d8 > > Signed-off-by: Jeremy Huddleston

Re: [PATCH xf86-input-libinput] Fix crash when using threaded input and the first device goes away

2016-10-10 Thread Emil Velikov
Hi Hans, On Wednesday, 5 October 2016, Hans de Goede wrote: > When the xserver uses threaded input, it keeps a pointer to the InputInfo > passed into xf86AddEnabledDevice and calls pointer->read_input on events. > > But when the first enabled device goes away the pInfo