Re: [PATCH xf86-video-amdgpu] amdgpu_probe: Do not close server managed drm fds

2016-10-18 Thread Michel Dänzer
[ Moving to the amd-gfx mailing list, where xf86-video-amdgpu (and -ati) patches are reviewed ] On 18/10/16 11:48 PM, Hans de Goede wrote: > This fixes the xserver only seeing AMD/ATI devices supported by the amdgpu > driver, as by the time xf86-video-ati gets a chance to probe them, the > fd

Re: [PATCH libX11 3/4] Fixes: warning: variable 'req' set but not,used

2016-10-18 Thread Peter Hutterer
On Sat, Jun 04, 2016 at 05:19:59PM +0200, walter harms wrote: > Fixes: warning: variable 'req' set but not used [-Wunused-but-set-variable] >by marking req _X_UNUSED > Solution was discussed on xorg-devel ML >Peter Hutter, Alan Coopersmith > Re: [PATCH libX11 3/5]

Re: [PATCH xserver] glamor: Isolate GLX client code to its own library

2016-10-18 Thread Eric Anholt
Adam Jackson writes: > This is a step towards making libglamor_egl and Xwayland not link > against libGL (which brings in client-side libraries, which is just > icky). Is it actually necessary? Given that the epoxy GLX symbols always exist, and we're linking against epoxy, it

[PATCH xserver] glamor: Isolate GLX client code to its own library

2016-10-18 Thread Adam Jackson
This is a step towards making libglamor_egl and Xwayland not link against libGL (which brings in client-side libraries, which is just icky). Signed-off-by: Adam Jackson --- glamor/Makefile.am | 13 +++-- glamor/glamor_glx_stubs.c | 37

Re: [PATCH] xfree86: Xorg.wrap: Do not require root rights for cards with 0 outputs

2016-10-18 Thread Eric Engestrom
On Tuesday, 2016-10-18 16:36:32 +0200, Hans de Goede wrote: > Prior to this commit the Xorg.wrap code to detect if root rights > are necessary checked for DRM_IOCTL_MODE_GETRESOURCES succeeding *and* > reporting more then 0 output connectors. > > DRM_IOCTL_MODE_GETRESOURCES succeeding alone is

[PATCH xf86-video-amdgpu] amdgpu_probe: Do not close server managed drm fds

2016-10-18 Thread Hans de Goede
This fixes the xserver only seeing AMD/ATI devices supported by the amdgpu driver, as by the time xf86-video-ati gets a chance to probe them, the fd has been closed. This fixes e.g. Xorg not seeing the dGPU on a Lenovo Thinkpad E465 laptop with a CARRIZO iGPU and a HAINAN dGPU. Signed-off-by:

[PATCH] xfree86: Xorg.wrap: Do not require root rights for cards with 0 outputs

2016-10-18 Thread Hans de Goede
Prior to this commit the Xorg.wrap code to detect if root rights are necessary checked for DRM_IOCTL_MODE_GETRESOURCES succeeding *and* reporting more then 0 output connectors. DRM_IOCTL_MODE_GETRESOURCES succeeding alone is enough to differentiate between old drm only cards (which need ums and

Re: [PATCH v3 xserver] modesetting: fix glamor ifdef

2016-10-18 Thread Jon Turney
On 15/10/2016 05:13, Mihail Konev wrote: Add a missing ifdef needed for --disable-glamor. Signed-off-by: Mihail Konev Reviewed-by: Jon Turney ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xf86-input-libinput] Swap the registered input device on DEVICE_OFF when needed

2016-10-18 Thread Hans de Goede
Hi, On 18-10-16 03:47, Peter Hutterer wrote: If we don't swap out the pInfo previously passed to xf86AddEnabledDevice(), the thread eventually calls read_input on a struct that has been deleted. Avoid this by swapping out the to-be-destroyed pInfo with the first one we find. Reproducer: sudo

Re: [PATCH libX11 3/4] Fixes: warning: variable 'req' set but not, used

2016-10-18 Thread Ulrich Sibiller
On Sat, Jun 4, 2016 at 5:19 PM, walter harms wrote: > Fixes: warning: variable 'req' set but not used [-Wunused-but-set-variable] >by marking req _X_UNUSED > Solution was discussed on xorg-devel ML >Peter Hutter, Alan Coopersmith > Re: [PATCH libX11

Re: [PATCH xserver] inputthread: leave the main thread's name as-is

2016-10-18 Thread Jeremy Huddleston Sequoia
Shouldn't glibc be fixed instead? Why punish the platforms that do it right? --Jeremy > On Oct 17, 2016, at 21:13, Peter Hutterer wrote: > > On Linux, setting the main thread's name changes the program name > (/proc/self/comm). Setting it to MainThread breaks scripts