Re: [PATCH libx11] Plug a memory leak

2016-10-25 Thread Peter Hutterer
On Tue, Oct 25, 2016 at 09:30:15PM +0200, Emilio Pozuelo Monfort wrote: > This was introduced in 8ea762f. > > Reported-by: Julien Cristau > Signed-off-by: Emilio Pozuelo Monfort pushed, thanks. 8f349fe..20a3f99 master -> master Cheers, Peter > --- > src/FontNames.c | 2 ++ > 1 file c

[PATCH xf86-input-libinput] Don't init the AccelSpeed/LeftHanded properties on the base tablet device

2016-10-25 Thread Peter Hutterer
This device never sends events, no point in exposing these options Signed-off-by: Peter Hutterer --- src/xf86libinput.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/xf86libinput.c b/src/xf86libinput.c index 8ee6cbe..07b4d4e 100644 --- a/src/xf86libinput.c +++ b/s

Re: [PATCH xserver] xwayland: Transform pointer enter event coordinates

2016-10-25 Thread Jonas Ådahl
On Tue, Oct 25, 2016 at 07:24:49PM +0200, Rui Matos wrote: > Pointer enter event coordinates are surface relative and we need them > to be screen relative for pScreen->SetCursorPosition(). > > https://bugzilla.gnome.org/show_bug.cgi?id=758283 > > Signed-off-by: Rui Matos Reviewed-by: Jonas Ådah

Re: EXT: Re: [xserver-xorg][PATCH V2 1/1] xwayland-shm: block signals during fallocate

2016-10-25 Thread Ian Ray
On Thu, May 26, 2016 at 04:43:44PM +0100, Daniel Stone wrote: > On 25 May 2016 at 08:41, Ian Ray wrote: > > posix_fallocate() does an explicit rollback if it gets EINTR, and > > this is a problem on slow systems because when the allocation size > > is sufficiently large posix_fallocate() will alwa

Re: [PATCH libxi 2/2] Check that allocating a buffer succeeded

2016-10-25 Thread Peter Hutterer
On Tue, Oct 25, 2016 at 09:31:19PM +0200, Emilio Pozuelo Monfort wrote: > Since we are going to write into the buffer, we should make sure the > allocation didn't fail. > > Reported-by: Julien Cristau > Signed-off-by: Emilio Pozuelo Monfort both applied, thanks. 1bdeb43..4c5c8d6 master ->

Re: [PATCH xserver] glamor: don't look for non-existing EGL_KHR_platform_base

2016-10-25 Thread Adam Jackson
On Fri, 2016-10-21 at 19:06 +0100, Emil Velikov wrote: > > From: Emil Velikov > > The extensions does not exist in the registry, thus needs to know > they're using EGL 1.5 in order to determine the eglGetPlatformDisplay > function pointer is valid. > > Thus brings us into some lovely circular de

[PATCH libxi 2/2] Check that allocating a buffer succeeded

2016-10-25 Thread Emilio Pozuelo Monfort
Since we are going to write into the buffer, we should make sure the allocation didn't fail. Reported-by: Julien Cristau Signed-off-by: Emilio Pozuelo Monfort --- src/XIQueryDevice.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/XIQueryDevice.c b/src/XIQueryDevi

[PATCH libxi 1/2] Plug a memory leak

2016-10-25 Thread Emilio Pozuelo Monfort
Introduced in commit 19a9cd6. Reported-by: Julien Cristau Signed-off-by: Emilio Pozuelo Monfort --- src/XIQueryDevice.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/XIQueryDevice.c b/src/XIQueryDevice.c index a457cd6..e3b0c9f 100644 --- a/src/XIQueryDevice.c +++ b/src/XIQueryDevice

[PATCH libx11] Plug a memory leak

2016-10-25 Thread Emilio Pozuelo Monfort
This was introduced in 8ea762f. Reported-by: Julien Cristau Signed-off-by: Emilio Pozuelo Monfort --- src/FontNames.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/FontNames.c b/src/FontNames.c index e55f338..3e23b5f 100644 --- a/src/FontNames.c +++ b/src/FontNames.c @@ -98,12 +98,1

Re: [PATCH xserver] xwayland: Transform pointer enter event coordinates

2016-10-25 Thread Eric Engestrom
On Tuesday, 2016-10-25 19:24:49 +0200, Rui Matos wrote: > Pointer enter event coordinates are surface relative and we need them > to be screen relative for pScreen->SetCursorPosition(). > > https://bugzilla.gnome.org/show_bug.cgi?id=758283 > > Signed-off-by: Rui Matos LGTM :) Reviewed-by: Eric

[PATCH xserver] xwayland: Transform pointer enter event coordinates

2016-10-25 Thread Rui Matos
Pointer enter event coordinates are surface relative and we need them to be screen relative for pScreen->SetCursorPosition(). https://bugzilla.gnome.org/show_bug.cgi?id=758283 Signed-off-by: Rui Matos --- hw/xwayland/xwayland-input.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) di

Re: [PATCH xserver] configure.ac: bump epoxy requirement to 1.2

2016-10-25 Thread Adam Jackson
On Tue, 2016-10-25 at 08:50 -0700, Eric Anholt wrote: > I've said it before a couple of times, but it stands: The next step for > epoxy is that someone needs to look into YaronCT's fork and decide if we > should just bless it as the maintained upstream. Just read through the diff between your bra

Re: [PATCH xserver] configure.ac: bump epoxy requirement to 1.2

2016-10-25 Thread Eric Anholt
Adam Jackson writes: > On Mon, 2016-10-24 at 12:19 -0700, Matt Turner wrote: >> On Mon, Oct 24, 2016 at 2:39 AM, Emil Velikov >> wrote: >> > > > From: Emil Velikov >> > >> > As pointed out in the ABI tracker[1], epoxy has gone through a few >> > non-backwards compatible ABI changes, yet prese

Re: [PATCH] ramdac: Check sPriv != NULL in xf86CheckHWCursor()

2016-10-25 Thread Hans de Goede
Hi, On 25-10-16 00:25, Alex Goins wrote: xf86CheckHWCursor() would dereference sPriv without NULL checking it. If Option "SWCursor" is specified, sPriv == NULL. In this case we should assume that HW cursors are not supported. Signed-off-by: Alex Goins Reviewed-by: Andy Ritger Patch looks go

Re: [PATCH] ramdac: Check sPriv != NULL in xf86CheckHWCursor()

2016-10-25 Thread walter harms
Am 25.10.2016 00:25, schrieb Alex Goins: > xf86CheckHWCursor() would dereference sPriv without NULL checking it. If > Option > "SWCursor" is specified, sPriv == NULL. In this case we should assume that HW > cursors are not supported. > > Signed-off-by: Alex Goins > Reviewed-by: Andy Ritger >