Re: [PATCH xts v2] xts5: Fix clang error - non-void function 'outfile' should return a value

On Thu, Nov 24, 2016 at 09:54:14PM -0500, Rhys Kidd wrote: > files.c:267:3: error: non-void function 'outfile' should return a value > [-Wreturn-type] > return; > ^ > > v2: Correct declaration (Peter Hutterer) thanks, pushed 1a7eea0..6f2e907 master ->

[PATCH xts v2] xts5: Fix clang error - non-void function 'outfile' should return a value

files.c:267:3: error: non-void function 'outfile' should return a value [-Wreturn-type] return; ^ v2: Correct declaration (Peter Hutterer) --- xts5/src/bin/mc/files.c | 2 +- xts5/src/bin/mc/mcproto.h | 2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH xserver] xwayland: fix order of calloc() args

On Wed, Nov 23, 2016 at 09:54:27AM +0200, Pekka Paalanen wrote: > From: Pekka Paalanen > > The definition by the manual is: > calloc(size_t nmemb, size_t size) > > Swap the arguments of calloc() calls to be the right way around. > > Presumably this makes

Re: [PATCH util-modular 6/6] release.sh: run ./configure within the release.sh

On Fri, Nov 11, 2016 at 03:45:29PM +, Emil Velikov wrote: > From: Emil Velikov > > At the moment one has to run autogen.sh/configure in their checkout > prior to using release.sh > > We can "spare" that by folding it into the script. As a side effect this > gives

[PATCH xserver] xwayland: Don't send KeyRelease events on wl_keyboard::leave

Commits 816015648ffe660ddaa0f7d4d192e555b723c372 and fee0827a9a695600765f3d04376fc9babe497401 made it so that wl_keyboard::enter doesn't result in X clients getting KeyPress events while still updating our internal xkb state to be in sync with the host compositor. wl_keyboard::leave needs to be

[RFC xserver 2/3] xwayland: fix 'buffer' may be used uninitialized warning

From: Pekka Paalanen Fix the following warning due to --disable-glamor: CC Xwayland-xwayland.o In file included from /home/pq/local/include/wayland-client.h:40:0, from xwayland.h:35, from xwayland.c:26: xwayland.c: In

[RFC xserver 0/3] Allow XWM to control Xwayland commits

From: Pekka Paalanen Hi, this is probably the first time I'm sending patches for the xserver, so pointing out API misuse, coding style issues etc. would be appreciated. The last patch also has some XXX comments with questions. The first patch, refactoring, is

[RFC xserver 3/3] Xwayland: use _XWAYLAND_ALLOW_COMMITS property

From: Pekka Paalanen The X11 window manager (XWM) of a Wayland compositor can use the _XWAYLAND_ALLOW_COMMITS property to control when Xwayland sends wl_surface.commit requests. If the property is not set, the behaviour remains what it was. XWM uses the property

[RFC xserver 1/3] xwayland: refactor into xwl_window_post_damage()

From: Pekka Paalanen Refactor xwl_screen_post_damage() and split the window specific code into a new function xwl_window_post_damage(). This is a pure refactoring, there are no behavioral changes. An assert is added to xwl_window_post_damage() to ensure frame