Re: [RFC xserver 0/3] Allow XWM to control Xwayland commits

2016-12-05 Thread Olivier Fourdan
Hey On 5 December 2016 at 22:43, Adam Jackson wrote: > (apologies for being so slow to get to this thread, this is great stuff) > > On Mon, 2016-11-28 at 15:47 +0200, Pekka Paalanen wrote: > [...] > > > Mind, I am mostly thinking this in Weston XWM terms, which draws the > > window decorations t

Re: startx(1) low hanging fruit buglet for > 1 year in bugzilla

2016-12-05 Thread Olivier Fourdan
Hi, > Esteemed X11 developers, > > may I direct your attention to a shell scripting buglet in startx(1), as > reported in https://bugs.freedesktop.org/show_bug.cgi?id=91811 which > sits there for more than a year now? Fix included. This is very low > hanging fruit for improving the code. If the f

startx(1) low hanging fruit buglet for > 1 year in bugzilla

2016-12-05 Thread Jens Schweikhardt
Esteemed X11 developers, may I direct your attention to a shell scripting buglet in startx(1), as reported in https://bugs.freedesktop.org/show_bug.cgi?id=91811 which sits there for more than a year now? Fix included. This is very low hanging fruit for improving the code. If the fix can be improve

Re: [RFC xserver 0/3] Allow XWM to control Xwayland commits

2016-12-05 Thread Adam Jackson
(apologies for being so slow to get to this thread, this is great stuff) On Mon, 2016-11-28 at 15:47 +0200, Pekka Paalanen wrote: > Hi, > > having read the above two specs, it is very much not obvious how to > connect all the dots. It needs experimenting. > > Would it be acceptable to build the

Re: [xserver PULL master] randr fixes + primary GPU fallback

2016-12-05 Thread Adam Jackson
On Mon, 2016-12-05 at 11:39 +0100, Hans de Goede wrote: > The following changes since commit e1d30075c923f96a375895d74ea12a3c92a640c6: > >    configure: Enable glamor when building just Xwayland (2016-11-30 09:47:43 > +0100) > > are available in the git repository at: > >    git://people.freed

Re: [RFC xserver 3/3] Xwayland: use _XWAYLAND_ALLOW_COMMITS property

2016-12-05 Thread Pekka Paalanen
On Mon, 5 Dec 2016 09:59:46 -0500 (EST) Olivier Fourdan wrote: > Hi Pekka, > > > [...] > > Patches 1 and 2 OTOH would be ready for merging on my behalf. > > Yes, I think the two first patches are fine. Hi Olivier, thank you for the reviews! > > Olivier asked about _NET_WM_SYNC_REQUEST - do

Re: [RFC xserver 2/3] xwayland: fix 'buffer' may be used uninitialized warning

2016-12-05 Thread Olivier Fourdan
> From: Pekka Paalanen > > Fix the following warning due to --disable-glamor: > > CC Xwayland-xwayland.o > In file included from /home/pq/local/include/wayland-client.h:40:0, > from xwayland.h:35, > from xwayland.c:26: > xwayland.c: In function ‘block_ha

Re: [RFC xserver 1/3] xwayland: refactor into xwl_window_post_damage()

2016-12-05 Thread Olivier Fourdan
> From: Pekka Paalanen > > Refactor xwl_screen_post_damage() and split the window specific code > into a new function xwl_window_post_damage(). > > This is a pure refactoring, there are no behavioral changes. An assert > is added to xwl_window_post_damage() to ensure frame callbacks are not > le

Re: [RFC xserver 3/3] Xwayland: use _XWAYLAND_ALLOW_COMMITS property

2016-12-05 Thread Olivier Fourdan
Hi Pekka, > [...] > Patches 1 and 2 OTOH would be ready for merging on my behalf. Yes, I think the two first patches are fine. > Olivier asked about _NET_WM_SYNC_REQUEST - do you want me to fully > implement the basic sync protocol too before accepting this series? I was hoping/wondering if us

patchwork.freedesktop.org Re: [xserver PULL master] randr fixes + primary GPU fallback

2016-12-05 Thread walter harms
Am 05.12.2016 11:39, schrieb Hans de Goede: > Hi Adam, Keith, > > > > p.s. > > Talking about unreviewed patched it would be really good to get > a review of / some discussion on: > > https://patchwork.freedesktop.org/patch/112579/ > > Which is the last magic sauce in the Fedora xserver pkg

Re: [RFC xserver 3/3] Xwayland: use _XWAYLAND_ALLOW_COMMITS property

2016-12-05 Thread Pekka Paalanen
On Mon, 5 Dec 2016 14:03:04 +0200 Pekka Paalanen wrote: > On Thu, 24 Nov 2016 15:40:37 +0200 > Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > The X11 window manager (XWM) of a Wayland compositor can use the > > _XWAYLAND_ALLOW_COMMITS property to control when Xwayland sends > > wl_s

Re: [RFC xserver 3/3] Xwayland: use _XWAYLAND_ALLOW_COMMITS property

2016-12-05 Thread Pekka Paalanen
On Thu, 24 Nov 2016 15:40:37 +0200 Pekka Paalanen wrote: > From: Pekka Paalanen > > The X11 window manager (XWM) of a Wayland compositor can use the > _XWAYLAND_ALLOW_COMMITS property to control when Xwayland sends > wl_surface.commit requests. If the property is not set, the behaviour > remain

[PATCH xf86-video-intel] sna: Add missing NULL check for readdir result in has_connector_backlight

2016-12-05 Thread James Clarke
Signed-off-by: James Clarke --- src/sna/sna_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/sna/sna_display.c b/src/sna/sna_display.c index 1d31d008..f6b6e5be 100644 --- a/src/sna/sna_display.c +++ b/src/sna/sna_display.c @@ -1033,6 +1033,9 @@ static char *has_connector_backl

[xserver PULL master] randr fixes + primary GPU fallback

2016-12-05 Thread Hans de Goede
Hi Adam, Keith, Here is a pull-req consisting of 2 different patch-sets: 1) 2 randr fixes for sometimes the screen pixmap being too small when using slave outputs, these have been Reviewed-by Dave Airlie 2) 3 xfree86 patches which together make the xserver choice the first available device, rat

Re: [PATCH xserver 1/3] xfree86: Immediately handle failure to set HW cursor, v5

2016-12-05 Thread Hans de Goede
Hi, On 05-12-16 10:25, Michael Thayer wrote: Hello Hans, Polite ping on this one. I've already given this series my: Reviewed-by: Hans de Goede There is not much else I can do, from here on it is up to the xserver maintainers to pick up the series. Regards, Hans Regards and thanks M

Re: [PATCH xserver 1/3] xfree86: Immediately handle failure to set HW cursor, v5

2016-12-05 Thread Michael Thayer
Hello Hans, Polite ping on this one. Regards and thanks Michael 01.10.2016 12:01, Hans de Goede wrote: Hi, On 30-09-16 17:55, Michael Thayer wrote: Based on v4 by Alexandre Courbot There is currently no reliable way to report failure to set a HW cursor. Still such failures can happen if e.

Re: [PATCH xf86-input-libinput] Fix default scroll button number

2016-12-05 Thread Hans de Goede
Hi, On 05-12-16 05:35, Peter Hutterer wrote: Was exposing the evdev code rather than the xorg code. Signed-off-by: Peter Hutterer Patch LGTM: Reviewed-by: Hans de Goede Regards, Hans --- src/xf86libinput.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/xf86libinput.c b/sr