Re: [PATCH xserver v2] present: Only call present_flip_notify if vblank->queued == FALSE

2017-01-07 Thread Alex Deucher
On Sat, Jan 7, 2017 at 3:36 AM, Michel Dänzer wrote: > > Any takers? > > In the absence of a negative review, I'll push this next week, since > more people are running into this. Reviewed-by: Alex Deucher > > > On 28/11/16 10:54 AM, Michel Dänzer

Re: [PATCH libXrandr] Avoid out of boundary accesses on illegal responses

2017-01-07 Thread Tobias Stoeckmann
Hi Julien, On Sat, Jan 07, 2017 at 07:03:17PM +0100, Julien Cristau wrote: > It looks like we're leaking 'attr' on these error paths? confirmed. That is what I get for copying the error handling of the attr == NULL case... diff --git a/src/XrrCrtc.c b/src/XrrCrtc.c index 6665092..8316b78

Re: [PATCH libXrandr] Avoid out of boundary accesses on illegal responses

2017-01-07 Thread Julien Cristau
[resending with xorg-devel cc added which I forgot the first time around] On Sun, Sep 25, 2016 at 22:50:44 +0200, Matthieu Herrb wrote: > diff --git a/src/XrrCrtc.c b/src/XrrCrtc.c > index 5ae35c5..6665092 100644 > --- a/src/XrrCrtc.c > +++ b/src/XrrCrtc.c [...] > @@ -357,7 +378,7 @@

Re: [PATCH libX11] Fix wrong Xfree in XListFonts failure path

2017-01-07 Thread Alan Coopersmith
Reviewed-by: Alan Coopersmith Looks like this bug was introduced just after the 1.6.4 release and hasn't made it out into a libX11 release yet - thanks for catching it in time. -alan- On 01/ 7/17 07:20 AM, Julien Cristau wrote: 'ch' gets moved inside the

Re: [PATCH libXrender 1/2] Avoid OOB write in XRenderQueryFilters

2017-01-07 Thread Julien Cristau
On Sun, Sep 25, 2016 at 22:50:45 +0200, Matthieu Herrb wrote: > From: Tobias Stoeckmann > > The memory for filter names is reserved right after receiving the reply. > After that, filters are iterated and each individual filter name is > stored in that reserved memory. >

[PATCH libX11] Fix wrong Xfree in XListFonts failure path

2017-01-07 Thread Julien Cristau
'ch' gets moved inside the allocated buffer as we're looping through fonts, so keep a reference to the start of the buffer so we can pass that to Xfree in the failure case. Fixes: commit 20a3f99eba5001925b8b313da3accb7900eb1927 "Plug a memory leak" Signed-off-by: Julien Cristau

[PATCH] Add "s query" to print screen saver state and timing.

2017-01-07 Thread Nicolas George
The output looks like: state = 0 (off) kind = 1 (internal) until = 557900 (0:09:17.900) idle = 42100 (0:00:42.100) event_mask = 0 Signed-off-by: Nicolas George --- configure.ac | 2 ++ man/xset.man | 2 +- xset.c | 42 +- 3 files

Re: [PATCH xserver v2] present: Only call present_flip_notify if vblank->queued == FALSE

2017-01-07 Thread Michel Dänzer
Any takers? In the absence of a negative review, I'll push this next week, since more people are running into this. On 28/11/16 10:54 AM, Michel Dänzer wrote: > From: Michel Dänzer > > We are no longer using the present_flip_queue list only for presents > which have