Re: [RFC PATCH xserver v3] xwayland: Monitor client states to destroy callbacks

2017-03-08 Thread Olivier Fourdan
> > > > Reviewed-by: Michel Dänzer > > > > Should probably ask Mark Blakeney to test this patch though. > > Good idea! Done in https://bugs.freedesktop.org/show_bug.cgi?id=100040#c6 The new patch has been successfully tested in bug 100040 - Thanks Mark! Fixes:

Re: [PATCH xserver] test: Use correct signature for XISetEventMask wrapper

2017-03-08 Thread Peter Hutterer
On Wed, Mar 08, 2017 at 11:46:27PM +, Jon Turney wrote: > This looks like it's always been wrong, but didn't matter before the single > test binary changes as the wrapper was only in place for tests which didn't > care about it's effects, so didn't forward to the real implementation. (see >

Re: [PATCH app/xkbcomp] Add xkboutputdir to xkbcomp.pc

2017-03-08 Thread Peter Hutterer
On Wed, Mar 08, 2017 at 11:51:20AM -0500, Adam Jackson wrote: > On Wed, 2017-03-08 at 13:45 +, Emil Velikov wrote: > > > > > > Right, so I was confused. The "compiled" xkb path and README.compiled > > are provided by Xorg, but what's not obvious is - who is the user of > > said path/files ?

[PATCH v2 xf86-video-dummy] Add glamor acceleration which enables native OpenGL support (v2)

2017-03-08 Thread Qiang Yu
v2: Update configure.ac for auto enable glamor support and print corresponding error message when necessary. Enable glamor acceleration in xorg.conf by: Section "Device" ... Driver "dummy" Option "Render" "/dev/dri/renderD128" ... EndSection GPU is chosen by the Render option which

[PATCH xserver] test: Use correct signature for XISetEventMask wrapper

2017-03-08 Thread Jon Turney
This looks like it's always been wrong, but didn't matter before the single test binary changes as the wrapper was only in place for tests which didn't care about it's effects, so didn't forward to the real implementation. (see the changes to protocol-xiselectevents.c in 773fc07e) This fixes the

Re: [PATCH v2 util-modular] release.sh: create a worktree structure that's out of reach of libtool

2017-03-08 Thread Emil Velikov
On 8 March 2017 at 22:23, Peter Hutterer wrote: > The comment in the diff says it all, we need to put our worktree root at least > two directories away from our normal checkout because most repos don't have > AC_CONFIG_AUX_DIR() set. > > This fixes the issue of

[PATCH v2 util-modular] release.sh: create a worktree structure that's out of reach of libtool

2017-03-08 Thread Peter Hutterer
The comment in the diff says it all, we need to put our worktree root at least two directories away from our normal checkout because most repos don't have AC_CONFIG_AUX_DIR() set. This fixes the issue of release.sh failing in git trees that haven't been git cleaned: ERROR: files left in

Re: [PATCH util-modular] release.sh: create a worktree structure that's out of reach of libtool

2017-03-08 Thread Emil Velikov
On 8 March 2017 at 20:50, Peter Hutterer wrote: > On Wed, Mar 08, 2017 at 02:18:23PM +, Emil Velikov wrote: >> On 8 March 2017 at 08:21, Peter Hutterer wrote: >> > The comment in the diff says it all, we need to put our worktree root at >>

Re: [PATCH util-modular] release.sh: create a worktree structure that's out of reach of libtool

2017-03-08 Thread Peter Hutterer
On Wed, Mar 08, 2017 at 02:18:23PM +, Emil Velikov wrote: > On 8 March 2017 at 08:21, Peter Hutterer wrote: > > The comment in the diff says it all, we need to put our worktree root at > > least > > two directories away from our normal checkout. > > > > This fixes

Re: [PATCH util-modular] release.sh: create a worktree structure that's out of reach of libtool

2017-03-08 Thread Matt Turner
On Wed, Mar 8, 2017 at 12:21 AM, Peter Hutterer wrote: > +# libtool will search down to ../.. for install-sh and then just gess typo: guess ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH app/xkbcomp] Add xkboutputdir to xkbcomp.pc

2017-03-08 Thread Emil Velikov
On 8 March 2017 at 16:51, Adam Jackson wrote: > On Wed, 2017-03-08 at 13:45 +, Emil Velikov wrote: > >> > >> Right, so I was confused. The "compiled" xkb path and README.compiled >> are provided by Xorg, but what's not obvious is - who is the user of >> said path/files ? >>

Re: [PATCH xserver] sdksyms: Tighten up the symbols we add to the magic table

2017-03-08 Thread Jon Turney
On 06/03/2017 22:20, Adam Jackson wrote: On Mon, 2017-03-06 at 18:23 +, Jon Turney wrote: Unfortunately, one of the possible definitions of _X_EXPORT in Xfuncproto.h is empty, in which case, this leaves us with nothing in sdksyms.c Though this be true, I'm not sure how it can matter. We

Re: [PATCH app/xkbcomp] Add xkboutputdir to xkbcomp.pc

2017-03-08 Thread Adam Jackson
On Wed, 2017-03-08 at 13:45 +, Emil Velikov wrote: > > > Right, so I was confused. The "compiled" xkb path and README.compiled > are provided by Xorg, but what's not obvious is - who is the user of > said path/files ? > This patch on its own does not make much sense, I'm afraid - we add a >

Re: [PATCH util-modular] release.sh: create a worktree structure that's out of reach of libtool

2017-03-08 Thread Emil Velikov
On 8 March 2017 at 08:21, Peter Hutterer wrote: > The comment in the diff says it all, we need to put our worktree root at least > two directories away from our normal checkout. > > This fixes the issue of release.sh failing in git trees that haven't been git > cleaned:

Re: [PATCH xf86-video-dummy] Add glamor acceleration which enables native OpenGL support

2017-03-08 Thread Emil Velikov
On 8 March 2017 at 01:04, Yu, Qiang wrote: > >> You want to AC_MSG_ERROR if the the option is set to "yes" and it's >> not available. Currently one silently ignores it, which is not good. > Right, so I need to make it "auto" by default? > If you change the current default to

Re: [PATCH app/xkbcomp] Add xkboutputdir to xkbcomp.pc

2017-03-08 Thread Emil Velikov
On 8 March 2017 at 05:08, Peter Hutterer wrote: > On Tue, Mar 07, 2017 at 09:31:54PM +, Emil Velikov wrote: >> HI Adam, >> >> On 7 March 2017 at 17:42, Adam Jackson wrote: >> > The X server (and everybody else, really) wants to know where to put >>

Re: [RFC PATCH xserver v3] xwayland: Monitor client states to destroy callbacks

2017-03-08 Thread Olivier Fourdan
> > > Reviewed-by: Michel Dänzer > > Should probably ask Mark Blakeney to test this patch though. Good idea! Done in https://bugs.freedesktop.org/show_bug.cgi?id=100040#c6 Cheers, Olivier ___ xorg-devel@lists.x.org: X.Org

Re: [RFC PATCH xserver v3] xwayland: Monitor client states to destroy callbacks

2017-03-08 Thread Michel Dänzer
On 08/03/17 06:50 PM, Michel Dänzer wrote: > On 08/03/17 06:32 PM, Olivier Fourdan wrote: >> Client resources can survive the client itself, in which case we >> may end up in our sync callback trying to access client's data after >> it's been freed/reclaimed. >> >> Add a ClientStateCallback

Re: [RFC PATCH xserver v3] xwayland: Monitor client states to destroy callbacks

2017-03-08 Thread Michel Dänzer
On 08/03/17 06:32 PM, Olivier Fourdan wrote: > Client resources can survive the client itself, in which case we > may end up in our sync callback trying to access client's data after > it's been freed/reclaimed. > > Add a ClientStateCallback handler to monitor the client state changes > and clear

[RFC PATCH xserver v3] xwayland: Monitor client states to destroy callbacks

2017-03-08 Thread Olivier Fourdan
Client resources can survive the client itself, in which case we may end up in our sync callback trying to access client's data after it's been freed/reclaimed. Add a ClientStateCallback handler to monitor the client state changes and clear the sync callback set up by the glamor drm code if any.

[PATCH util-modular] release.sh: create a worktree structure that's out of reach of libtool

2017-03-08 Thread Peter Hutterer
The comment in the diff says it all, we need to put our worktree root at least two directories away from our normal checkout. This fixes the issue of release.sh failing in git trees that haven't been git cleaned: ERROR: files left in build directory after distclean: ./config.sub