Re: [PATCH xserver] edid: Prune duplicates after adding modes from DDC

2017-03-20 Thread Michel Dänzer
On 20/03/17 02:32 PM, Chen, Xiaogang wrote: >> From: Michel Dänzer [mailto:mic...@daenzer.net] >> On 23/02/17 06:46 AM, Chen, Xiaogang wrote: From: Michel Dänzer [mailto:mic...@daenzer.net] Multiple calls to xf86EdidMonitorSet (which can be triggered e.g. by running

RE: [PATCH xserver] edid: Prune duplicates after adding modes from DDC

2017-03-20 Thread Chen, Xiaogang
> -Original Message- > From: Michel Dänzer [mailto:mic...@daenzer.net] > Sent: Thursday, March 09, 2017 2:25 AM > To: Chen, Xiaogang > Cc: xorg-devel@lists.x.org; jorge_monteag...@hotmail.com > Subject: Re: [PATCH xserver] edid: Prune duplicates after adding modes

Re: [PATCH xserver] dix: Remove PRIVATE_DAMAGE

2017-03-20 Thread Eric Anholt
Adam Jackson writes: > None of this is actually wired up to anything, so we can also remove the > devPrivates from the DamageRec. The DamageExtRec is what would need > devPrivates for selinux labeling, in principle. Reviewed-by: Eric Anholt signature.asc

Re: [PATCH xserver] Fix OOB access in ProcRecordUnregisterClients

2017-03-20 Thread Adam Jackson
On Sun, 2017-03-19 at 17:55 +0100, Tobias Stoeckmann wrote: > If a client sends a RecordUnregisterClients request with an nClients > field larger than INT_MAX / 4, an integer overflow leads to an > out of boundary access in RecordSanityCheckClientSpecifiers. > > An example line with libXtst would

Re: [PATCH xserver 2/2] glamor: Avoid software fallback for planemasked ZPixmap GetImage

2017-03-20 Thread Adam Jackson
On Mon, 2017-03-20 at 10:42 -0700, Eric Anholt wrote: > > Adam Jackson writes: > > @@ -128,6 +128,16 @@ glamor_get_image_gl(DrawablePtr drawable, int x, int > > y, int w, int h, > >    drawable->x + off_x, drawable->y + off_y, > >  

Re: [PATCH xserver 2/2] glamor: Avoid software fallback for planemasked ZPixmap GetImage

2017-03-20 Thread Eric Anholt
Adam Jackson writes: > Same trick as in fb: just do a normal GetImage and deal with the > planemask on the CPU if you have to. Since the software fallback hit for > glamor is pretty brutal, this is a much more impressive win for glamor > than it was for fb: > > 11100.0

[PATCH xserver] dix: Remove PRIVATE_DAMAGE

2017-03-20 Thread Adam Jackson
None of this is actually wired up to anything, so we can also remove the devPrivates from the DamageRec. The DamageExtRec is what would need devPrivates for selinux labeling, in principle. Signed-off-by: Adam Jackson --- dix/privates.c | 1 - include/privates.h

Re: [PATCH xserver 1/2] fb: Handle ZPixmap planemask in GetImage the other way around

2017-03-20 Thread Eric Anholt
Adam Jackson writes: > Formerly we'd zero the image data and then pull out a plane at a time. > It's faster to apply the planemask after the fact, since that turns the > GetImage into a memcpy: > > 10.0 101000.0 (1.010) (copy 0x) ShmGetImage 10x10 square >

Re: [PATCH] dri2: Sync i965_pci_ids.h from Mesa.

2017-03-20 Thread Adam Jackson
On Fri, 2017-03-17 at 14:42 -0700, Eric Anholt wrote: > > Kenneth Graunke writes: > > > Copied from Mesa with no modifications.  Gives us Geminilake PCI IDs. > > > > Signed-off-by: Kenneth Graunke > > Acked-by: Eric Anholt

[PATCH xserver] glx: Fix MakeCurrent with no drawables

2017-03-20 Thread Adam Jackson
GLX_ARB_create_context, which we aspire to support, allows making GL 3.0 or newer contexts current with null current drawables. Strictly this might not be legal for pre-3.0 contexts, but there's no harm in allowing it anyway. Signed-off-by: Adam Jackson --- glx/glxcmds.c | 39

Re: [PATCH xserver 2/2] glamor: Avoid software fallback for planemasked ZPixmap GetImage

2017-03-20 Thread Adam Jackson
On Wed, 2016-09-28 at 13:05 -0400, Adam Jackson wrote: > Same trick as in fb: just do a normal GetImage and deal with the > planemask on the CPU if you have to. Since the software fallback hit for > glamor is pretty brutal, this is a much more impressive win for glamor > than it was for fb: > >