Re: [PATCH 1/2] _XDefaultIOError: Reformat to be less ugly

2017-03-24 Thread Alan Coopersmith
On 03/24/17 08:07 AM, Adam Jackson wrote: Signed-off-by: Adam Jackson Reviewed-by: Alan Coopersmith for the series. -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering -

Re: [PATCH rendercheck 0/5] Convert to meson.

2017-03-24 Thread Kenneth Graunke
On Friday, March 24, 2017 2:13:38 PM PDT Mark Kettenis wrote: > > From: Eric Anholt > > Date: Fri, 24 Mar 2017 13:17:45 -0700 > > > > Having bitten off a bit more than I can chew in 3 days with the X > > Server (hw/xfree86/sdksyms.c is the worst), I decided to take a quick > >

Re: [PATCH rendercheck 0/5] Convert to meson.

2017-03-24 Thread Matt Turner
On Fri, Mar 24, 2017 at 2:13 PM, Mark Kettenis wrote: >> From: Eric Anholt >> Date: Fri, 24 Mar 2017 13:17:45 -0700 >> >> Having bitten off a bit more than I can chew in 3 days with the X >> Server (hw/xfree86/sdksyms.c is the worst), I decided to take a

Re: [PATCH rendercheck 0/5] Convert to meson.

2017-03-24 Thread Mark Kettenis
> From: Eric Anholt > Date: Fri, 24 Mar 2017 13:17:45 -0700 > > Having bitten off a bit more than I can chew in 3 days with the X > Server (hw/xfree86/sdksyms.c is the worst), I decided to take a quick > pass at converting a project that's my own fault. Seems I missed some

Re: [PATCH xserver 3/3] kdrive: Remove dead slots from KdCardFuncs

2017-03-24 Thread Eric Anholt
Adam Jackson writes: > @@ -645,34 +614,7 @@ KdCloseScreen(ScreenPtr pScreen) > static Bool > KdSaveScreen(ScreenPtr pScreen, int on) > { > -KdScreenPriv(pScreen); > -int dpmsState; > - > -if (!pScreenPriv->card->cfuncs->dpms) > -return FALSE; > - > -

Re: [PATCH xserver 1/3] xfree86: Clean up DPMS support

2017-03-24 Thread Eric Anholt
Adam Jackson writes: > On Fri, 2017-03-24 at 10:34 -0700, Eric Anholt wrote: >> > Adam Jackson writes: >> >> > Rather than setting up a per-screen private, just conditionally >> > initialize ScrnInfoRec::DPMSSet based on the config options, and inspect >> >

[PATCH rendercheck 4/5] Convert the manpage for Meson's configure script.

2017-03-24 Thread Eric Anholt
--- man/rendercheck.man | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/rendercheck.man b/man/rendercheck.man index b7be417d5c37..8b7dccab7725 100644 --- a/man/rendercheck.man +++ b/man/rendercheck.man @@ -1,5 +1,5 @@ .ds q \N'34' -.TH rendercheck 1 __xorgversion__ +.TH

[PATCH rendercheck 5/5] Explain how to build using meson in the README.

2017-03-24 Thread Eric Anholt
--- README | 8 1 file changed, 8 insertions(+) diff --git a/README b/README index f5af0b0c64eb..2f8ec1ab0e46 100644 --- a/README +++ b/README @@ -10,3 +10,11 @@ Tests currently include: - Linear gradients - Repeating sources/masks at POT and non-POT sizes - Some regression tests for

[PATCH rendercheck 1/5] Fix a printf format warning.

2017-03-24 Thread Eric Anholt
--- rendercheck.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rendercheck.h b/rendercheck.h index 1c392e8d69fd..7dc9dc95c38d 100644 --- a/rendercheck.h +++ b/rendercheck.h @@ -37,7 +37,7 @@ static inline void errx(int eval, const char *fmt, ...) { va_start(args, fmt);

[PATCH rendercheck 0/5] Convert to meson.

2017-03-24 Thread Eric Anholt
Having bitten off a bit more than I can chew in 3 days with the X Server (hw/xfree86/sdksyms.c is the worst), I decided to take a quick pass at converting a project that's my own fault. rendercheck is the best case scenario for autotools, and meson still cuts its build time to practically

[PATCH rendercheck 2/5] Add a meson build system.

2017-03-24 Thread Eric Anholt
Meson allows the configure step to be run faster (.3 seconds compared to autogen.sh's 3.9 seconds on my system) and a full rebuild (touch rendercheck.h; make) to run faster (.05s instead of .07s). Rendercheck is pretty much the best case scenario for autotools, with limited configure-time

[PATCH rendercheck 3/5] Remove the autotools build system.

2017-03-24 Thread Eric Anholt
--- .gitignore | 79 - Makefile.am | 43 --- autogen.sh | 17 - configure.ac| 29 - main.c | 6 - man/Makefile.am | 38 --- 6

[PATCH xserver 2/3] kdrive: Remove KdOsFuncs

2017-03-24 Thread Adam Jackson
Only the Init slot was used, and Xephyr can just as easily do that initialization directly. Signed-off-by: Adam Jackson --- hw/kdrive/ephyr/Makefile.am | 1 - hw/kdrive/ephyr/ephyr.h | 2 -- hw/kdrive/ephyr/ephyrinit.c | 5 - hw/kdrive/ephyr/os.c| 48

[PATCH xserver 3/3] kdrive: Remove dead slots from KdCardFuncs

2017-03-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- hw/kdrive/ephyr/ephyr.c | 27 -- hw/kdrive/ephyr/ephyrinit.c | 9 -- hw/kdrive/src/kcmap.c | 9 -- hw/kdrive/src/kdrive.c | 67 + hw/kdrive/src/kdrive.h | 9

[PATCH xserver 1/3] kdrive: static and dead code cleanup

2017-03-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- hw/kdrive/src/Makefile.am | 1 - hw/kdrive/src/kcmap.c | 2 +- hw/kdrive/src/kdrive.c| 116 ++ hw/kdrive/src/kdrive.h| 127 hw/kdrive/src/kinput.c| 253 ---

[PATCH xserver 0/3] Continue gutting kdrive

2017-03-24 Thread Adam Jackson
Having surreptitiously removed all the hardware backends from kdrive, there's some midlayer junk that can go too. I'd like to see the "kdrive" code proper split into either dix or xephyr as appropriate, and eventually rename the directory as hw/xephyr once we're happy with the split. One

Re: [PATCH xserver 1/3] xfree86: Clean up DPMS support

2017-03-24 Thread Adam Jackson
On Fri, 2017-03-24 at 10:34 -0700, Eric Anholt wrote: > > Adam Jackson writes: > > > Rather than setting up a per-screen private, just conditionally > > initialize ScrnInfoRec::DPMSSet based on the config options, and inspect > > that to determine whether DPMS is supported. > >

Re: [PATCH xserver 1/3] xfree86: Clean up DPMS support

2017-03-24 Thread Eric Anholt
Adam Jackson writes: > Rather than setting up a per-screen private, just conditionally > initialize ScrnInfoRec::DPMSSet based on the config options, and inspect > that to determine whether DPMS is supported. > > We also move the "turn the screen back on at CloseScreen" logic

[PATCH xserver 1/3] xfree86: Clean up DPMS support

2017-03-24 Thread Adam Jackson
Rather than setting up a per-screen private, just conditionally initialize ScrnInfoRec::DPMSSet based on the config options, and inspect that to determine whether DPMS is supported. We also move the "turn the screen back on at CloseScreen" logic into the DPMS extension's (new) reset hook. This

[PATCH xserver 3/3] dpms: Consolidate a bunch of stuff into Xext/dpms.c

2017-03-24 Thread Adam Jackson
Most of this is a legacy of the old "extmod" design where you could load _some_ extensions dynamically but only if the server had been built with support for them in the first place. Note that since we now only initialize the DPMS extension if at least one screen supports it, we no longer need

[PATCH xserver 2/3] dix: Lift DPMS to a screen hook

2017-03-24 Thread Adam Jackson
Following on from the previous change, this adds a DPMS hook to the ScreenRec and uses that to infer DPMS support. As a result we can drop the dpms stub code from Xext. Signed-off-by: Adam Jackson --- Xext/Makefile.am | 4 +- Xext/dpms.c | 64

Re: [PATCH xrandr] xrandr: suppress misleading indentation warning

2017-03-24 Thread Adam Jackson
On Wed, 2017-01-18 at 08:52 +0100, Giuseppe Bilotta wrote: > When printing out rotations, we print a space before any item other than > the first, and set `first = False` in each block where we print. > However, this is done in the same line as the conditional that checks if > first is set, which

[PATCH 2/2] _XDefaultIOError: Do better at detecting explicit shutdown

2017-03-24 Thread Adam Jackson
Currently, when the X server crashes or a client is disconnected with XKillClient, you get a somewhat confusing error message from libX11 along the lines of: XIO: fatal IO error 11 (Resource temporarily unavailable) on X server ":0" after 98 requests (40 known processed) with 0 events

[PATCH 1/2] _XDefaultIOError: Reformat to be less ugly

2017-03-24 Thread Adam Jackson
Signed-off-by: Adam Jackson --- src/XlibInt.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/XlibInt.c b/src/XlibInt.c index 4c8eaeb..d5946bd 100644 --- a/src/XlibInt.c +++ b/src/XlibInt.c @@ -1242,24 +1242,24 @@ int

Re: [PATCH xserver] xf86: dri2: Use va_gl as vdpau_driver for Intel i965 GPUs

2017-03-24 Thread Emil Velikov
Hi Hans, On 23 March 2017 at 12:31, Hans de Goede wrote: > The modesetting driver (which now often is used with Intel GPUs), > relies on dri2_probe_driver_name() to get the dri and vdpau driver > names, before this commit it would always assign the same name to > the 2