Re: [PATCH rendercheck 0/5] Convert to meson.

On Fri, Mar 24, 2017 at 01:17:45PM -0700, Eric Anholt wrote: > Having bitten off a bit more than I can chew in 3 days with the X > Server (hw/xfree86/sdksyms.c is the worst), I decided to take a quick > pass at converting a project that's my own fault. > > rendercheck is the best case scenario

Re: [PATCH xserver 3/2] Rewrite the byte swapping macros.

On Mon, Mar 27, 2017 at 03:11:03PM -0700, Eric Anholt wrote: > The clever pointer tricks were actually not working, and we were doing > the byte-by-byte moves in general. By just doing the memcpy and > obvious byte swap code, we end up generating actual byte swap > instructions, thanks to

[PATCH rendercheck 1/2] Fix errx handling of va_list

And set the function attribute to printf-style Signed-off-by: Peter Hutterer --- rendercheck.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/rendercheck.h b/rendercheck.h index 7dc9dc9..89db20d 100644 --- a/rendercheck.h +++ b/rendercheck.h

[PATCH rendercheck 2/2] Add a linebreak after printing the version

--- main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.c b/main.c index 20f5502..5ec8090 100644 --- a/main.c +++ b/main.c @@ -290,7 +290,7 @@ int main(int argc, char **argv) /* Print the version string. Bail out if --version was requested and *

Re: [PATCH rendercheck 4/5] Convert the manpage for Meson's configure script.

On Fri, Mar 24, 2017 at 01:17:49PM -0700, Eric Anholt wrote: > --- > man/rendercheck.man | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man/rendercheck.man b/man/rendercheck.man > index b7be417d5c37..8b7dccab7725 100644 > --- a/man/rendercheck.man > +++

[PATCH xserver 3/2] Rewrite the byte swapping macros.

The clever pointer tricks were actually not working, and we were doing the byte-by-byte moves in general. By just doing the memcpy and obvious byte swap code, we end up generating actual byte swap instructions, thanks to optimizing compilers. text data bss dec hex

Re: [PATCH xserver 2/2] glx: Use the same endian swapping as the rest of the server.

Eric Anholt writes: > This dumps a ton of configure-time checks for system endian macros. > Given that we're marking the mixed-endian fixup code as cold, getting > at the system macros is a waste of code. > > Signed-off-by: Eric Anholt Yeah, this seems

Re: [PATCH xserver 1/2] configure: Stop checking for XdmcpWrap

Eric Anholt writes: > As far back as the initial import, it seems to have been exposed, and > there's no explanation why the test happened in the initial xserver > import. We weren't initially allowed to export interfaces to crypto routines when this code was written. >

[PATCH xserver 2/2] glx: Use the same endian swapping as the rest of the server.

This dumps a ton of configure-time checks for system endian macros. Given that we're marking the mixed-endian fixup code as cold, getting at the system macros is a waste of code. Signed-off-by: Eric Anholt --- configure.ac| 60

[PATCH xserver 1/2] configure: Stop checking for XdmcpWrap

As far back as the initial import, it seems to have been exposed, and there's no explanation why the test happened in the initial xserver import. Signed-off-by: Eric Anholt --- configure.ac | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/configure.ac

Re: [PATCH xserver 1/3] xfree86: Clean up DPMS support

On Mon, 2017-03-27 at 10:40 -0700, Eric Anholt wrote: > > Adam Jackson writes: > > > Rather than setting up a per-screen private, just conditionally > > initialize ScrnInfoRec::DPMSSet based on the config options, and inspect > > that to determine whether DPMS is supported. > >

Re: [PATCH] dmx: Fix null pointer dereference

On Sun, 2017-03-12 at 14:21 +0100, Tobias Stoeckmann wrote: > A null pointer dereference can occur in dmxSync, because TimerForce > does not handle a null pointer. > > dmxSyncTimer is set to NULL a few lines above on a certain condition, > which happened on my machine. The explicit NULL check

Re: [PATCH xserver 3/3] kdrive: Remove dead slots from KdCardFuncs

Adam Jackson writes: > On Mon, 2017-03-27 at 12:35 -0400, Adam Jackson wrote: >> On Fri, 2017-03-24 at 13:44 -0700, Eric Anholt wrote: >> >> > This is the only functional change I spotted: SaveScreen is now >> > going to >> > return FALSE instead of TRUE.  Given that we haven't

intel driver 4k MST

Hi all, connecting a Dell 4k MST display using the xorg intel driver on two different machines (Surface Pro 3, Dell XPS 13 9360) results in one of the two halts mirrored on the two MST halfs of the display. Using xrandr --left-of / --right-of I could not yet find a combination that would

Re: [Intel-gfx] intel driver 4k MST

On Mon, 27 Mar 2017, René Rebe wrote: > How to move forward? Is the xorg intel driver despite missing releases > under active development, or should I just use the lower performance > mode setting driver? Please file a bug over at [1], attach Xorg.0.log and dmesg with

Re: [Intel-gfx] intel driver 4k MST

Hi, On Mar 27, 2017, at 17:26, Chris Wilson wrote: > On Mon, Mar 27, 2017 at 04:47:44PM +0200, René Rebe wrote: >> Hi all, >> >> connecting a Dell 4k MST display using the xorg intel driver on two >> different machines (Surface Pro 3, Dell XPS 13 9360) results in one

Re: [PATCH xserver 1/3] xfree86: Clean up DPMS support

Adam Jackson writes: > Rather than setting up a per-screen private, just conditionally > initialize ScrnInfoRec::DPMSSet based on the config options, and inspect > that to determine whether DPMS is supported. > > We also move the "turn the screen back on at CloseScreen" logic

Re: [PATCH rendercheck 0/5] Convert to meson.

Mark Kettenis writes: >> From: Eric Anholt >> Date: Fri, 24 Mar 2017 13:17:45 -0700 >> >> Having bitten off a bit more than I can chew in 3 days with the X >> Server (hw/xfree86/sdksyms.c is the worst), I decided to take a quick >> pass at converting a

Re: [PATCH xserver 3/3] kdrive: Remove dead slots from KdCardFuncs

On Mon, 2017-03-27 at 12:35 -0400, Adam Jackson wrote: > On Fri, 2017-03-24 at 13:44 -0700, Eric Anholt wrote: > > > This is the only functional change I spotted: SaveScreen is now > > going to > > return FALSE instead of TRUE.  Given that we haven't actually > > blanked > > the screen, this

[PATCH rendercheck 2/5 v2] Add a meson build system.

Meson allows the configure step to be run faster (.3 seconds compared to autogen.sh's 3.9 seconds on my system) and a full rebuild (touch rendercheck.h; make) to run faster (.05s instead of .07s). Rendercheck is pretty much the best case scenario for autotools, with limited configure-time

Re: [PATCH xserver 3/3] kdrive: Remove dead slots from KdCardFuncs

On Fri, 2017-03-24 at 13:44 -0700, Eric Anholt wrote: > This is the only functional change I spotted: SaveScreen is now going to > return FALSE instead of TRUE.  Given that we haven't actually blanked > the screen, this seems like an appropriate return value. I don't think this is a functional

Re: [PATCH v2 xserver 1/3] xfree86: Silence always true condition warning.

looks nice Reviewed-by: wha...@bfs.de Am 27.03.2017 17:36, schrieb Michal Srb: > xf86pciBus.c:1464:21: warning: comparison of constant 256 with expression of > type 'uint8_t' (aka 'unsigned char') is always true > [-Wtautological-constant-out-of-range-compare] > if (pVideo->bus < 256) > >

[PATCH v2 xserver 1/3] xfree86: Silence always true condition warning.

xf86pciBus.c:1464:21: warning: comparison of constant 256 with expression of type 'uint8_t' (aka 'unsigned char') is always true [-Wtautological-constant-out-of-range-compare] if (pVideo->bus < 256) The code used to be in xf86FormatPciBusNumber and compared parameter which was int, but

Re: [Intel-gfx] intel driver 4k MST

On Mon, Mar 27, 2017 at 04:47:44PM +0200, René Rebe wrote: > Hi all, > > connecting a Dell 4k MST display using the xorg intel driver on two different > machines (Surface Pro 3, Dell XPS 13 9360) results in one of the two halts > mirrored on the two MST halfs of the display. Using xrandr

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

On 26/01/17 14:37, Martin Peres wrote: Despite all the careful planing of the kernel, a link may become insufficient to handle the currently-set mode. At this point, the kernel should mark this particular configuration as being broken and potentially prune the mode before setting the offending

Re: [PATCH xserver 3/3] test: Fix sizeof expression.

On 03/27/17 05:03 AM, m...@suse.com wrote: From: Michal Srb Instead of getting (sizeof(char[10]) - 1) = 9 it was getting sizeof(char*) = 8. Not that it changes much. simple-xinit.c:90:65: warning: sizeof on pointer operation will return size of 'char *' instead of 'char [10]'

Re: [PATCH xserver 1/3] xfree86: Silence always true condition warning.

On Monday, 27 March 2017 14:08:52 EEST walter harms wrote: > > -if (pVideo->bus < 256) > > -snprintf(busnum, sizeof(busnum), "%d", pVideo->bus); > > -else > > -snprintf(busnum, sizeof(busnum), "%d@%d", > > - pVideo->bus & 0x00ff, pVideo->bus >> 8); > > +

Re: [PATCH xserver 1/3] xfree86: Silence always true condition warning.

Am 27.03.2017 14:03, schrieb m...@suse.com: > From: Michal Srb > > xf86pciBus.c:1464:21: warning: comparison of constant 256 with expression of > type 'uint8_t' (aka 'unsigned char') is always true > [-Wtautological-constant-out-of-range-compare] > if (pVideo->bus < 256) >

[PATCH xserver 3/3] test: Fix sizeof expression.

From: Michal Srb Instead of getting (sizeof(char[10]) - 1) = 9 it was getting sizeof(char*) = 8. Not that it changes much. simple-xinit.c:90:65: warning: sizeof on pointer operation will return size of 'char *' instead of 'char [10]' [-Wsizeof-array-decay] ret =

[PATCH xserver 2/3] modesetting: Check for -1 before converting to unsigned int.

From: Michal Srb dri2.c:516:21: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare] if (front->name < 0) Prevents a failure from being ignored. --- hw/xfree86/drivers/modesetting/dri2.c | 7 +-- 1 file changed, 5 insertions(+), 2

[PATCH xserver 1/3] xfree86: Silence always true condition warning.

From: Michal Srb xf86pciBus.c:1464:21: warning: comparison of constant 256 with expression of type 'uint8_t' (aka 'unsigned char') is always true [-Wtautological-constant-out-of-range-compare] if (pVideo->bus < 256) The code used to be in xf86FormatPciBusNumber and compared

[PATCH xserver 0/3] Silencing warnings.

From: Michal Srb Hi, Mostly just fixing compiler warnings. The one in modesetting may prevent a failure from being ignored. Michal Srb (3): xfree86: Silence always true condition warning. modesetting: Check for -1 before converting to unsigned int. test: Fix sizeof

Re: [PATCH rendercheck 0/5] Convert to meson.

On Sun, 26 Mar 2017 23:40:34 +0200 walter harms wrote: > Am 24.03.2017 22:13, schrieb Mark Kettenis: > >> From: Eric Anholt > >> Date: Fri, 24 Mar 2017 13:17:45 -0700 > >> > >> Having bitten off a bit more than I can chew in 3 days with the X > >> Server