Re: [PATCH util-modular v2] release.sh: unset GPGKEY if already existing

2017-04-19 Thread Andres Gomez
On Thu, 2017-04-20 at 08:18 +0300, Andres Gomez wrote: ... > I suppose this other version would work too but, then, we will have a > different outcome if GPGKEY is set with or without an empty string. In > that case I would go for an even simpler initialization: > > GPGKEY="" Or, simply:

Re: [PATCH util-modular v2] release.sh: unset GPGKEY if already existing

2017-04-19 Thread Andres Gomez
On Thu, 2017-04-20 at 10:17 +1000, Peter Hutterer wrote: > On Wed, Apr 19, 2017 at 03:59:33PM +0300, Andres Gomez wrote: > > GPGKEY may already exist in the environment. In that case, just > > unset it. > > > > v2: unsetting is safer than redefining to quietly use a potentially > > wrong key

[PATCH xserver] os: Handle SIGABRT

2017-04-19 Thread Michel Dänzer
From: Michel Dänzer Without this, assertion failures make life hard for users and those trying to help them. Signed-off-by: Michel Dänzer --- os/osinit.c | 1 + os/utils.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/os/osinit.c

Re: [PATCH util-modular v2] release.sh: unset GPGKEY if already existing

2017-04-19 Thread Peter Hutterer
On Wed, Apr 19, 2017 at 03:59:33PM +0300, Andres Gomez wrote: > GPGKEY may already exist in the environment. In that case, just > unset it. > > v2: unsetting is safer than redefining to quietly use a potentially > wrong key stored in the variable (Peter). > > Signed-off-by: Andres Gomez

[PATCH xproto] Add XF86XK_Keyboard

2017-04-19 Thread Christian Kellner
From: Christian Kellner The 2017 Thinkpad models have a new hotkey with a keyboard symbols on it, which is mapped to KEY_KEYBOARD in the kernel. Signed-off-by: Christian Kellner --- XF86keysym.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH util-modular v2] release.sh: unset GPGKEY if already existing

2017-04-19 Thread Emil Velikov
On 19 April 2017 at 13:59, Andres Gomez wrote: > GPGKEY may already exist in the environment. In that case, just > unset it. > > v2: unsetting is safer than redefining to quietly use a potentially > wrong key stored in the variable (Peter). > > Signed-off-by: Andres Gomez

Re: [PATCH xserver 2/4] hw/xwin: Fix -Wmaybe-uninitialized warning in winWindowProc

2017-04-19 Thread Jon Turney
On 18/04/2017 22:08, Adam Jackson wrote: On Tue, 2017-04-18 at 11:53 +0100, Jon Turney wrote: This is possibly an actual bug in failing to check we successfully retrieved the monitor size before using it to set the X screen size. It is indeed. @@ -261,6 +261,9 @@ winWindowProc(HWND hwnd,

[PATCH util-modular v2] release.sh: unset GPGKEY if already existing

2017-04-19 Thread Andres Gomez
GPGKEY may already exist in the environment. In that case, just unset it. v2: unsetting is safer than redefining to quietly use a potentially wrong key stored in the variable (Peter). Signed-off-by: Andres Gomez Cc: Emil Velikov Cc: Peter

Re: [PATCH util-modular] release.sh: redefine GPGKEY if already existing

2017-04-19 Thread Andres Gomez
On Tue, 2017-04-18 at 12:08 +1000, Peter Hutterer wrote: > On Fri, Apr 07, 2017 at 04:26:35PM +0300, Andres Gomez wrote: > > GPGKEY may already exist in the environment. In that case, just > > redefine it adding "-u" > > Is GPGKEY a common thing used in other scripts? I honestly don't know. If >