Re: [PATCH xserver 1/2] os, xfree86: Stop being so weird about

I've never understood why this pattern was followed all over the X Consortium source base - it long predated me, and I'm happy to see it go. Reviewed-by: Alan Coopersmith -alan- On 05/11/17 02:17 PM, Adam Jackson wrote: Whatever problem this is trying to

Re: [PATCH xserver] dix: Remove clients from input and output ready queues after closing

On 11/05/17 11:18 PM, Keith Packard wrote: > Michel Dänzer writes: > >> I'm afraid that doesn't explain the ClientReady-after-CloseDownClient >> case in https://bugs.freedesktop.org/attachment.cgi?id=131278 though, so >> there might still be another (possibly pre-existing)

Re: [PATCH xserver] dix: Remove clients from input and output ready queues after closing

On 12/05/17 03:20 AM, Keith Packard wrote: > Delay removing the client from these two queues until all potential > I/O has completed in case we mark the client as ready for reading or > with pending output during the close operation. > > Bugzilla: https://bugs.freedesktop.org/100957 >

Re: [PATCH xproto v2 1/2] Add XF86XK_WWAN and XF86XK_Rfkill

On Wed, May 10, 2017 at 05:53:53PM +0200, Hans de Goede wrote: > Add Keysyms corresponding to the evdev WWAN and RFKILL keys, we already > have Keysyms for WLAN and UWB from linux/input-event-codes.h: > > #define KEY_WLAN238 > #define KEY_UWB 239 > > But not for

Re: [PATCH xserver 2/2] meson: Fix CLOCK_MONOTONIC test

On Thu, May 11, 2017 at 17:21:04 -0400, Adam Jackson wrote: > On Thu, 2017-05-11 at 17:17 -0400, Adam Jackson wrote: > > > @@ -4,7 +4,10 @@ dri_dep = dependency('dri', required: build_dri2 or > > build_dri3) > >  conf_data = configuration_data() > >  conf_data.set('_DIX_CONFIG_H_', '1') > >   >

Re: [PATCH xserver 2/2] meson: Fix CLOCK_MONOTONIC test

On Thu, 2017-05-11 at 17:17 -0400, Adam Jackson wrote: > @@ -4,7 +4,10 @@ dri_dep = dependency('dri', required: build_dri2 or > build_dri3) >  conf_data = configuration_data() >  conf_data.set('_DIX_CONFIG_H_', '1') >   > + > + >  conf_data.set('MONOTONIC_CLOCK', cc.compiles(''' > +#define

[PATCH xserver 2/2] meson: Fix CLOCK_MONOTONIC test

C99 isn't enough on its own to get POSIX feature sets defined. Signed-off-by: Adam Jackson --- include/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/meson.build b/include/meson.build index 358e04976..2f8882803 100644 --- a/include/meson.build +++

[PATCH xserver 1/2] os, xfree86: Stop being so weird about

Whatever problem this is trying to fix, we don't care. Just include the thing and stop worrying about whether _POSIX_SOURCE is defined. Signed-off-by: Adam Jackson --- hw/xfree86/os-support/xf86_OSlib.h | 6 -- hw/xfree86/parser/scan.c | 7 --- os/osdep.h

Re: [PATCH xserver 2/2] Replace all checks for 'linux' macro with '__linux__'

On Thu, 2017-05-11 at 12:30 +0300, Pekka Paalanen wrote: > these two (I suppose the latter specifically) let the Meson build > continue much further than before for me. Therefore: > > Tested-by: Pekka Paalanen Merged: remote: I: patch #155585 updated using rev

Re: [PATCH xserver] hw/xfree86: fix comment typo

On Thu, 2017-05-11 at 14:00 +0100, Frank Binns wrote: > Signed-off-by: Frank Binns remote: I: patch #155651 updated using rev 318257029578a30e29c191befa94a20ad07f97d4. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver

Re: [PATCH xserver] xephyr: Fix regeneration

On Thu, 2017-05-11 at 12:04 +0900, Michel Dänzer wrote: > Reviewed-and-Tested-by: Michel Dänzer remote: I: patch #155282 updated using rev 0848390d51f93ecfb9342cffe1cda46a65cfc07b. remote: I: 1 patch(es) updated to state Accepted. To

[PATCH xserver] dix: Remove clients from input and output ready queues after closing

Delay removing the client from these two queues until all potential I/O has completed in case we mark the client as ready for reading or with pending output during the close operation. Bugzilla: https://bugs.freedesktop.org/100957 Signed-off-by: Keith Packard Tested-by: Nick

Re: [PATCH xserver] dix: Remove clients from input and output ready queues after closing

On Thu, May 11, 2017 at 12:52 AM, Keith Packard wrote: > Delay removing the client from these two queues until all potential > I/O has completed in case we mark the client as ready for reading or > with pending output during the close operation. > > Signed-off-by: Keith Packard

Re: [PATCH xserver 5/7] meson: Make XV optional

Julien Cristau writes: > On Mon, May 8, 2017 at 10:13:52 -0700, Eric Anholt wrote: > >> Optional XV seems a bit silly to me. Could we just do something >> like: >> >> build_xv = build_xorg || build_dmx || build_ephyr? > > FWIW the Xorg build we're shipping in debian

Re: [PATCH xserver] dix: Remove clients from input and output ready queues after closing

Michel Dänzer writes: > I'm afraid that doesn't explain the ClientReady-after-CloseDownClient > case in https://bugs.freedesktop.org/attachment.cgi?id=131278 though, so > there might still be another (possibly pre-existing) bug. Agreed. I wonder if that might not be just

[PATCH xserver] hw/xfree86: fix comment typo

Signed-off-by: Frank Binns --- hw/xfree86/parser/scan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/parser/scan.c b/hw/xfree86/parser/scan.c index bac213a..6d46a56 100644 --- a/hw/xfree86/parser/scan.c +++ b/hw/xfree86/parser/scan.c @@

Re: [PATCH xserver 2/2] Replace all checks for 'linux' macro with '__linux__'

On Thu, 11 May 2017 08:42:16 +0200 Julien Cristau wrote: > gcc -std=c99 does not define the former, and it's a horrible namespace > confusion anyway. > > Signed-off-by: Julien Cristau > --- > hw/xfree86/common/compiler.h | 14 +++---

[PATCH xserver 2/2] Replace all checks for 'linux' macro with '__linux__'

gcc -std=c99 does not define the former, and it's a horrible namespace confusion anyway. Signed-off-by: Julien Cristau --- hw/xfree86/common/compiler.h | 14 +++--- hw/xfree86/common/xf86Config.c | 2 +- hw/xfree86/common/xf86Configure.c | 2

[PATCH xserver 1/2] Drop workaround for pre-glibc linux

It seems unlikely anyone still needs to build against libc4/libc5. Signed-off-by: Julien Cristau --- Xext/xf86bigfont.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/Xext/xf86bigfont.c b/Xext/xf86bigfont.c index 72bb774011..529595bb75 100644 ---

Re: [PATCH xserver] dix: Remove clients from input and output ready queues after closing

On 11/05/17 01:52 PM, Keith Packard wrote: > Delay removing the client from these two queues until all potential > I/O has completed in case we mark the client as ready for reading or > with pending output during the close operation. Bugzilla: https://bugs.freedesktop.org/100957 >