[PATCH xserver] config/udev: consider ID_INPUT_FOO=0 as 'unset'

2017-09-25 Thread Peter Hutterer
Historically we didn't need to care about this case but more devices are having invalid types set and they cannot be unset with a hwdb entry (which doesn't handle the empty string). Allow for "0" to mean "unset" because anything else would be crazy anyway. Signed-off-by: Peter Hutterer

Re: [PATCH xserver] modesetting: Skip no-longer-present connectors when resetting BAD links

2017-09-25 Thread Keith Packard
Manasi Navare writes: > Thanks for the patch. Does this take care of the cases where > MST monitors might get unplugged, but not generate the > hotplug event? Nope, this is strictly for devices which have disappeared from the kernel API, but which the X server is

Re: [PATCH xserver] modesetting: Skip no-longer-present connectors when resetting BAD links

2017-09-25 Thread Manasi Navare
On Mon, Sep 25, 2017 at 04:18:22PM -0700, Keith Packard wrote: > Outputs may have NULL mode_output (connector) pointers if the > connector disappears while the server is running. Skip these when > resetting outputs with BAD link status. > Thanks for the patch. Does this take care of the cases

Re: Pull request for server-1.19.branch fixes ?

2017-09-25 Thread Keith Packard
Adam Jackson writes: >> Martin Peres (1): >> modesetting: re-set the crtc's mode when link-status goes BAD > > Keith had part of this change disabled locally at XDC, apparently he'd > seen crashes from it. Hopefully we can figure that one out relatively > quickly...

[PATCH xserver] modesetting: Skip no-longer-present connectors when resetting BAD links

2017-09-25 Thread Keith Packard
Outputs may have NULL mode_output (connector) pointers if the connector disappears while the server is running. Skip these when resetting outputs with BAD link status. Signed-off-by: Keith Packard --- hw/xfree86/drivers/modesetting/drmmode_display.c | 5 - 1 file changed,

Re: [PATCH xserver] xfree86: Hush some warnings when Xv is disabled

2017-09-25 Thread Eric Anholt
Adam Jackson writes: > Spotted by Appveyor: > > xf86Crtc.c:3281:1: warning: ‘xf86_crtc_box_area’ defined but not used > [-Wunused-function] > xf86_crtc_box_area(BoxPtr box) > ^~ > xf86Crtc.c:3268:1: warning: ‘x86_crtc_box’ defined but not used >

Re: [PATCH] os: Make sure big requests have sufficient length.

2017-09-25 Thread Eric Anholt
Michal Srb writes: > On neděle 24. září 2017 0:20:07 CEST Eric Anholt wrote: >> Michal Srb writes: >> > Here is a script that can be used to crash X server using a broken big >> > request for PolyLine. It connects to DISPLAY=:1 and doesn't support >> >

Re: [PATCH xserver 2/2] glx: Implement GLX_EXT_no_config_context

2017-09-25 Thread Adam Jackson
On Fri, 2017-09-22 at 13:06 -0400, Adam Jackson wrote: > I wrote that part of the spec before I'd finished the client side. I > was thinking a naïve indirect-only client library that just packs the > arguments onto the wire would need some handcoded magic to get the > request right, which seemed

Re: Pull request for server-1.19.branch fixes ?

2017-09-25 Thread Adam Jackson
On Mon, 2017-09-25 at 04:28 -0400, Olivier Fourdan wrote: > The following changes since commit d88937ba8354d6a4e0be2a398037443146701ddc: > > xserver 1.19.3 (2017-03-15 13:44:05 -0400) > > are available in the git repository at: > > git://people.freedesktop.org/~ofourdan/xserver

Re: [PATCH xserver] test: Fix a thinko in simple-xinit

2017-09-25 Thread Alan Coopersmith
On 09/25/17 12:01 PM, Adam Jackson wrote: Spotted by clang courtesy of the shiny new OSX Travis target: simple-xinit.c:90:65: warning: sizeof on pointer operation will return size of 'char *' instead of 'char [10]' [-Wsizeof-array-decay] ret = read(displayfd, display_string,

[PATCH xserver] xfree86: Hush some warnings when Xv is disabled

2017-09-25 Thread Adam Jackson
Spotted by Appveyor: xf86Crtc.c:3281:1: warning: ‘xf86_crtc_box_area’ defined but not used [-Wunused-function] xf86_crtc_box_area(BoxPtr box) ^~ xf86Crtc.c:3268:1: warning: ‘x86_crtc_box’ defined but not used [-Wunused-function] x86_crtc_box(xf86CrtcPtr crtc, BoxPtr crtc_box)

[PATCH xserver] test: Fix a thinko in simple-xinit

2017-09-25 Thread Adam Jackson
Spotted by clang courtesy of the shiny new OSX Travis target: simple-xinit.c:90:65: warning: sizeof on pointer operation will return size of 'char *' instead of 'char [10]' [-Wsizeof-array-decay] ret = read(displayfd, display_string, sizeof(display_string - 1)); Signed-off-by: Adam Jackson

Re: [PATCH] suid: Include sysmacros.h to fix build after glibc-2.25

2017-09-25 Thread Adam Jackson
On Sat, 2017-09-23 at 17:37 -0400, Nick Sarnie wrote: > On Sat, Sep 23, 2017 at 5:35 PM, Nick Sarnie wrote: > > Signed-off-by: Nick Sarnie > > --- > > hw/xfree86/xorg-wrapper.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git

Re: [RFC] DeepColor Visual Class Extension

2017-09-25 Thread Adam Jackson
On Mon, 2017-08-14 at 19:17 -0700, Alex Goins wrote: > We brainstormed all of the suggestions amongst ourselves, and have a revised > version of the spec. It also includes some changes of our own. > > Unfortunately, we weren't able to bottom out on everything (most notably the > masquerading

Re: Pull request for server-1.19.branch fixes ?

2017-09-25 Thread Olivier Fourdan
Hi all, > [...] > > Anything else? If not, I'll send an updated pull request on Monday... > So here is an updated pull request, it should include the fixes requested by Michel, Jason and Mark. Cheers, Olivier -- The following changes since commit d88937ba8354d6a4e0be2a398037443146701ddc:

Re: [PATCH] os: Make sure big requests have sufficient length.

2017-09-25 Thread Michal Srb
On neděle 24. září 2017 0:20:07 CEST Eric Anholt wrote: > Michal Srb writes: > > Here is a script that can be used to crash X server using a broken big > > request for PolyLine. It connects to DISPLAY=:1 and doesn't support > > authentication. Look inside the script for more