Re: [PATCH xserver 1/3] glamor: Unconditionalize GLAMOR_GRADIENT_SHADER

2017-10-25 Thread Eric Anholt
Adam Jackson writes: > Effectively always true anyway. All 3: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xserver] meson: Use [ true, false, auto ] for tristate values

2017-10-25 Thread Daniel Stone
On 25 October 2017 at 14:51, Adam Jackson wrote: > On Wed, 2017-10-25 at 11:34 +1000, Peter Hutterer wrote: >> On Tue, Oct 24, 2017 at 01:03:09PM -0400, Adam Jackson wrote: >> > For symmetry with the boolean options. I really do not want to care >> > whether an option is a

Re: [PATCH xserver] ramdac: Check ScreenPriv != NULL in xf86ScreenSetCursor()

2017-10-25 Thread Adam Jackson
On Wed, 2017-10-25 at 17:23 +1000, Dave Airlie wrote: > Reviewed-by: Dave Airlie remote: I: patch #184600 updated using rev 68d95e759f8b6ebca6bd52e69e6bc34cc174f8ca. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver

Re: [PATCH xserver] meson: Use [ true, false, auto ] for tristate values

2017-10-25 Thread Adam Jackson
On Wed, 2017-10-25 at 11:34 +1000, Peter Hutterer wrote: > On Tue, Oct 24, 2017 at 01:03:09PM -0400, Adam Jackson wrote: > > For symmetry with the boolean options. I really do not want to care > > whether an option is a tristate if I'm trying to set it explicitly. > > > > Signed-off-by: Adam

Re: [PATCH xserver] ramdac: Check ScreenPriv != NULL in xf86ScreenSetCursor()

2017-10-25 Thread Dave Airlie
Reviewed-by: Dave Airlie On 25 October 2017 at 11:39, Alex Goins wrote: > Similar to change cba5a10f, xf86ScreenSetCursor() would dereference ScreenPriv > without NULL checking it. If Option "SWCursor" is specified, ScreenPriv == > NULL. > > Without this