Re: [PATCH xserver v2] fixing -logfile when used with -displayfd

2018-03-25 Thread Alan Coopersmith
Reviewed-by: Alan Coopersmith On 02/28/18 12:19 AM, Antoine Martin wrote: > Hi, > > v2 updated with the feedback from Alan: the LogSetDisplay function is > the right place for this fix. > > Trivial way to reproduce the bug: > Xorg -logfile /tmp/mylog -config

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

2018-03-25 Thread Louis-Francis Ratté-Boulianne
Hi, What do you mean by pageflipping not properly working? I've tried to reproduce the issue, and pageflipping seems to work fine. Also, we can't unfortunately just use always XRGB formats in glamor (we need to check wheither depth is 24 or 32) as it would break actual partly-transparent or

Re: [PATCH:libXaw] Fix xload crashes if the window is wider than 2048 pixels

2018-03-25 Thread Keith Packard
Alan Coopersmith writes: > https://bugs.freedesktop.org/show_bug.cgi?id=96670 > > Signed-off-by: Alan Coopersmith Tested-by: Keith Packard -- -keith signature.asc Description: PGP signature

Re: [PATCH:libXaw] Fix xload crashes if the window is wider than 2048 pixels

2018-03-25 Thread Walter Harms
> Alan Coopersmith hat am 25. März 2018 um 07:45 > geschrieben: > > > https://bugs.freedesktop.org/show_bug.cgi?id=96670 > > Signed-off-by: Alan Coopersmith > --- > > I wasn't sure if the size of valuedata could be changed without

Re: [PATCH:libXaw] Fix xload crashes if the window is wider than 2048 pixels

2018-03-25 Thread Matthieu Herrb
On Sat, Mar 24, 2018 at 10:45:47PM -0700, Alan Coopersmith wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=96670 > > Signed-off-by: Alan Coopersmith Reviewed-by: Matthieu Herrb > --- > > I wasn't sure if the size of valuedata could be

Re: [PATCH libX11] Use size_t for buffer sizes in SetHints.c

2018-03-25 Thread Matthieu Herrb
On Sat, Mar 24, 2018 at 07:48:49PM -0700, Alan Coopersmith wrote: > These variables store values returned from strlen() as a size_t > and are passed to Xmalloc, which expects a size_t, so lets stop > converting back and forth to int along the way. LGTM, Reviewed-by: Matthieu Herrb

Re: [PATCH libICE 2/2] iceauth.c: FIX warning: unused variable 'ret' in 'arc4random_buf'

2018-03-25 Thread Alan Coopersmith
Reviewed-by: Alan Coopersmith On 09/ 7/17 09:52 AM, walter harms wrote: > commit ff5e59f32255913bb1cdf51441b98c9107ae165b left ret outside the #if > causing a gcc warnung: > > In function 'arc4random_buf': > iceauth.c:89:13: warning: unused variable 'ret'

[PATCH app/xrdb] Add -E flag to show cpp command line & processed input file

2018-03-25 Thread Alan Coopersmith
https://bugs.freedesktop.org/show_bug.cgi?id=98300 Signed-off-by: Alan Coopersmith --- I used "-E" in imitation of "cc -E" since I couldn't think of a better name. "-v" or "-verbose" didn't seem right, since it's only making this one specific aspect verbose, not all