Re: [PATCH xserver] meson: Fix module_dir configuration

On 04/03/2018 02:27 AM, Thierry Reding wrote: On Mon, Apr 02, 2018 at 02:31:20PM -0700, Aaron Plattner wrote: meson.build has code to set the module_dir variable to ${libdir}/xorg/modules if the module_dir option string is empty. However, this has several problems: 1. The variable is only used

[PATCH xserver] GLX: Fix a use after free error with the GLVND vendor handle.

The GLVND layer will destroy all of the vendor handles at the end of each server generation, but the GLX module then tries to re-use the same (now-freed) handle in xorgGlxServerInit at the start of the next generation. In xorgGlxCloseExtension, explicitly destroy the vendor handle and set it to

Re: [PATCH xserver] xfree86: drop KDSKBMUTE handling

On Fri, 2018-04-06 at 12:28 +1000, Peter Hutterer wrote: > This was never merged upstream. It was a Fedora kernel patch but dropped from > Fedora in 2013 with kernel 3.12. > > The reason for the KDSKBMUTE proposal has been fixed in systemd in Feb 2013, > systemd 198. >

Re: [PATCH xserver 15/15] dri3: correctly handle failed get_supported_modifiers requests

On 6 April 2018 at 12:26, Daniel Stone wrote: > Hi, > > On 6 April 2018 at 12:18, Emil Velikov wrote: >> On 4 April 2018 at 19:51, Adam Jackson wrote: >>> This, combined with 10/15, means you will now throw BadImplementation >>>

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

It's Thierry's patch I revert to get things working On Fri, 6 Apr 2018 at 12:11 Emil Velikov wrote: > On 5 April 2018 at 19:06, Mike Lothian wrote: > > Nope still not working > > > > Intel DDX didn't launch, Modesetting did however compositing was

Re: [PATCH xserver 15/15] dri3: correctly handle failed get_supported_modifiers requests

Hi, On 6 April 2018 at 12:18, Emil Velikov wrote: > On 4 April 2018 at 19:51, Adam Jackson wrote: >> This, combined with 10/15, means you will now throw BadImplementation >> when we used to succeed and simply report no modifiers. I can't think >> of a

Re: [PATCH xserver 15/15] dri3: correctly handle failed get_supported_modifiers requests

On 4 April 2018 at 19:51, Adam Jackson wrote: > On Mon, 2018-04-02 at 16:41 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Currently depending on the code path hit, the helper will set some of >> the output values and not others. >> >> It could

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

On 5 April 2018 at 19:06, Mike Lothian wrote: > Nope still not working > > Intel DDX didn't launch, Modesetting did however compositing was disabled > due to the previous failure. Upon reenabling the screen went blank, however > things were still running, when I went to the

Re: [PATCH xserver 0/8] GCC8 warning fixes

On 5 April 2018 at 18:13, Adam Jackson wrote: > gcc 8's buffer size logic got a bit pickier, in mostly reasonable ways, > but -Wmaybe-uninitialized got a lot more speculative. Regardless I'm > tired of seeing warnings in my build logs. > There are some trivial suggestions but the

Re: [PATCH xserver 6/8] xkb: Silence some compiler warnings

On 5 April 2018 at 18:13, Adam Jackson wrote: > Of the form: > > ../xkb/XKBGAlloc.c: In function ‘SrvXkbAddGeomKeyAlias’: > ../xkb/XKBGAlloc.c:591:13: warning: ‘strncpy’ specified bound 4 equals > destination size [-Wstringop-truncation] > strncpy(alias->real,

Re: [PATCH xserver 5/8] dmx: Silence a string truncation warning.

On 5 April 2018 at 18:13, Adam Jackson wrote: > ../hw/dmx/config/dmxparse.c: In function ‘dmxConfigCreateOption’: > ../hw/dmx/config/dmxparse.c:385:13: warning: ‘strncpy’ output truncated > before terminating nul copying as many bytes from a string as its length >

Re: [PATCH xserver 4/8] dmx: Clean up some argument parsing code

On 5 April 2018 at 18:13, Adam Jackson wrote: > This threw: > > ../hw/dmx/input/dmxarg.c: In function ‘dmxArgParse’: > ../hw/dmx/input/dmxarg.c:128:5: warning: ‘strncpy’ specified bound depends on > the length of the source argument [-Wstringop-overflow=] > strncpy(tmp,

Re: [PATCH xserver 3/8] dmx: Fix a read-from-uninitialized warning

On 5 April 2018 at 18:13, Adam Jackson wrote: > ../hw/dmx/dmxpixmap.c: In function ‘dmxBitmapToRegion’: > ../include/regionstr.h:174:22: warning: ‘Box.x1’ may be used uninitialized in > this function [-Wmaybe-uninitialized] > (_pReg)->extents = *(_pBox); >

Re: [PATCH xserver 2/8] dmx: Fix some snprintf warnings.

On 6 April 2018 at 09:44, Peter Hutterer wrote: > On Thu, Apr 05, 2018 at 01:13:55PM -0400, Adam Jackson wrote: >> snprintf doesn't terminate the string if it truncates, so things like >> this are lurking crashers: > > it doesn't? which platforms is that on? Apparently

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

Hi, On 6 April 2018 at 09:48, Mike Lothian wrote: > Thanks for reminding me about GLX vs EGL > > The config option in KDE was removed from the System Setting app and can > only be adjusted manually in in ~/.config/kwinrc > > GLPlatformInterface=egl > > This might explain why

Re: [PATCH xserver] xwayland: Silence a build warning if we can

On 6 April 2018 at 08:07, Pekka Paalanen wrote: > On Thu, 5 Apr 2018 13:35:11 -0400 > Adam Jackson wrote: > >> [735/786] Generating >> 'hw/xwayland/Xwayland@exe/relative-pointer-unstable-v1-protocol.c'. >> Using "code" is deprecated - use private-code or

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

Hi Mario Thanks for reminding me about GLX vs EGL The config option in KDE was removed from the System Setting app and can only be adjusted manually in in ~/.config/kwinrc GLPlatformInterface=egl This might explain why Daniel hasn't been seeing the issues I've been seeing Cheers Mike On

Re: [PATCH xserver 2/8] dmx: Fix some snprintf warnings.

On Thu, Apr 05, 2018 at 01:13:55PM -0400, Adam Jackson wrote: > snprintf doesn't terminate the string if it truncates, so things like > this are lurking crashers: it doesn't? which platforms is that on? Apparently windows, from a quick google but that's about it, right? Cheers, Peter > >

Re: [PATCH xserver] xwayland: Silence a build warning if we can

On Thu, 5 Apr 2018 13:35:11 -0400 Adam Jackson wrote: > [735/786] Generating > 'hw/xwayland/Xwayland@exe/relative-pointer-unstable-v1-protocol.c'. > Using "code" is deprecated - use private-code or public-code. > See the help page for details. > > Use private-code if