Re: [PATCH xserver 0/2] Fix some error in Xorg.0.log

2018-04-12 Thread Liwei Song
On 04/13/2018 05:39 AM, Adam Jackson wrote: > On Wed, 2018-04-11 at 22:49 -0400, Liwei Song wrote: >> On my CoffeeLake S board, after compile i915 as a kernel module >> will got following error in Xorg.0.log: >> (EE) /dev/dri/card0: failed to set DRM interface version 1.4: Permission >>

Re: [PATCH xserver] xwayland: Don't crash on WarpPointer(dest_w = None)

2018-04-12 Thread Peter Hutterer
On Thu, Apr 12, 2018 at 05:24:08PM -0400, Adam Jackson wrote: > Turns out that's legal, and xts exercises it, and we crash: > > Thread 1 "Xwayland" received signal SIGSEGV, Segmentation fault. > dixGetPrivate (key=0x813660 , privates=0x20) at > ../../include/privates.h:122 > 122

Re: [PATCH xserver 0/2] Fix some error in Xorg.0.log

2018-04-12 Thread Adam Jackson
On Wed, 2018-04-11 at 22:49 -0400, Liwei Song wrote: > On my CoffeeLake S board, after compile i915 as a kernel module > will got following error in Xorg.0.log: > (EE) /dev/dri/card0: failed to set DRM interface version 1.4: Permission > denied > (EE) open /dev/fb0: No such file or

Re: [PATCH xserver] configure.ac: make use of wayland-scanner.pc

2018-04-12 Thread Adam Jackson
On Wed, 2018-04-11 at 18:51 +0100, Emil Velikov wrote: > From: Emil Velikov > > Replace the current (incorrect) assumption that wayland-scanner is > located in the wayland-client prefix. Make use of the wayland_scanner > variable in wayland-scanner.pc > > It was

[PATCH xserver] xwayland: Don't crash on WarpPointer(dest_w = None)

2018-04-12 Thread Adam Jackson
Turns out that's legal, and xts exercises it, and we crash: Thread 1 "Xwayland" received signal SIGSEGV, Segmentation fault. dixGetPrivate (key=0x813660 , privates=0x20) at ../../include/privates.h:122 122 return (char *) (*privates) + key->offset; (gdb) bt #0

Re: [PATCH app/xdpyinfo v3] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

2018-04-12 Thread Adam Jackson
On Thu, 2018-04-12 at 20:47 +0200, Pali Rohár wrote: > XServer with enabled XRANDR 1.2 extension does not provide correct > dimensions from DisplayWidthMM() and DisplayHeightMM() calls anymore. > Values are calculated from fixed DPI 96. > > Therefore when XRANDR 1.2 extension is enabled, present

[PATCH app/xdpyinfo v3] Use XRANDR 1.2 extension for reporting dimensions and resolution per output

2018-04-12 Thread Pali Rohár
XServer with enabled XRANDR 1.2 extension does not provide correct dimensions from DisplayWidthMM() and DisplayHeightMM() calls anymore. Values are calculated from fixed DPI 96. Therefore when XRANDR 1.2 extension is enabled, present and user requested for it, instead use XRRGetScreenResources()

[PATCH app/xrandr] Fix checking for valid argument of --dpi

2018-04-12 Thread Pali Rohár
Function strtod() sets strtod_error to the pointer of the first invalid character and therefore it does not have to be first character from input. When input is valid then it points to nul byte. Conversion error is indicated by setted errno. Zero-length argument and zero DPI is invalid too.

Re: [PATCH xserver] sdksyms: Skip empty symbols

2018-04-12 Thread Jeff Smith
> my awk skills are non-existent but shouldn't this be $symbol? The condition a > few > lines above uses $n == "" instead of n == "" > > with that change, Reviewed-by: Peter Hutterer > > Cheers, >Peter Well, awk is a bit peculiar in that respect. Noting that awk

[PATCH] randr: Do not crash if slave screen does not have provider.

2018-04-12 Thread Michal Srb
All GPU screens are attached as unbound GPUs to master, even if they have no capabilities or the provider field is null. Handle that case in RRTellChanged. --- This prevents crash in setups with for example two qxl devices, or fbdev and qxl device. I am not sure if it is a proper fix and not just

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

2018-04-12 Thread Mike Lothian
Hi Sending this again with the attachements compressed I've done some more testing. The flashing I was seeing with Xserver 1.19.5 goes away when I use egl rather then glx with Kwin - I won't be using egl in any of the next tests When I use Xserver 1.20 RC4 with Intel/AMDPGU DDXs Kwin doesn't

Re: [PATCH xserver] sdksyms: Skip empty symbols

2018-04-12 Thread Thomas Klausner
On Wed, Apr 11, 2018 at 03:39:33PM -0400, Adam Jackson wrote: > Apparently on NetBSD we can hit failures like this: > > sdksyms.c:1773:15: error: expected expression before ',' token > (void *) &, /* > ../../dri3/dri3.h:110 */ > > I've been

Re: [ANNOUNCE] xorg-server 1.19.99.904

2018-04-12 Thread Thomas Klausner
On Wed, Apr 11, 2018 at 04:24:02PM -0500, Jeff Smith wrote: > On Wed, Apr 11, 2018 at 2:44 AM, Thomas Klausner wrote: > > I still see this build failure on NetBSD: > > > > sdksyms.c:1773:15: error: expected expression before ',' token > > (void *) &,