Re: [PATCH xserver] animcur: Fix crash when removing a master device

2018-04-23 Thread Peter Hutterer
On Mon, Apr 23, 2018 at 03:21:14PM -0400, Adam Jackson wrote: > Reproducer: > > $ Xvfb -ac -noreset :1 & > $ DISPLAY=:1 xinput create-master touch1 > $ DISPLAY=:1 xinput remove-master "touch1 pointer" > > Bugzilla: https://bugs.freedesktop.org/105761 > Signed-off-by: Adam Jackson

Re: [PATCH xserver] vfb: Fix man page in re depth

2018-04-23 Thread Alan Coopersmith
On 04/23/18 02:21 PM, Adam Jackson wrote: > 32 is not a valid depth, and the default is now 24 not 8. > > Signed-off-by: Adam Jackson > --- > hw/vfb/man/Xvfb.man | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/vfb/man/Xvfb.man

[PATCH xserver] vfb: Fix man page in re depth

2018-04-23 Thread Adam Jackson
32 is not a valid depth, and the default is now 24 not 8. Signed-off-by: Adam Jackson --- hw/vfb/man/Xvfb.man | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/vfb/man/Xvfb.man b/hw/vfb/man/Xvfb.man index 5fd58eb66a..adfeb8a217 100644 ---

Re: [PATCH xserver 1/3] xwayland: Decouple GBM from glamor

2018-04-23 Thread Adam Jackson
On Fri, 2018-04-20 at 17:23 -0400, Lyude Paul wrote: > lgtm! for the whole series: > > Reviewed-by: Lyude Paul Thanks. I've found at least one interaction between this and the present window flip code (which assumes gbm, but merely checks whether ->glamor is set...). I'll

[PATCH xserver 3/4] vnd: Disable GLX if no vendors successfully initialized

2018-04-23 Thread Adam Jackson
Signed-off-by: Adam Jackson --- glx/vndcmds.c | 2 ++ glx/vndext.c| 9 + glx/vndserver.h | 4 +--- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/glx/vndcmds.c b/glx/vndcmds.c index c3e1332bf0..493e2bfc04 100644 --- a/glx/vndcmds.c +++

[PATCH xserver 0/4] GLX non-initialization fixes

2018-04-23 Thread Adam Jackson
This series fixes a case of GLX claiming to be available when it oughtn't. The mechanism for disabling an extension that's already called AddExtension is perhaps a bit gross, but it's better than clients dying. - ajax ___ xorg-devel@lists.x.org: X.Org

[PATCH xserver 4/4] glx: Require depth > 12 for GLX visuals

2018-04-23 Thread Adam Jackson
fb is happy to do TrueColor to 8bpp drawables, but mesa is not. Depth 12 is the biggest pseudocolor anyone ever really did, and 15 is the least truecolor. Without this Xvfb at depth 8 would "have" GLX, but no vendors would actually back any of the screens. libGL will attempt to call

[PATCH xserver 2/4] dix: Allow an extension to disable itself

2018-04-23 Thread Adam Jackson
GLX registers an extension before we know if there are any screens that can actually do it. It's inconvenient to shrink the extension list, so instead allow the extension to simply zero out its base opcode to indicate that it needed to panic and disable itself. Signed-off-by: Adam Jackson

[PATCH xserver 1/4] dix: Factor out extension availability check

2018-04-23 Thread Adam Jackson
Signed-off-by: Adam Jackson --- dix/extension.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/dix/extension.c b/dix/extension.c index b4c1c5f16f..7d432c7224 100644 --- a/dix/extension.c +++ b/dix/extension.c @@ -210,6 +210,14 @@

[PATCH xserver] animcur: Fix crash when removing a master device

2018-04-23 Thread Adam Jackson
Reproducer: $ Xvfb -ac -noreset :1 & $ DISPLAY=:1 xinput create-master touch1 $ DISPLAY=:1 xinput remove-master "touch1 pointer" Bugzilla: https://bugs.freedesktop.org/105761 Signed-off-by: Adam Jackson --- render/animcur.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [ANNOUNCE] xorg-server 1.19.99.904

2018-04-23 Thread Adam Jackson
On Sat, 2018-04-21 at 11:42 +0200, Thomas Klausner wrote: > Thanks! > > We already had a patch for such a problem with pid_t in pkgsrc, and > I've extended it to uint32_t, which fixes the problem for me. > > It's attached. > > Let me know if it can go in like this or what else we can do to fix

Re: [PATCH xserver] modesetting: Only use modifiers on kms drivers which do support them.

2018-04-23 Thread Adam Jackson
On Fri, 2018-04-20 at 15:50 -0400, Louis-Francis Ratté-Boulianne wrote: > Hi, > > It seems to do the right thing, so: > > On Fri, 2018-04-20 at 19:59 +0200, Mario Kleiner wrote: > > > > Fixes: 2f807c2324b4 ("modesetting: Add support for multi-plane > > pixmaps when page-flipping") > >