[PATCH xserver] randr: Account for panning and transforms when constraining the cursor

2018-04-30 Thread Matt Turner
From: Chris Wilson commit 56c90e29f04727c903bd0f084d23bf44eb1a0a11 [1.10.99.901] Author: Adam Jackson Date: Mon Nov 15 14:29:14 2010 -0500 randr: Add RRConstrainCursorHarder introduced a regression as it ignored the effect of panning and

Re: [PATCH xserver] xwayland: restrict present cleanup to presenting and top parent window

2018-04-30 Thread Adam Jackson
On Fri, 2018-04-20 at 17:07 +0200, Roman Gilg wrote: > Clean up only if the request points to the presenting window or its top > parent window. > > Since in this case all events are removed unconditionally, always stop > the timer. > > Signed-off-by: Roman Gilg Merged,

Re: [PATCH xserver] xwayland: Avoid using epoxy_has_egl()

2018-04-30 Thread Mario Kleiner
On Mon, Apr 30, 2018 at 8:10 PM, Adam Jackson wrote: > There's no real point - if we don't have EGL then the extension check is > also going to fail - and the entrypoint is new in 1.5.0, which we don't > need to require yet. > > Signed-off-by: Adam Jackson > ---

[PATCH xserver] xwayland: Avoid using epoxy_has_egl()

2018-04-30 Thread Adam Jackson
There's no real point - if we don't have EGL then the extension check is also going to fail - and the entrypoint is new in 1.5.0, which we don't need to require yet. Signed-off-by: Adam Jackson --- hw/xwayland/xwayland-glamor.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH xserver 1/1] modesetting: Fix GBM objects leak when checking for flip

2018-04-30 Thread Adam Jackson
On Thu, 2018-04-26 at 11:04 -0400, Louis-Francis Ratté-Boulianne wrote: > GBM objects were never destroyed after looking for format and > modifier compatibility when deciding whether flipping or copying > a presented pixmap. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106106 >

Re: [PATCH xserver 3/4] glamor: Don't fail in glamor_get_formats if not dmabuf_capable.

2018-04-30 Thread Adam Jackson
On Mon, 2018-04-30 at 09:06 +0200, Mario Kleiner wrote: > If dmabuf_capable is false, because the server "dmabuf_capable" > debug flag isn't set, treat it as successfull query with zero > returned formats, instead of failure. > > This allows the servers cache_formats_and_modifiers() function > to

Re: [PATCH xserver] dri3: Fix DRI3.2 support for drivers other than modesetting-ddx.

2018-04-30 Thread Mike Lothian
Also with the intel DDX I was seeing a black screen after the monitor switches itself off (I can still see the cursor) VT switching away and back again fixes the issue I'm going to ask again that 1.20 isn't cut until at least some of these issues are resolved On Mon, 30 Apr 2018 at 11:36 Mike

Re: [PATCH xserver] dri3: Fix DRI3.2 support for drivers other than modesetting-ddx.

2018-04-30 Thread Mike Lothian
Hi I'll get one raised just for that After further testing the above patch with the intel ddx I notice vulkan programs don't run, they exit with an assert in the mesa code something to do with modifiers chain I'll raise a separate bug for that, it happens with smoketest and Rise of the Tomb

Re: [PATCH xserver] dri3: Fix DRI3.2 support for drivers other than modesetting-ddx.

2018-04-30 Thread Mario Kleiner
On Wed, Apr 25, 2018 at 2:23 AM, Mike Lothian wrote: > > The plasmashell & steam freezes aren't present with the Intel or AMDGPU > DDXs, only modesetting > > I'm quite happy to mark https://bugs.freedesktop.org/show_bug.cgi?id=105851 > as resolved and look into the

[PATCH xserver 2/4] dri3: Robustly clamp to 1.0 if not all screens support 1.2

2018-04-30 Thread Mario Kleiner
Checking for dri3_screen_info_rec.version >= 2 is insufficient, as some shipping drivers, e.g., intel-ddx, nouveau-ddx, set the version to DRI3_SCREEN_INFO_VERSION, ie. to whatever version the installed servers headers define. On server 1.20 that would be version 2, but the drivers still don't

[PATCH xserver 4/4] modesetting: Don't leak gbm_bo's in ms_present_check_flip().

2018-04-30 Thread Mario Kleiner
Signed-off-by: Mario Kleiner Cc: Daniel Stone Cc: Adam Jackson --- hw/xfree86/drivers/modesetting/present.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/xfree86/drivers/modesetting/present.c

[PATCH xserver 3/4] glamor: Don't fail in glamor_get_formats if not dmabuf_capable.

2018-04-30 Thread Mario Kleiner
If dmabuf_capable is false, because the server "dmabuf_capable" debug flag isn't set, treat it as successfull query with zero returned formats, instead of failure. This allows the servers cache_formats_and_modifiers() function to cache the fact that formats are not supported during the current

[PATCH xserver 1/4] dri3: Fix error handling in dri3_buffer_from_pixmap request.

2018-04-30 Thread Mario Kleiner
The old info->fd_from_pixmap() driver hook, which is preferentially used in dri3_fd_from_pixmap(), can return error codes other than -1, e.g., -EINVAL (-22) on nouveau-ddx. Not handling the error causes a broken/corrupted X-Connection resulting from a failed request. This fixes failure of