[PATCH xkbcomp] Ignore xkb_keycodes.maximum of > 255

2018-06-06 Thread Peter Hutterer
Continuation from 7fdfabd75 "keycodes: Ignore high keycodes" A keymap with a key > 255 will have a xkb_keycodes.maximum of that keycode. Let's not throw a fatal error on that, just crop it back to the maximum of 255. This doesn't set the "high_keycode_warned" on purpose so we get this for the

[PATCH xserver 2/2] Xi: add forgotten byte-swaps for Valuator fields

2018-06-06 Thread Roman Kapl
This has caused nonsensical values in xinput output. Signed-off-by: Roman Kapl --- Xi/xiquerydevice.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Xi/xiquerydevice.c b/Xi/xiquerydevice.c index 5f5a5f82f..fbb51fe81 100644 --- a/Xi/xiquerydevice.c +++ b/Xi/xiquerydevice.c @@ -383,6

[PATCH xserver 0/2] Cross-endianess fixes in XInput

2018-06-06 Thread Roman Kapl
Two smallish patches to fix some XInput bits on cross-endianess clients. It adds or moves around swap(x) as needed. There is also a documentation fix in XProto, this will be sent separately. Roman Kapl (2): Xi: fix byte-swapping of button labels Xi: add forgotten byte-swaps for Valuator

[PATCH] Improve the ButtonInfo description.

2018-06-06 Thread Roman Kapl
It failed to mention it is followed by a bit-mask and then the atoms. Signed-off-by: Roman Kapl --- include/X11/extensions/XI2proto.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/X11/extensions/XI2proto.h b/include/X11/extensions/XI2proto.h index

[PATCH xserver 1/2] Xi: fix byte-swapping of button labels

2018-06-06 Thread Roman Kapl
The byte-swapping code forgot that the xXIButtonInfo is followed by a button mask, not directly by the button labels. This resulted in client crashes in cross-endian setups, for example in `xinput list --long`, since the client got an invalid atom. A new function was introduced to get the right

Re: Obtaining Xorg DDX commit privilege

2018-06-06 Thread Kevin Brace
Hi Adam, Okay, I look forward to obtaining the commit privilege to xf86-video-* DDXs soon. That being said, for OpenChrome DDX, I do not really post patches on openchrome-devel mailing list, but for other xf86-video-* DDXs, should I always post patches on relevant mailing lists? For non-ATI

Re: Obtaining Xorg DDX commit privilege

2018-06-06 Thread Kevin Brace
Hi Adam, I was thinking that it is not really desirable to let VBE start tinkering with I2C bus related registers this early in the PreInit callback, and besides that, if r128 is being used on PowerPC (or Alpha or SPARC) platform, there is no INT 10H VBE. Furthermore, in order to detect

Re: [PATCH xserver] glamor: Enable modifier support for xfree86 too

2018-06-06 Thread Keith Packard
Adam Jackson writes: > This was left disabled in 1.20.0, it's time to start being sure it > works. > > Signed-off-by: Adam Jackson Yup. Acked-by: Keith Packard -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: Obtaining Xorg DDX commit privilege

2018-06-06 Thread Adam Jackson
On Tue, 2018-06-05 at 05:00 +0200, Kevin Brace wrote: > Hi everyone, > > I hope I am doing this right. > More than a week ago, I requested Xorg DDX commit privilege. > > https://bugs.freedesktop.org/show_bug.cgi?id=106605 > > Unfortunately, there has been no action taken so far. > I do have

Re: [PATCH xserver] exa: Use PictureMatchFormat for source-only picture format description

2018-06-06 Thread Adam Jackson
On Fri, 2018-06-01 at 11:58 +0200, Michel Dänzer wrote: > From: Michel Dänzer > > Their pFormat member is NULL, which resulted in a crash in > miRenderColorToPixel. > > Fixes: 8171d4c2d67b "render: Store and use all 16bpc of precision for > solid pixels (v2.1)" >

[PATCH xserver] glamor: Enable modifier support for xfree86 too

2018-06-06 Thread Adam Jackson
This was left disabled in 1.20.0, it's time to start being sure it works. Signed-off-by: Adam Jackson --- glamor/glamor_egl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c index 123e9f28d4..4a4ca4bd86 100644 ---

Re: Obtaining Xorg DDX commit privilege

2018-06-06 Thread Adam Jackson
On Wed, 2018-06-06 at 00:37 +0200, Kevin Brace wrote: > Regarding patch #5, it is based on the observation that starting X > Server with probing option does not really do anything inside PreInit > recall back, hence, there is no need to probe the monitor via VBE. This pattern is common among the

Re: Obtaining Xorg DDX commit privilege

2018-06-06 Thread Daniel Stone
Hi Kevin, On 5 June 2018 at 23:37, Kevin Brace wrote: > I did ask freedesktop.org to grant me commit privilege to xf86-video-* DDX > repositories, but I have yet to hear from them. > > https://bugs.freedesktop.org/show_bug.cgi?id=106605 For accounts, freedesktop.org are just a very low-value

Re: [PATCH app/xauth 2/2] Sort entries from most specific to most generic.

2018-06-06 Thread Michal Srb
On úterý 5. června 2018 17:46:05 CEST Walter Harms wrote: > MMh, so far i understand you do an add and then sort the whole thing. > perhaps it would be more easy to start with a sorted field and insert (add) > a key on the correct location ? That would work if we have the guarantee that the list