Re: [PATCH app/fonttosfnt 1/5] Constify a few string arguments

2018-07-30 Thread Alan Coopersmith
On 07/30/18 06:53 PM, Peter Hutterer wrote: Cuts down on compiler warning by at least 64%, what a bargain! Signed-off-by: Peter Hutterer Reviewed-by: Alan Coopersmith -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering -

Re: [PATCH app/fonttosfnt 5/5] Replace _BSD_SOURCE with _DEFAULT_SOURCE

2018-07-30 Thread Alan Coopersmith
On 07/30/18 06:53 PM, Peter Hutterer wrote: /usr/include/features.h:184:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" Signed-off-by: Peter Hutterer ---

Re: [PATCH app/fonttosfnt 4/5] Fix shadowing i variable complaint

2018-07-30 Thread Alan Coopersmith
On 07/30/18 06:53 PM, Peter Hutterer wrote: C99 is a magical thing! Signed-off-by: Peter Hutterer --- read.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Alan Coopersmith -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle

Re: [PATCH app/fonttosfnt 3/5] Remove shadowing rc variable

2018-07-30 Thread Alan Coopersmith
On 07/30/18 06:53 PM, Peter Hutterer wrote: All code paths assign rc and heck it immedately after. We can re-use the one "heck it immedately" -> "check it immediately" from the outer loop. Signed-off-by: Peter Hutterer --- read.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH app/fonttosfnt 3/5] Remove shadowing rc variable

2018-07-30 Thread Peter Hutterer
All code paths assign rc and heck it immedately after. We can re-use the one from the outer loop. Signed-off-by: Peter Hutterer --- read.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/read.c b/read.c index bee518c..98522b5 100644 --- a/read.c +++ b/read.c @@ -107,7 +107,7

[PATCH app/fonttosfnt 5/5] Replace _BSD_SOURCE with _DEFAULT_SOURCE

2018-07-30 Thread Peter Hutterer
/usr/include/features.h:184:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" Signed-off-by: Peter Hutterer --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH app/fonttosfnt 2/5] README: update repository URL to gitlab

2018-07-30 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- README | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/README b/README index 58f1062..fa3ad08 100644 --- a/README +++ b/README @@ -12,9 +12,7 @@ Please submit bug reports to the Xorg bugzilla: The master development code repository can

[PATCH app/fonttosfnt 4/5] Fix shadowing i variable complaint

2018-07-30 Thread Peter Hutterer
C99 is a magical thing! Signed-off-by: Peter Hutterer --- read.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/read.c b/read.c index 98522b5..632c7e7 100644 --- a/read.c +++ b/read.c @@ -58,7 +58,7 @@ FT_Ensure_Inited(void) int readFile(char *filename, FontPtr

[PATCH app/fonttosfnt 1/5] Constify a few string arguments

2018-07-30 Thread Peter Hutterer
Cuts down on compiler warning by at least 64%, what a bargain! Signed-off-by: Peter Hutterer --- fonttosfnt.h | 8 util.c | 10 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/fonttosfnt.h b/fonttosfnt.h index d6aa004..159535f 100644 --- a/fonttosfnt.h

Re: [PATCH app/xev] xev: fix 'mode' in default case (version 2)

2018-07-30 Thread Peter Hutterer
On Sat, Jul 28, 2018 at 08:28:36AM +, Eitan Adler wrote: > Signed-off-by: Eitan Adler To ssh://gitlab.freedesktop.org/xorg/app/xev d1f08f6..25bb70e master -> master thanks Cheers, Peter > --- > xev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: xmodmap really slow

2018-07-30 Thread Alan Hourihane
On 30/07/18 22:00, Adam Jackson wrote: > On Thu, 2018-07-26 at 12:25 +0100, Alan Hourihane wrote: >> Anyone tried just doing this recently >> >> xmodmap -pke > /tmp/keydump >> xmodmap /tmp/keydump >> >> And watch the Xserver hang for quite some time. > Seems to be nearly instantaneous against

Re: xmodmap really slow

2018-07-30 Thread Adam Jackson
On Thu, 2018-07-26 at 12:25 +0100, Alan Hourihane wrote: > Anyone tried just doing this recently > > xmodmap -pke > /tmp/keydump > xmodmap /tmp/keydump > > And watch the Xserver hang for quite some time. Seems to be nearly instantaneous against an Xvfb, but did cause a noticable hiccup with

[PATCH libICE] Always terminate strncpy results.

2018-07-30 Thread Tobias Stoeckmann
The function strncpy does not guarantee to append a terminating NUL character to the destination. This patch merges libSM's way of handling this issue into libICE. Signed-off-by: Tobias Stoeckmann --- src/connect.c| 66 +++- src/listen.c | 24