Re: [PATCH libXpm] After fdopen(), use fclose() instead of close() in error path

2018-10-11 Thread Alan Coopersmith
On 10/11/18 12:13 PM, Walter Harms wrote: Alan Coopersmith hat am 1. Oktober 2018 um 00:14 geschrieben: Found by Oracle's Parfait 2.2 static analyzer: Error: File Leak File Leak [file-ptr-leak]: Leaked File fp at line 94 of lib/libXpm/src/RdFToBuf.c in function

Re: [PATCH app/twm 1/2] When replacing a colormap, free old map, not new one

2018-10-11 Thread Walter Harms
> Alan Coopersmith hat am 30. September 2018 um > 23:44 geschrieben: > > > Found by Oracle's Parfait 2.2 static analyzer: > > Error: Use after free >Use after free [use-after-free] (CWE 416): > Use after free of pointer Scr > at line 421 of src/util.c in function

Re: [PATCH libXpm] After fdopen(), use fclose() instead of close() in error path

2018-10-11 Thread Walter Harms
> Alan Coopersmith hat am 1. Oktober 2018 um 00:14 > geschrieben: > > > Found by Oracle's Parfait 2.2 static analyzer: > > Error: File Leak >File Leak [file-ptr-leak]: > Leaked File fp > at line 94 of lib/libXpm/src/RdFToBuf.c in function > 'XpmReadFileToBuffer > '. >

[PATCH] xfree86: Only switch to original VT if it is active.

2018-10-11 Thread Michal Srb
If the X server is terminated while its VT is not active, it should not change the current VT. --- Changing the VT in that situation serves no purpose and can be confusing. For example when a user's graphical session is terminated while other user is using the computer, it would switch the VT he