[PATCH xf86-video-sis] Convert EXA support preprocessor macro to USE_EXA

2018-12-17 Thread Kevin Brace
All the other DDXs do it this way. Signed-off-by: Kevin Brace --- configure.ac | 2 +- src/sis.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index d74e197..1caa528 100644 --- a/configure.ac +++ b/configure.ac @@ -121,7 +121,7 @@

Re: Will like to see some action on ScreenWakeupHandlerProcPtr related patch

2018-12-17 Thread Alan Coopersmith
On 12/17/18 03:09 PM, Kevin Brace wrote: Hi, I posted a small patch related to ScreenWakeupHandlerProcPtr several days ago. https://lists.x.org/archives/xorg-devel/2018-December/057793.html https://patchwork.freedesktop.org/patch/268118/ I usually limit my work to DDXs, so this is the first

Will like to see some action on ScreenWakeupHandlerProcPtr related patch

2018-12-17 Thread Kevin Brace
Hi, I posted a small patch related to ScreenWakeupHandlerProcPtr several days ago. https://lists.x.org/archives/xorg-devel/2018-December/057793.html https://patchwork.freedesktop.org/patch/268118/ I usually limit my work to DDXs, so this is the first time I generated a patch for X Server

Re: [PATCH] Add 24-bit color support to exaGetPixmapFirstPixel

2018-12-17 Thread Kevin Brace
Hi Adam, Not that it matters, but I am actually writing this e-mail from a computer that has SiS6326 in it. It is an Intel Celeron 2.0A GHz (Pentium 4 based) computer along with a mainboard support for "legacy" (i.e., 3.3 V signaling) AGP cards. The mainboard even has support for ACPI S3 State

[PATCH xf86-video-trident 1/2] Use const char for xf86GetOptValString return type

2018-12-17 Thread Kevin Brace
Apparently, xf86GetOptValString changed their return type from char to const char between X Server 1.15 and 1.16. In particular, X Server commit e1e01d2e33c632e395d7e396f73fba8ae606b15a made the change. This commit will suppress the compilation warning. Signed-off-by: Kevin Brace ---

[PATCH xf86-video-apm 4/4] Use libpciaccess for newer X Servers when unmapping video RAM

2018-12-17 Thread Kevin Brace
Commit d1e29902483a82e86b07cd30d41d411e71b776ea missed using XSERVER_LIBPCIACCESS conditional compilation keyword when unmapping video RAM. This meant that the code was not getting compiled correctly for newer X Servers due to the missing xf86UnMapVidMem. Signed-off-by: Kevin Brace ---

[PATCH xf86-video-apm 3/4] Eliminate unused variable compilation warnings

2018-12-17 Thread Kevin Brace
Signed-off-by: Kevin Brace --- src/apm_dga.c| 1 - src/apm_driver.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/apm_dga.c b/src/apm_dga.c index 6e92123..a2ff48e 100644 --- a/src/apm_dga.c +++ b/src/apm_dga.c @@ -236,7 +236,6 @@ ApmDGAInit(ScreenPtr pScreen)

[PATCH xf86-video-apm 2/4] Use const char for xf86GetOptValString return type

2018-12-17 Thread Kevin Brace
Signed-off-by: Kevin Brace --- src/apm_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/apm_driver.c b/src/apm_driver.c index ece599e..92da51c 100644 --- a/src/apm_driver.c +++ b/src/apm_driver.c @@ -355,7 +355,8 @@ ApmPreInit(ScrnInfoPtr pScrn, int flags)

[PATCH xf86-video-apm 1/4] Remove miInitializeBackingStore

2018-12-17 Thread Kevin Brace
Apparently, it is no longer available. Signed-off-by: Kevin Brace --- src/apm_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/apm_driver.c b/src/apm_driver.c index e40e1c2..ece599e 100644 --- a/src/apm_driver.c +++ b/src/apm_driver.c @@ -1784,7 +1784,6 @@

[PATCH xf86-video-sis 4/4] Eliminate constant related compilation warnings for native functions

2018-12-17 Thread Kevin Brace
Signed-off-by: Kevin Brace --- src/sis_driver.c | 2 +- src/sis_utility.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sis_driver.c b/src/sis_driver.c index 8e86c06..8a62572 100644 --- a/src/sis_driver.c +++ b/src/sis_driver.c @@ -1305,7 +1305,7 @@

[PATCH xf86-video-sis 3/4] Eliminate swap macro related unused variable compilation warnings

2018-12-17 Thread Kevin Brace
Unfortunately, commit c530ebb5d4ad0663838a0132e3610d713eaaa640 did not the check for ABI_VIDEODRV_VERSION where the swap macros are actually used in the code. Checking for ABI_VIDEODRV_VERSION suppresses unused variable compilation warnings for newer versions of the X Server. Signed-off-by: Kevin

[PATCH xf86-video-sis 1/4] Eliminate set but not used variable compilation warnings

2018-12-17 Thread Kevin Brace
Signed-off-by: Kevin Brace --- src/sis_driver.c | 18 ++ src/sis_video.c | 12 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/src/sis_driver.c b/src/sis_driver.c index 31a7ada..d5ba1bd 100644 --- a/src/sis_driver.c +++ b/src/sis_driver.c @@ -6192,7

[PATCH xf86-video-sis 2/4] Suppress logical operation and parenthesis related compilation warnings

2018-12-17 Thread Kevin Brace
Signed-off-by: Kevin Brace --- src/sis_cursor.c | 2 +- src/sis_utility.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sis_cursor.c b/src/sis_cursor.c index 32dcd9d..76a04b4 100644 --- a/src/sis_cursor.c +++ b/src/sis_cursor.c @@ -759,7 +759,7 @@

Re: [PATCH] Add 24-bit color support to exaGetPixmapFirstPixel

2018-12-17 Thread Adam Jackson
On Thu, 2018-12-13 at 22:32 -0600, Kevin Brace wrote: > It appears that people who developed EXA forgot that there used to be > graphics devices that used 24-bits (3 bytes) instead of 32-bits (4 bytes) > in order to display one pixel. The lack of 24-bit color support inside >