Re: Will like to see some action on ScreenWakeupHandlerProcPtr related patch

On Tue, Dec 18, 2018 at 3:16 PM Kevin Brace wrote: > > Hi Alan, > > I am not asking to change the ABI. > I just spotted an inconsistency in how ScreenWakeupHandlerProcPtr is defined > inside compat-api.h and scrnintstr.h. > That appears the root of the problem. > I consider this a bug. > If I

[PATCH xf86-video-s3virge 2/3] Eliminate unused variable compilation warnings

Signed-off-by: Kevin Brace --- src/s3v_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/s3v_driver.c b/src/s3v_driver.c index a9d47b4..ae58ec6 100644 --- a/src/s3v_driver.c +++ b/src/s3v_driver.c @@ -478,8 +478,6 @@ S3VPreInit(ScrnInfoPtr pScrn, int flags) int i;

[PATCH xf86-video-s3virge 1/3] Use const char for xf86GetOptValString return type

Signed-off-by: Kevin Brace --- src/s3v_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/s3v_driver.c b/src/s3v_driver.c index e5dd2e4..a9d47b4 100644 --- a/src/s3v_driver.c +++ b/src/s3v_driver.c @@ -480,7 +480,7 @@ S3VPreInit(ScrnInfoPtr pScrn, int flags)

[PATCH xf86-video-s3virge 3/3] Eliminate unused function compilation warnings

It is an XAA related issue. Signed-off-by: Kevin Brace --- src/s3v_accel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/s3v_accel.c b/src/s3v_accel.c index 587ce97..d22e5f0 100644 --- a/src/s3v_accel.c +++ b/src/s3v_accel.c @@ -465,7 +465,7 @@

[PATCH xf86-video-s3 1/4] Discontinue the use of xf86PciInfo.h

Signed-off-by: Kevin Brace --- src/s3.h| 19 ++- src/s3_driver.c | 1 - src/s3_shadow.c | 1 - 3 files changed, 18 insertions(+), 3 deletions(-) diff --git a/src/s3.h b/src/s3.h index 206d1f5..72a1072 100644 --- a/src/s3.h +++ b/src/s3.h @@ -34,7 +34,6 @@ #include

[PATCH xf86-video-s3 4/4] Eliminate unused variable compilation warning

Signed-off-by: Kevin Brace --- src/s3_video.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/s3_video.c b/src/s3_video.c index 998ce74..a362f44 100644 --- a/src/s3_video.c +++ b/src/s3_video.c @@ -63,7 +63,6 @@ static FBLinearPtr S3XVMemAlloc(ScrnInfoPtr pScrn, pointer pVideo, int

[PATCH xf86-video-s3 3/4] Eliminate set but not used variable compilation warnings

Signed-off-by: Kevin Brace --- src/s3_IBMRGB.c | 3 +-- src/s3_driver.c | 4 +--- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/s3_IBMRGB.c b/src/s3_IBMRGB.c index bc1cd1c..58500ba 100644 --- a/src/s3_IBMRGB.c +++ b/src/s3_IBMRGB.c @@ -157,7 +157,7 @@ static void

[PATCH xf86-video-s3 2/4] Use const char for xf86GetOptValString return type

Signed-off-by: Kevin Brace --- src/s3_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/s3_driver.c b/src/s3_driver.c index b3867ba..a66f4a2 100644 --- a/src/s3_driver.c +++ b/src/s3_driver.c @@ -307,7 +307,7 @@ static Bool S3PreInit(ScrnInfoPtr pScrn, int flags)

Re: [PATCH] Add 24-bit color support to exaGetPixmapFirstPixel

On Mon, 2018-12-17 at 23:54 +0100, Kevin Brace wrote: > The rendering is fine for the login screen as far as I am concerned, > so I would imagine that EXA can theoretically support 24 bpp, but no > one really tried since by the time EXA was developed, every new > graphics had 32 bpp support, and

Re: Will like to see some action on ScreenWakeupHandlerProcPtr related patch

Hi Alan, I am not asking to change the ABI. I just spotted an inconsistency in how ScreenWakeupHandlerProcPtr is defined inside compat-api.h and scrnintstr.h. That appears the root of the problem. I consider this a bug. If I apply the patch to X Server's header file, the warning goes away.

Re: Will like to see some action on ScreenWakeupHandlerProcPtr related patch

On Mon, Dec 17, 2018 at 6:09 PM Kevin Brace wrote: > I posted a small patch related to ScreenWakeupHandlerProcPtr several days ago. > > https://lists.x.org/archives/xorg-devel/2018-December/057793.html No need to start an additional thread... ___

Re: [PATCH xorgproto] XF86keysym: Add XF86XK_MonBrightnessCycle

> Add XF86XK_MonBrightnessCycle keysym, to be used as mapping for evdev's > KEY_BRIGHTNESS_CYCLE keycode which is generated from ACPI video module's > ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS on some Acer AIO desktop buttons. > The button changes the screen's brightness on Windows. > > Fixes: