to 73b2660d7273d175d279d22f8ca0c3932a14ff1c:
Avoid use-after-free in dix/dixfonts.c: doImageText() [CVE-2013-4396]
(2013-10-14 17:56:44 -0700)
Alan Coopersmith (4):
Skip damage calls if DamageCreate fails in exa functions
DMX
, and thus fail to compile.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
-by: Pedro Ribeiro ped...@gmail.com
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Reviewed-by: Julien Cristau jcris...@debian.org
---
dix/dixfonts.c |5 +
1 file changed, 5 insertions(+)
diff --git a/dix/dixfonts.c b/dix/dixfonts.c
index feb765d..2e34d37 100644
--- a/dix/dixfonts.c
.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org
MatchIsPointer on
Option CloseOnDPMS on
EndSection
and those who are using desktops instead of battery-powered devices can
simply remove it. Mechanism in the code, policy in the config.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering
is failing because a random
structure containing a pointer was calloc'ed.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org
= \
-I$(top_srcdir)/include
CC = @CC_FOR_BUILD@
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg
such systems X was ever ported to? Of the ones listed on
http://c-faq.com/null/machexamp.html, Cray is the closest to anything I've
heard of X being ported to, and I'm not sure which model it was, but it was
broken since at least X11R6.
--
-Alan Coopersmith- alan.coopersm
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
.gitignore |1 +
Makefile.am |2 +-
configure.ac | 10 ++---
test/Array.c | 62 ++
test/Makefile.am | 13
5 files changed, 84
Since the API is defined with size as a signed int, deal with it.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
Array.c | 16
test/Array.c |4
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/Array.c b/Array.c
index cb57d89
Use calloc for the array of pointers to ensure pointers are cleared out
so we don't try to free garbage if XdmcpDisposeARRAYofARRAY8 is called
before the caller sets them to valid pointers.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
Array.c | 19
Previous fix missed a case in which we returned failure, but didn't
fill in the data pointer size values.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
Array.c | 44
1 file changed, 16 insertions(+), 28 deletions(-)
diff --git
-config.h])
Is your tree out of date? That fix was pushed earlier this year:
http://cgit.freedesktop.org/xorg/util/makedepend/commit/?id=01238aa25c3bb1e0c909f63dd3bc97c48bd8bf6d
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http
],
[https://bugs.freedesktop.org/enter_bug.cgi?product=xorg], [rstart])
AC_CONFIG_SRCDIR([Makefile.am])
-AC_CONFIG_MACRO_DIR([m4])
AC_CONFIG_HEADERS(config.h)
# Initialize Automake
With the commit comment fixed,
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan
On 09/22/13 09:27 AM, Matthieu Herrb wrote:
On Sun, Sep 22, 2013 at 08:59:42AM -0700, Alan Coopersmith wrote:
On 09/21/13 07:49 AM, devz...@web.de wrote:
Deliberately breaking drivers without giving people a chance to fix them
isn't fair. Because of the current development model of Xorg
)/libXaw.7.@LIBEXT@
+ $(AM_V_at)rm -f $(DESTDIR)$(libdir)/libXaw.7.@LIBEXT@
else
- -rm -f $(DESTDIR)$(libdir)/libXaw.@LIBEXT@.7
+ $(AM_V_at)rm -f $(DESTDIR)$(libdir)/libXaw.@LIBEXT@.7
endif
endif
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan
On 09/23/13 01:04 PM, Mark Kettenis wrote:
Date: Mon, 23 Sep 2013 09:11:26 -0700
From: Alan Coopersmith alan.coopersm...@oracle.com
On 09/22/13 09:27 AM, Matthieu Herrb wrote:
On Sun, Sep 22, 2013 at 08:59:42AM -0700, Alan Coopersmith wrote:
On 09/21/13 07:49 AM, devz...@web.de wrote
On 09/22/13 06:20 AM, Gaetan Nadon wrote:
On 13-09-21 01:48 PM, Alan Coopersmith wrote:
On 09/21/13 09:58 AM, Gaetan Nadon wrote:
Signed-off-by: Gaetan Nadon mems...@videotron.ca
---
src/Makefile.am |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/Makefile.am b
to a year and a half old e-mail. People have had plenty of
chance to fix the drivers they still use now, and most of the ones people use
have been fixed.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
to configure.ac or xorg-macros, or does
automake automatically call it already?
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org
xf86-video-mach64
build driver xf86-video-mga
+build driver xf86-video-modesetting
build driver xf86-video-neomagic
build driver xf86-video-nv
build driver xf86-video-rendition
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith
://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org
---
hw/xfree86/dixmods/Makefile.am |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xfree86/dixmods/Makefile.am b/hw/xfree86/dixmods/Makefile.am
index 9933bc8..3c43640 100644
--- a/hw/xfree86/dixmods/Makefile.am
+++ b/hw/xfree86/dixmods/Makefile.am
@@ -32,7 +32,7 @@
the binary makestrs.
Does the resulting makestrs work? It needs to have the right flags for
generating the code for the target platform. (This code really really
really wasn't designed for cross-compiling, and I'm constantly surprised
cross-compiling even appears to work.)
--
-Alan
forbids mixed declarations and code
[-Wdeclaration-after-statement]
Remove the lines after the loop and gcc is as happy as a clam, so I'm
okay having the warning in our default CFLAGS, as it still lets me have
this C99 syntax addition.
--
-Alan Coopersmith- alan.coopersm
now that
it's no longer a hard requirement for OpenBSD's ports?
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives
delete it?
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info
On 09/11/13 08:52 PM, Daniel Stone wrote:
Hi,
On 11 September 2013 17:31, Mark Kettenis mark.kette...@xs4all.nl wrote:
From: Alan Coopersmith alan.coopersm...@oracle.com
Pushing the patch is easy - determining if it's our consensus to change
the X.Org coding style to allow this is the hard
Leaves behind several no-op macros for compatibility with existing
code that uses them.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
Xmd.h| 81 ++
Xproto.h | 13 --
2 files changed, 18 insertions
declarations in #ifndef HAVE_ARC4RANDOM_BUF?
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http
On 09/ 5/13 11:43 PM, Matthieu Herrb wrote:
arc4random() and associated functions can be found in libbsd on
GNU/Linux systems.
Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr
Thanks for revising it,
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith
else the latter?
Nope - those go into two different servers. The first is only if you're
running Xdmx, the second is if you're running Xorg.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
to the client.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
hw/dmx/glxProxy/glxsingle.c | 30 +-
hw/dmx/glxProxy/glxvendor.c | 30 +-
2 files changed, 34 insertions(+), 26 deletions(-)
diff --git a/hw/dmx/glxProxy/glxsingle.c b
;
}
if (src-drawable.width != msk-drawable.width
|| src-drawable.height != msk-drawable.height
|| msk-drawable.depth != 1)
return BadMatch;
}
else
msk = NULL;
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle
being worthwhile,
as it would be far more complex than this simple solution.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org
When debugging, helps figure out which options the distro or builder
chose to enable or disable.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
xdm/dm.c | 43 ++-
1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/xdm/dm.c b
calls to DamageCreate.
[ This bug was found by the Parfait 1.3.0 bug checking tool.
http://labs.oracle.com/pls/apex/f?p=labs:49:P49_PROJECT_ID:13 ]
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
exa/exa_migration_mixed.c | 11 +++
exa/exa_mixed.c | 11
Length of 20 with unspecified contents was accidentally split into
a length of 2 and contents of 0 in the docbook conversion.
Verified against old spec in http://www.x.org/docs/Xext/bigreq.pdf
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
specs/bigreq.xml |4 ++--
1 file
of them have it yet. Version numbers
are also often shown in our man pages in the header or footer, and of course
in our source tarball names and the configure scripts in them.)
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http
On 08/26/13 02:33 AM, Sedat Dilek wrote:
On Sun, Aug 25, 2013 at 7:51 PM, Alan Coopersmith
alan.coopersm...@oracle.com wrote:
On 08/25/13 07:04 AM, Sedat Dilek wrote:
[ CC Alan C. ]
Looking at [1], this patch was not pushed.
Any reason speaking against it?
I thought someone else had
the last release to make it worth spending
5 minutes to roll out new tarballs.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org
)now, (long long)d-lastReserv,
d-reservTries, d-reservAttempts,
crash ? crash : );
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering
for ensuring our key_sym_map accesses are in range.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Reported-by: Barry Kauler bkau...@gmail.com
Tested-by: Barry Kauler bkau...@gmail.com
---
src/xkb/XKBGetMap.c |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
be greater than low-mark);
}
if (i = argc) {
set_font_cache(dpy, himark, lowmark, balance);
Guess I missed this due to not building with FONTCACHE support.
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
);
+fputs (command, inFile);
len = pclose (fp);
remove (aout);
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
efficient by not having to parse the string, and clearing a warning about the
format string so it's easier to find the real issues in our code base.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
On 08/12/13 07:07 AM, walter harms wrote:
+if (_XlcLocaleLibDirName(lc_lib_dir, BUFSIZE, lc_name) == (char*)NULL)
return (XLCd)NULL;
== (char*)NULL ?? why not == NULL ?
Mainly because I wasn't looking at that side and didn't notice. Fixed now.
--
-Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
XKBstr.h |6 --
1 file changed, 6 deletions(-)
diff --git a/XKBstr.h b/XKBstr.h
index 1146908..3449bda 100644
--- a/XKBstr.h
+++ b/XKBstr.h
@@ -31,13 +31,7 @@ THE USE OR PERFORMANCE OF THIS SOFTWARE.
#define
or not.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
XKBgeom.h |5 +
XKBstr.h | 21 +
2 files changed, 26 insertions(+)
diff --git a/XKBgeom.h b/XKBgeom.h
index f603852..cef78fa 100644
--- a/XKBgeom.h
+++ b/XKBgeom.h
@@ -95,6 +95,11 @@ typedef struct
picture/introduction
for those who haven't been closely following DRI3000 development.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org
/Presentation_Manager
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http
On 08/13/13 02:47 PM, Keith Packard wrote:
Alan Coopersmith alan.coopersm...@oracle.com writes:
Can you remind me what it actually does? I see several posts on your
blog describing various features, but didn't see a big picture/introduction
for those who haven't been closely following DRI3000
-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/xlibi18n/XlcDL.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/xlibi18n/XlcDL.c b/src/xlibi18n/XlcDL.c
index 75e193c..79e8a2f 100644
--- a/src/xlibi18n/XlcDL.c
+++ b/src/xlibi18n/XlcDL.c
@@ -216,7 +216,8 @@ Limit
instead of on every reference.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/xlibi18n/lcFile.c | 35 +++
1 file changed, 15 insertions(+), 20 deletions(-)
diff --git a/src/xlibi18n/lcFile.c b/src/xlibi18n/lcFile.c
index 61a14e7..03ece75
to resolve these, and some things are hard to unsee.
Perhaps one of these days I'll learn my lesson and ignore the warnings
from the compilers static analyzers that end up sending me down these
ratholes, but I may just be a little too OCD-like to quit cold turkey.
Alan Coopersmith (22):
Fix
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Reviewed-by: Matthieu Herrb matthieu.he...@laas.fr
---
src/xlibi18n/XlcDL.c |7 +-
src/xlibi18n/lcDynamic.c |4 ++--
src/xlibi18n/lcFile.c| 31 +++--
src/xlibi18n/lcGeneric.c | 58
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Reviewed-by: Matthieu Herrb matthieu.he...@laas.fr
---
modules/im/ximcp/imRm.c | 44 ++--
1 file changed, 30 insertions(+), 14 deletions(-)
diff --git a/modules/im/ximcp/imRm.c b/modules/im
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Reviewed-by: Matthieu Herrb matthieu.he...@laas.fr
---
modules/om/generic/omGeneric.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/modules/om/generic/omGeneric.c b/modules/om/generic
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/xlibi18n/lcDB.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/xlibi18n/lcDB.c b/src/xlibi18n/lcDB.c
index 97b22ac..5048122 100644
--- a/src/xlibi18n/lcDB.c
+++ b/src/xlibi18n/lcDB.c
@@ -210,11
Previously, if realloc failed to increase the size, we'd still
record that we had allocated the larger size, but the pointer
to it would be NULL, causing future calls to be broken, and the
previous allocation to be lost/leaked.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
modules/im/ximcp/imLcPrs.c | 35 +--
1 file changed, 25 insertions(+), 10 deletions(-)
diff --git a/modules/im/ximcp/imLcPrs.c b/modules/im/ximcp/imLcPrs.c
index f3627a0..34cfcad 100644
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
include/X11/Xregion.h |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/X11/Xregion.h b/include/X11/Xregion.h
index c25d70b..cf10f86 100644
--- a/include/X11/Xregion.h
+++ b/include/X11/Xregion.h
, but if it does, might as well keep
the correct value for the number of allocated rectangles, so we
don't try to grow it unnecessarily later if adding to the region.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/Region.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Reviewed-by: Matthieu Herrb matthieu.he...@laas.fr
---
src/xkb/XKBlibint.h |6 --
1 file changed, 6 deletions(-)
diff --git a/src/xkb/XKBlibint.h b/src/xkb/XKBlibint.h
index 7b41c3b..6c85558 100644
--- a/src/xkb/XKBlibint.h
[-Wcast-qual]
lcWrap.c:91:25: warning: cast discards '__attribute__((const))' qualifier from
pointer target type [-Wcast-qual]
lcWrap.c:93:12: warning: cast discards '__attribute__((const))' qualifier from
pointer target type [-Wcast-qual]
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
a gcc const-cast warning in
the process).
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Reviewed-by: Matthieu Herrb matthieu.he...@laas.fr
---
src/xlibi18n/XDefaultOMIF.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/xlibi18n
pointer target type [-Wcast-qual]
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/xlibi18n/XlcDL.c |6 ++--
src/xlibi18n/XlcPubI.h |4 +--
src/xlibi18n/lcFile.c | 86 +---
3 files changed, 35 insertions(+), 61 deletions
Add const qualifiers to casts where needed, remove other casts that
are no longer needed.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/xlibi18n/lcCT.c | 10 +-
src/xlibi18n/lcPublic.c |3 ++-
src/xlibi18n/mbWrap.c | 12 +---
src/xlibi18n
:P49_PROJECT_ID:13 ]
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/xlibi18n/lcFile.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/xlibi18n/lcFile.c b/src/xlibi18n/lcFile.c
index 6b0e4c9..bf89084 100644
--- a/src/xlibi18n/lcFile.c
+++ b/src
sizeof() returns size_t, malloc() calloc() expect sizes in size_t,
don't strip down to unsigned int and re-expand unnecessarily.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/xcms/CCC.c|5 ++---
src/xcms/cmsCmap.c|5 ++---
src/xcms/cmsInt.c |4
Left one cast behind that is necessary to change from const char *
to char * in src/xlibi18n/lcCharSet.c.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
modules/im/ximcp/imDefIm.c |4 +--
modules/im/ximcp/imLcIm.c |2 +-
modules/im/ximcp/imThaiIm.c |2 +-
modules
I can find no record of what this file was for. Neither the X11R6.8.2
monolith Imakefile nor any modular release Makefile.am have ever built
it and nothing else references it.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
configure.ac|2 -
src/Makefile.am |5 -
src
On 08/12/13 09:40 AM, Julien Cristau wrote:
Makes the definition match other declarations, and xserver's definition.
Debian bug#689439
Reported-by: Michael Tautschnig m...@debian.org
Signed-off-by: Julien Cristau jcris...@debian.org
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
asprintf() but rejected it since it wouldn't work well there.)
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives
On 08/11/13 02:46 AM, Matthieu Herrb wrote:
On Sat, Aug 10, 2013 at 01:54:59PM -0700, Alan Coopersmith wrote:
Previous code seemed to assume that printf(%s, NULL) would result
in a 0-length string, not (null) or similar, but since there's no
point looking for files in (null)/filepath
a removal patch instead.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
On 08/11/13 03:37 AM, Matthieu Herrb wrote:
On Sat, Aug 10, 2013 at 01:55:04PM -0700, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
I'm wondering here if firstrect() shouldn't be free()'d when Xrealloc
fails. I can't tell from reading the code what
On 08/11/13 05:21 AM, Matthieu Herrb wrote:
On Sat, Aug 10, 2013 at 01:55:06PM -0700, Alan Coopersmith wrote:
Don't want later users of the function to think there's more or less
memory allocated than there really is.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
For this one
On 08/11/13 03:30 AM, Matthieu Herrb wrote:
On Sat, Aug 10, 2013 at 01:55:05PM -0700, Alan Coopersmith wrote:
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Here (and in patch 06) I'm quite sure that the old b-mb (resp. b-wc)
should be free()'d on the error path, since we're
On 08/11/13 08:10 PM, Alan Coopersmith wrote:
In patch 6, since it's a static variable it's easier to track down and
see the callers currently don't check for error, but it looks like they
won't actually dereference the pointer unless the count is greater than
zero, so I'll rework that one now
Previous code seemed to assume that printf(%s, NULL) would result
in a 0-length string, not (null) or similar, but since there's no
point looking for files in (null)/filepath..., instead we just
skip over NULL entries in search paths when generating file names.
Signed-off-by: Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
modules/im/ximcp/imRm.c | 44 ++--
1 file changed, 30 insertions(+), 14 deletions(-)
diff --git a/modules/im/ximcp/imRm.c b/modules/im/ximcp/imRm.c
index dd0b99e..4c46252 100644
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
modules/om/generic/omGeneric.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/modules/om/generic/omGeneric.c b/modules/om/generic/omGeneric.c
index ae43283..1a4f971 100644
--- a/modules
Previously, if realloc failed to increase the size, we'd still
record that we had allocated the larger size, but the pointer
to it would be NULL, causing future calls to be broken, and the
previous allocation to be lost/leaked.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/udcInf.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/src/udcInf.c b/src/udcInf.c
index 9ecf156..faec421 100644
--- a/src/udcInf.c
+++ b/src/udcInf.c
@@ -131,7 +131,7 @@ int
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/xlibi18n/lcDB.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/xlibi18n/lcDB.c b/src/xlibi18n/lcDB.c
index 97b22ac..5048122 100644
--- a/src/xlibi18n/lcDB.c
+++ b/src/xlibi18n/lcDB.c
@@ -210,11
Don't want later users of the function to think there's more or less
memory allocated than there really is.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/Region.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/Region.c b/src/Region.c
index
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
include/X11/Xregion.h |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/X11/Xregion.h b/include/X11/Xregion.h
index c25d70b..cf10f86 100644
--- a/include/X11/Xregion.h
+++ b/include/X11/Xregion.h
-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/xlibi18n/XlcDL.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/xlibi18n/XlcDL.c b/src/xlibi18n/XlcDL.c
index 75e193c..79e8a2f 100644
--- a/src/xlibi18n/XlcDL.c
+++ b/src/xlibi18n/XlcDL.c
@@ -216,7 +216,8 @@ Limit
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
modules/im/ximcp/imLcPrs.c | 35 +--
1 file changed, 25 insertions(+), 10 deletions(-)
diff --git a/modules/im/ximcp/imLcPrs.c b/modules/im/ximcp/imLcPrs.c
index f3627a0..34cfcad 100644
a gcc const-cast warning in
the process).
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/xlibi18n/XDefaultOMIF.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/xlibi18n/XDefaultOMIF.c b/src/xlibi18n/XDefaultOMIF.c
index b1dc66d
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
---
src/xkb/XKBlibint.h |6 --
1 file changed, 6 deletions(-)
diff --git a/src/xkb/XKBlibint.h b/src/xkb/XKBlibint.h
index 7b41c3b..6c85558 100644
--- a/src/xkb/XKBlibint.h
+++ b/src/xkb/XKBlibint.h
@@ -106,12 +106,6 @@ typedef
On 08/ 4/13 01:53 AM, Matthieu Herrb wrote:
arc4random() and associated functions can be found in libbsd on
GNU/Linux systems.
Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith
understands it.
I'll probably just push your patch when I have some spare time as it looks
reasonable enough, and putting it in is the only way we'll ever get it tested
to find out if it makes things better or breaks something else.
--
-Alan Coopersmith- alan.coopersm
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman
case).
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http
to a release yet.
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http
)
-AM_CPPFLAGS = $(XORG_INCS)
libint10_la_SOURCES = stub.c xf86int10module.c
endif
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
Code to recognize these in extension enable/disable options was wrapped
in #ifdef XorgLoader, but that's not defined when building miinitext.c
since the great module merge of 1.13. Change to an #ifdef that is defined.
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com
Reviewed
, but not yet annoyed me enough to do something about it.
Thanks for taking care of these.
Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com
--
-Alan Coopersmith- alan.coopersm...@oracle.com
Oracle Solaris Engineering - http://blogs.oracle.com/alanc
1001 - 1100 of 3754 matches
Mail list logo
